filter out localhost and local ips from canvashttp
test plan: * use the API to queue a content migration for a course with a parameter 'file_url' set to a local url (i.e. 'localhost:3000/500.html') * it should not download the file and allow the file to be downloaded on the content migrations page for the course * create a link to a local file in a piece of course content (i.e. a page) * run the course link validator * it should not actually check if the link exists locally or not, but rather always flag the link closes #SEC-606 SEC-607 Change-Id: I671c017ec93d88446df77d716725fff8874622bc Reviewed-on: https://gerrit.instructure.com/125118 Tested-by: Jenkins Reviewed-by:Brad Horrocks <bhorrocks@instructure.com> Reviewed-by:
Simon Williams <simon@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
Showing
- app/models/attachment.rb 1 addition, 1 deletionapp/models/attachment.rb
- config/initializers/canvas_http.rb 2 additions, 1 deletionconfig/initializers/canvas_http.rb
- gems/canvas_http/lib/canvas_http.rb 22 additions, 3 deletionsgems/canvas_http/lib/canvas_http.rb
- gems/canvas_http/spec/canvas_http_spec.rb 19 additions, 1 deletiongems/canvas_http/spec/canvas_http_spec.rb
- lib/canvas/migration/archive.rb 1 addition, 1 deletionlib/canvas/migration/archive.rb
- spec/lib/course_link_validator_spec.rb 25 additions, 0 deletionsspec/lib/course_link_validator_spec.rb
- spec/spec_helper.rb 1 addition, 0 deletionsspec/spec_helper.rb
Loading
Please register or sign in to comment