diff --git a/lms/djangoapps/courseware/courses.py b/lms/djangoapps/courseware/courses.py index caccff13132dcadd1c272e1924d820ca151e3c57..73edd42badb7d8f504697ddaaa62e8855f6ef214 100644 --- a/lms/djangoapps/courseware/courses.py +++ b/lms/djangoapps/courseware/courses.py @@ -77,7 +77,7 @@ def get_course_by_id(course_key, depth=0): if course: return course else: - raise Http404("Course not found: {}.".format(unicode(course_key))) + raise Http404(u"Course not found: {}.".format(unicode(course_key))) def get_course_with_access(user, action, course_key, depth=0, check_if_enrolled=False, check_survey_complete=True): diff --git a/lms/djangoapps/courseware/views/index.py b/lms/djangoapps/courseware/views/index.py index a9768fc1af51d871d1d607bacafe5276b50effe5..a8af5b970b28de2a0ceb7b4697c8fed0c7cbf6ec 100644 --- a/lms/djangoapps/courseware/views/index.py +++ b/lms/djangoapps/courseware/views/index.py @@ -151,7 +151,7 @@ class CoursewareIndex(View): return self.render(request) except Exception as exception: # pylint: disable=broad-except - return CourseTabView.handle_exceptions(request, self.course, exception) + return CourseTabView.handle_exceptions(request, self.course_key, self.course, exception) def _setup_masquerade_for_effective_user(self): """ @@ -315,7 +315,7 @@ class CoursewareIndex(View): if not child: # User may be trying to access a child that isn't live yet if not self._is_masquerading_as_student(): - raise Http404('No {block_type} found with name {url_name}'.format( + raise Http404(u'No {block_type} found with name {url_name}'.format( block_type=block_type, url_name=url_name, )) diff --git a/lms/djangoapps/courseware/views/views.py b/lms/djangoapps/courseware/views/views.py index 18a5b220ac9d0d8dbcfe1d671da47b50a87db1e4..599efdc15372c7355add4225cd954fce1e8f60f7 100644 --- a/lms/djangoapps/courseware/views/views.py +++ b/lms/djangoapps/courseware/views/views.py @@ -509,7 +509,7 @@ class CourseTabView(EdxFragmentView): set_custom_metrics_for_course_key(course_key) return super(CourseTabView, self).get(request, course=course, page_context=page_context, **kwargs) except Exception as exception: # pylint: disable=broad-except - return CourseTabView.handle_exceptions(request, course, exception) + return CourseTabView.handle_exceptions(request, course_key, course, exception) @staticmethod def url_to_enroll(course_key): @@ -560,14 +560,12 @@ class CourseTabView(EdxFragmentView): ) @staticmethod - def handle_exceptions(request, course, exception): + def handle_exceptions(request, course_key, course, exception): """ Handle exceptions raised when rendering a view. """ if isinstance(exception, Redirect) or isinstance(exception, Http404): raise - if isinstance(exception, UnicodeEncodeError): - raise Http404("URL contains Unicode characters") if settings.DEBUG: raise user = request.user @@ -576,7 +574,7 @@ class CourseTabView(EdxFragmentView): request.path, getattr(user, 'real_user', user), user, - None if course is None else text_type(course.id), + text_type(course_key), ) try: return render_to_response(