diff --git a/common/lib/xmodule/xmodule/video_module/transcripts_utils.py b/common/lib/xmodule/xmodule/video_module/transcripts_utils.py index 5009feb497f6934ec66d3b72be4fd8390fbd7b7a..89e68c362ff99046125435987b9253406126907d 100644 --- a/common/lib/xmodule/xmodule/video_module/transcripts_utils.py +++ b/common/lib/xmodule/xmodule/video_module/transcripts_utils.py @@ -661,9 +661,11 @@ class Transcript(object): try: # With error handling (set to 'ERROR_RAISE'), we will be getting # the exception if something went wrong in parsing the transcript. + if isinstance(content, text_type): + content = content.encode('utf-8') srt_subs = SubRipFile.from_string( # Skip byte order mark(BOM) character - content.encode('utf-8').decode('utf-8-sig'), + content.decode('utf-8-sig'), error_handling=SubRipFile.ERROR_RAISE ) except Error as ex: # Base exception from pysrt diff --git a/lms/djangoapps/courseware/views/views.py b/lms/djangoapps/courseware/views/views.py index e4bdba694e3bbe8cc45192faf8c25e5bc6a5db73..e933980f036761b9e0722ed673b3e10c0bfabc1c 100644 --- a/lms/djangoapps/courseware/views/views.py +++ b/lms/djangoapps/courseware/views/views.py @@ -294,9 +294,9 @@ def yt_video_metadata(request): status_code = res.status_code if res.status_code == 200: try: - res = res.json() - if res.get('items', []): - response = res + res_json = res.json() + if res_json.get('items', []): + response = res_json else: logging.warning(u'Unable to find the items in response. Following response ' u'was received: {res}'.format(res=res.text)) diff --git a/requirements/edx/base.txt b/requirements/edx/base.txt index 35696a3f3f72b281e93d7c171824904a74f33434..be0022cb15a55d5e72a8a80c56f9cf5783b3eaf7 100644 --- a/requirements/edx/base.txt +++ b/requirements/edx/base.txt @@ -251,7 +251,7 @@ webencodings==0.5.1 # via html5lib webob==1.8.5 # via xblock wrapt==1.10.5 git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.2.6#egg=xblock-drag-and-drop-v2==2.2.6 -git+https://github.com/open-craft/xblock-poll@add89e14558c30f3c8dc7431e5cd6536fff6d941#egg=xblock-poll==1.5.1 +git+https://github.com/open-craft/xblock-poll@6894592402fd180db864bfce539f17bac6443866#egg=xblock-poll==1.9.0 xblock-utils==1.2.2 xblock==1.2.9 xmlsec==1.3.3 # via python3-saml diff --git a/requirements/edx/development.txt b/requirements/edx/development.txt index a21ac12c02376c013cdcb21dc3225d8cfaa7b015..0c9b13056105d60e011a37db91266c504e2d11c6 100644 --- a/requirements/edx/development.txt +++ b/requirements/edx/development.txt @@ -344,7 +344,7 @@ websocket-client==0.56.0 werkzeug==0.16.0 wrapt==1.10.5 git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.2.6#egg=xblock-drag-and-drop-v2==2.2.6 -git+https://github.com/open-craft/xblock-poll@add89e14558c30f3c8dc7431e5cd6536fff6d941#egg=xblock-poll==1.5.1 +git+https://github.com/open-craft/xblock-poll@6894592402fd180db864bfce539f17bac6443866#egg=xblock-poll==1.9.0 xblock-utils==1.2.2 xblock==1.2.9 xmlsec==1.3.3 diff --git a/requirements/edx/github.in b/requirements/edx/github.in index b4f485fba72708e1802eaf724c6b492867636c14..aeaa957d2ec4f605027842aef68c4c66b2e1d994 100644 --- a/requirements/edx/github.in +++ b/requirements/edx/github.in @@ -92,5 +92,5 @@ git+https://github.com/edx/xblock-lti-consumer.git@v1.2.1#egg=lti_consumer-xbloc # Third Party XBlocks git+https://github.com/joestump/python-oauth2.git@b94f69b1ad195513547924e380d9265133e995fa#egg=oauth2 -git+https://github.com/open-craft/xblock-poll@add89e14558c30f3c8dc7431e5cd6536fff6d941#egg=xblock-poll==1.5.1 +git+https://github.com/open-craft/xblock-poll@6894592402fd180db864bfce539f17bac6443866#egg=xblock-poll==1.9.0 git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.2.6#egg=xblock-drag-and-drop-v2==2.2.6 diff --git a/requirements/edx/testing.txt b/requirements/edx/testing.txt index 361eb7957bf59f2a28d7a47d68762f9eae7b0e3c..5c86a046f5bcb7125a6771ef9f5449fd31199aa2 100644 --- a/requirements/edx/testing.txt +++ b/requirements/edx/testing.txt @@ -326,7 +326,7 @@ websocket-client==0.56.0 # via docker werkzeug==0.16.0 # via moto wrapt==1.10.5 git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.2.6#egg=xblock-drag-and-drop-v2==2.2.6 -git+https://github.com/open-craft/xblock-poll@add89e14558c30f3c8dc7431e5cd6536fff6d941#egg=xblock-poll==1.5.1 +git+https://github.com/open-craft/xblock-poll@6894592402fd180db864bfce539f17bac6443866#egg=xblock-poll==1.9.0 xblock-utils==1.2.2 xblock==1.2.9 xmlsec==1.3.3