From 1251003d1009fb3c9676c450e84b1022c1adfca0 Mon Sep 17 00:00:00 2001 From: Sarina Canelake <sarina@mitx.mit.edu> Date: Tue, 1 Oct 2013 18:12:15 -0400 Subject: [PATCH] Remove enrollment from Student Admin page of new instructor dash --- CHANGELOG.rst | 3 ++ .../instructor/views/instructor_dashboard.py | 1 - .../instructor_dashboard/student_admin.coffee | 29 ------------------- .../instructor_dashboard_2/student_admin.html | 9 ------ 4 files changed, 3 insertions(+), 39 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index bd28c47a741..d9c2a1e051c 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -14,6 +14,9 @@ editing capability for a course's list of tabs. Studio and LMS: add ability to lock assets (cannot be viewed unless registered for class). +LMS: First round of improvements to New (beta) Instructor Dash: +improvements, fixes, and internationalization to the Student Info section. + LMS: Improved accessibility of parts of forum navigation sidebar. LMS: enhanced accessibility labeling and aria support for the discussion forum new post dropdown as well as response and comment area labeling. diff --git a/lms/djangoapps/instructor/views/instructor_dashboard.py b/lms/djangoapps/instructor/views/instructor_dashboard.py index e248d47a593..9736a3d8a21 100644 --- a/lms/djangoapps/instructor/views/instructor_dashboard.py +++ b/lms/djangoapps/instructor/views/instructor_dashboard.py @@ -121,7 +121,6 @@ def _section_student_admin(course_id, access): 'section_display_name': _('Student Admin'), 'access': access, 'get_student_progress_url_url': reverse('get_student_progress_url', kwargs={'course_id': course_id}), - 'enrollment_url': reverse('students_update_enrollment', kwargs={'course_id': course_id}), 'reset_student_attempts_url': reverse('reset_student_attempts', kwargs={'course_id': course_id}), 'rescore_problem_url': reverse('rescore_problem', kwargs={'course_id': course_id}), 'list_instructor_tasks_url': reverse('list_instructor_tasks', kwargs={'course_id': course_id}), diff --git a/lms/static/coffee/src/instructor_dashboard/student_admin.coffee b/lms/static/coffee/src/instructor_dashboard/student_admin.coffee index 6b4ed7f71cd..3ae99a9edc1 100644 --- a/lms/static/coffee/src/instructor_dashboard/student_admin.coffee +++ b/lms/static/coffee/src/instructor_dashboard/student_admin.coffee @@ -79,8 +79,6 @@ class StudentAdmin @$progress_link = find_and_assert @$section, "a.progress-link" @$field_problem_select_single = find_and_assert @$section, "input[name='problem-select-single']" @$btn_reset_attempts_single = find_and_assert @$section, "input[name='reset-attempts-single']" - @$btn_enroll = @$section.find "input[name='enroll']" - @$btn_unenroll = @$section.find "input[name='unenroll']" @$btn_delete_state_single = @$section.find "input[name='delete-state-single']" @$btn_rescore_problem_single = @$section.find "input[name='rescore-problem-single']" @$btn_task_history_single = @$section.find "input[name='task-history-single']" @@ -127,33 +125,6 @@ class StudentAdmin window.location = data.progress_url error: std_ajax_err => @$request_response_error_progress.text full_error_message - # enroll student - @$btn_enroll.click => - send_data = - action: 'enroll' - emails: @$field_student_select_progress.val() - auto_enroll: false - - $.ajax - dataType: 'json' - url: @$btn_enroll.data 'endpoint' - data: send_data - success: @clear_errors_then -> console.log "student #{send_data.emails} enrolled" - error: std_ajax_err => @$request_response_error_progress.text gettext("Error enrolling student '#{send_data.emails}'.") - - # unenroll student - @$btn_unenroll.click => - send_data = - action: 'unenroll' - emails: @$field_student_select_progress.val() - - $.ajax - dataType: 'json' - url: @$btn_unenroll.data 'endpoint' - data: send_data - success: @clear_errors_then -> console.log "student #{send_data.emails} unenrolled" - error: std_ajax_err => @$request_response_error_progress.text gettext("Error unenrolling student '#{send_data.emails}'.") - # reset attempts for student on problem @$btn_reset_attempts_single.click => unique_student_identifier = @$field_student_select_grade.val() diff --git a/lms/templates/instructor/instructor_dashboard_2/student_admin.html b/lms/templates/instructor/instructor_dashboard_2/student_admin.html index d8c55ec2ef2..b21942bd233 100644 --- a/lms/templates/instructor/instructor_dashboard_2/student_admin.html +++ b/lms/templates/instructor/instructor_dashboard_2/student_admin.html @@ -18,15 +18,6 @@ <a href="" class="progress-link" data-endpoint="${ section_data['get_student_progress_url_url'] }"> ${_("Student Progress Page")} </a> </p> </div> - <br> - - <!-- These buttons don't appear to be working - <p> - ${_("Click to enroll or unenroll this student from the course:")} - <input type="button" name="enroll" value="${_("Enroll")}" data-endpoint="${ section_data['enrollment_url'] }"> - <input type="button" name="unenroll" value="${_("Unenroll")}" data-endpoint="${ section_data['enrollment_url'] }"> - </p> - --> <hr> </div> -- GitLab