diff --git a/openedx/core/lib/request_utils.py b/openedx/core/lib/request_utils.py index 660584b5f2f43fdeeeb704af4f949d273c7691f8..2dbc9151ffe853c00f06372a524e111084d5d173 100644 --- a/openedx/core/lib/request_utils.py +++ b/openedx/core/lib/request_utils.py @@ -152,11 +152,8 @@ class CookieMonitoringMiddleware(MiddlewareMixin): max_group_cookie_name = max_cookie_name max_group_cookie_size = max_cookie_size - for name, size in cookie_names_to_size.items(): - attribute_name = 'cookies.{}.size'.format(name) - set_custom_attribute(attribute_name, size) - log.debug(u'%s = %d', attribute_name, size) - + # Only log the groups because adding an arbitrary number of individual cookies pushes too many + # metrics into NR and results in other metrics getting dropped potentially. for name, size in cookie_groups_to_size.items(): attribute_name = 'cookies.{}.group.size'.format(name) set_custom_attribute(attribute_name, size) diff --git a/openedx/core/lib/tests/test_request_utils.py b/openedx/core/lib/tests/test_request_utils.py index d79f8aa174e18627c3a2ccef236ce8960d3daa04..e3b63bf9f356ee76be5bbac1aabc44dbb8c5c409 100644 --- a/openedx/core/lib/tests/test_request_utils.py +++ b/openedx/core/lib/tests/test_request_utils.py @@ -114,14 +114,6 @@ class RequestUtilTestCase(unittest.TestCase): middleware.process_request(mock_request) mock_set_custom_attribute.assert_has_calls([ - call('cookies.a.size', 100), - call('cookies._b.size', 13), - call('cookies._c_.size', 13), - call('cookies.a.b.size', 10), - call('cookies.a.c.size', 10), - call('cookies.b..size', 13), - call('cookies.b_a.size', 15), - call('cookies.b_c.size', 15), call('cookies.a.group.size', 20), call('cookies.b.group.size', 43), call('cookies.max.name', 'a'), @@ -149,9 +141,6 @@ class RequestUtilTestCase(unittest.TestCase): middleware.process_request(mock_request) mock_set_custom_attribute.assert_has_calls([ - call('cookies.a.size', 10), - call('cookies.b_a.size', 15), - call('cookies.b_c.size', 20), call('cookies.b.group.size', 35), call('cookies.max.name', 'b_c'), call('cookies.max.size', 20),