From 2ef42cbc51f8c006238a86022928500717da1ed6 Mon Sep 17 00:00:00 2001
From: Ahsan Ulhaq <ahsan.haq@arbisoft.com>
Date: Wed, 5 Oct 2016 15:57:43 +0500
Subject: [PATCH] User Menu Added Role information missing from menu items
---
lms/djangoapps/courseware/tests/test_masquerade.py | 4 +++-
lms/templates/user_dropdown.html | 6 +++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lms/djangoapps/courseware/tests/test_masquerade.py b/lms/djangoapps/courseware/tests/test_masquerade.py
index ba36397c00e..a441d5667f9 100644
--- a/lms/djangoapps/courseware/tests/test_masquerade.py
+++ b/lms/djangoapps/courseware/tests/test_masquerade.py
@@ -156,7 +156,9 @@ class MasqueradeTestCase(SharedModuleStoreTestCase, LoginEnrollmentTestCase):
"""
content = self.get_courseware_page().content
self.assertIn(
- '<a href="/u/{}" class="action dropdown-menuitem">Profile</a>'.format(self.test_user.username),
+ '<a href="/u/{}" role="menuitem" class="action dropdown-menuitem">Profile</a>'.format(
+ self.test_user.username
+ ),
content,
"Profile link should point to real user",
)
diff --git a/lms/templates/user_dropdown.html b/lms/templates/user_dropdown.html
index 7dd31d25855..eb66f4fc911 100644
--- a/lms/templates/user_dropdown.html
+++ b/lms/templates/user_dropdown.html
@@ -32,9 +32,9 @@ from openedx.core.djangoapps.user_api.accounts.image_helpers import get_profile_
</button>
<ul class="dropdown-menu list-divided is-hidden" id="${_("Usermenu")}" tabindex="-1">
<%block name="navigation_dropdown_menu_links" >
- <li class="dropdown-item item has-block-link"><a href="${reverse('dashboard')}" class="action dropdown-menuitem">${_("Dashboard")}</a></li>
- <li class="dropdown-item item has-block-link"><a href="${reverse('learner_profile', kwargs={'username': self.real_user.username})}" class="action dropdown-menuitem">${_("Profile")}</a></li>
- <li class="dropdown-item item has-block-link"><a href="${reverse('account_settings')}" class="action dropdown-menuitem">${_("Account")}</a></li>
+ <li class="dropdown-item item has-block-link"><a href="${reverse('dashboard')}" role="menuitem" class="action dropdown-menuitem">${_("Dashboard")}</a></li>
+ <li class="dropdown-item item has-block-link"><a href="${reverse('learner_profile', kwargs={'username': self.real_user.username})}" role="menuitem" class="action dropdown-menuitem">${_("Profile")}</a></li>
+ <li class="dropdown-item item has-block-link"><a href="${reverse('account_settings')}" role="menuitem" class="action dropdown-menuitem">${_("Account")}</a></li>
</%block>
<li class="dropdown-item item has-block-link"><a href="${reverse('logout')}" role="menuitem" class="action dropdown-menuitem">${_("Sign Out")}</a></li>
</ul>
--
GitLab