diff --git a/AUTHORS b/AUTHORS index 7ad3693b78db6d900fbefaf112889b7eb9aeb118..19607b1251742a97f7018a34aad2effc86905114 100644 --- a/AUTHORS +++ b/AUTHORS @@ -105,4 +105,4 @@ Yihua Lou <supermouselyh@hotmail.com> Andy Armstrong <andya@edx.org> Matt Drayer <mattdrayer@edx.org> Cristian Salamea <cristian.salamea@iaen.edu.ec> - +Graham Lowe <graham.lowe@gmail.com> diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 46808ab4bb2c65679643043cf8d0b5ff6f3e26ff..8f5c97a2297c33a1c62271d086fee207d1658fa5 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -186,7 +186,7 @@ By opening up a pull request, we expect the following things: unable to participate in the review process. 3. If you have questions, you will ask them by either commenting on the pull - request or asking us in IRC or on the mailing list. + request or asking us in IRC or on the mailing list. 4. If you do not respond to comments on your pull request within 7 days, we will close it. You are welcome to re-open it when you are ready to engage. @@ -239,7 +239,7 @@ generated. Click on the "View Reports" link on your pull request to be brought to the Jenkins report page. In a column on the left side of the page are a few links, including "Diff Coverage Report" and "Diff Quality Report". View each of these reports (making note that the Diff Quality report has two tabs - one for -pep8, and one for Pylint). +pep8, and one for Pylint). Make sure your quality coverage is 100% and your test coverage is at least 95%. Adjust your code appropriately if these metrics are not high enough. Be sure to @@ -307,7 +307,7 @@ commits, and comments. .. _individual contributor agreement: http://code.edx.org/individual-contributor-agreement.pdf -.. _edx-platform testing documentation: https://github.com/edx/edx-platform/blob/master/docs/internal/testing.md +.. _edx-platform testing documentation: https://github.com/edx/edx-platform/blob/master/docs/en_us/internal/testing.md .. _mailing list: https://groups.google.com/forum/#!forum/edx-code .. _IRC channel: http://www.irchelp.org/irchelp/new2irc.html .. _pull request 1322: https://github.com/edx/edx-platform/pull/1322