From 4390773f4b4e34b4e14b8b27be98a9d6b12f4842 Mon Sep 17 00:00:00 2001
From: bmedx <bmesick@edx.org>
Date: Thu, 19 Apr 2018 15:04:39 -0400
Subject: [PATCH] Clean up some warnings to get enough headroom to pass tests
---
common/djangoapps/student/models.py | 8 ++++----
lms/djangoapps/email_marketing/signals.py | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/common/djangoapps/student/models.py b/common/djangoapps/student/models.py
index f6f757a72cd..77bcd5abd1f 100644
--- a/common/djangoapps/student/models.py
+++ b/common/djangoapps/student/models.py
@@ -145,7 +145,7 @@ def anonymous_id_for_user(user, course_id, save=True):
# This part is for ability to get xblock instance in xblock_noauth handlers, where user is unauthenticated.
assert user
- if user.is_anonymous():
+ if user.is_anonymous:
return None
cached_id = getattr(user, '_anonymous_id', {}).get(course_id)
@@ -1226,7 +1226,7 @@ class CourseEnrollment(models.Model):
"""
assert user
- if user.is_anonymous():
+ if user.is_anonymous:
return None
try:
return cls.objects.get(
@@ -1643,7 +1643,7 @@ class CourseEnrollment(models.Model):
"""
assert user
- if user.is_anonymous():
+ if user.is_anonymous:
return None
cache_key = cls.enrollment_status_hash_cache_key(user)
@@ -1966,7 +1966,7 @@ class CourseEnrollment(models.Model):
"""
assert user
- if user.is_anonymous():
+ if user.is_anonymous:
return CourseEnrollmentState(None, None)
enrollment_state = cls._get_enrollment_in_request_cache(user, course_key)
if not enrollment_state:
diff --git a/lms/djangoapps/email_marketing/signals.py b/lms/djangoapps/email_marketing/signals.py
index 3d8720e1997..d8b5e297a7a 100644
--- a/lms/djangoapps/email_marketing/signals.py
+++ b/lms/djangoapps/email_marketing/signals.py
@@ -139,7 +139,7 @@ def email_marketing_register_user(sender, user, registration,
return
# ignore anonymous users
- if user.is_anonymous():
+ if user.is_anonymous:
return
# perform update asynchronously
@@ -165,7 +165,7 @@ def email_marketing_user_field_changed(sender, user=None, table=None, setting=No
"""
# ignore anonymous users
- if user.is_anonymous():
+ if user.is_anonymous:
return
# ignore anything but User, Profile or UserPreference tables
--
GitLab