From 8219ddc40a41a0bb7d4ec8718deafc2925408294 Mon Sep 17 00:00:00 2001
From: Nathan Sprenkle <nsprenkle@users.noreply.github.com>
Date: Tue, 17 Mar 2020 11:16:24 -0400
Subject: [PATCH] Fix A11y issues on Team Management tab (#23403)
* Change upload div to a button for focus styling
* Fix team membership button resize on focus
* Remove box shadow from focus styling
---
lms/djangoapps/teams/static/teams/templates/manage.underscore | 4 ++--
lms/static/sass/views/_teams.scss | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lms/djangoapps/teams/static/teams/templates/manage.underscore b/lms/djangoapps/teams/static/teams/templates/manage.underscore
index 460769a1cb9..8dd1b32dd18 100644
--- a/lms/djangoapps/teams/static/teams/templates/manage.underscore
+++ b/lms/djangoapps/teams/static/teams/templates/manage.underscore
@@ -27,7 +27,7 @@
"users to teams."
) %>
</p>
- <div class="upload-team-csv btn action action-primary">
+ <button class="upload-team-csv btn action action-primary">
<input
id="upload-team-csv-input"
type="file"
@@ -35,7 +35,7 @@
class="input-overlay-hack"
/>
<%- gettext("Upload Memberships") %>
- </div>
+ </button>
<!-- We need to describe the format of the CSV here (TODO MST-49) -->
<div class="page-banner" hidden>
<div class="alert alert-danger" role="alert">
diff --git a/lms/static/sass/views/_teams.scss b/lms/static/sass/views/_teams.scss
index 3d13841df84..7526e8ee251 100644
--- a/lms/static/sass/views/_teams.scss
+++ b/lms/static/sass/views/_teams.scss
@@ -550,6 +550,10 @@
.action-primary {
@extend %btn-primary-blue;
+ &:focus {
+ border: inherit;
+ box-shadow: none;
+ }
display: inline-block;
text-shadow: none;
}
--
GitLab