From 8ad4cdb3660d2c72f47056615b3eedc7c222e49a Mon Sep 17 00:00:00 2001
From: Adam Palay <adam@edx.org>
Date: Mon, 28 Apr 2014 10:32:18 -0400
Subject: [PATCH] factor out google analytics ids (LMS-2555)
---
.../linkedin/management/commands/linkedin_mailusers.py | 6 +++++-
lms/envs/aws.py | 4 ++++
lms/envs/common.py | 4 ++++
lms/templates/google_analytics.html | 2 +-
lms/templates/linkedin/linkedin_email.html | 2 +-
5 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/lms/djangoapps/linkedin/management/commands/linkedin_mailusers.py b/lms/djangoapps/linkedin/management/commands/linkedin_mailusers.py
index ae1e553e696..afd81f08d02 100644
--- a/lms/djangoapps/linkedin/management/commands/linkedin_mailusers.py
+++ b/lms/djangoapps/linkedin/management/commands/linkedin_mailusers.py
@@ -205,7 +205,11 @@ class Command(BaseCommand):
'linkedin_add_url': self.certificate_url(cert),
})
- context = {'courses_list': courses_list, 'num_courses': len(courses_list)}
+ context = {
+ 'courses_list': courses_list,
+ 'num_courses': len(courses_list),
+ 'google_analytics': settings.GOOGLE_ANALYTICS_LINKEDIN,
+ }
body = render_to_string('linkedin/linkedin_email.html', context)
subject = u'{}, Add your Achievements to your LinkedIn Profile'.format(user.profile.name)
if mock_run:
diff --git a/lms/envs/aws.py b/lms/envs/aws.py
index 45932693147..83c659bdd3a 100644
--- a/lms/envs/aws.py
+++ b/lms/envs/aws.py
@@ -397,3 +397,7 @@ THIRD_PARTY_AUTH = AUTH_TOKENS.get('THIRD_PARTY_AUTH', THIRD_PARTY_AUTH)
##### ADVANCED_SECURITY_CONFIG #####
ADVANCED_SECURITY_CONFIG = ENV_TOKENS.get('ADVANCED_SECURITY_CONFIG', {})
+
+##### GOOGLE ANALYTICS IDS #####
+GOOGLE_ANALYTICS_ACCOUNT = AUTH_TOKENS.get('GOOGLE_ANALYTICS_ACCOUNT')
+GOOGLE_ANALYTICS_LINKEDIN = AUTH_TOKENS.get('GOOGLE_ANALYTICS_LINKEDIN')
diff --git a/lms/envs/common.py b/lms/envs/common.py
index 6d8862568c4..03685226545 100644
--- a/lms/envs/common.py
+++ b/lms/envs/common.py
@@ -421,6 +421,10 @@ if FEATURES.get('ENABLE_SQL_TRACKING_LOGS'):
TRACKING_IGNORE_URL_PATTERNS = [r'^/event', r'^/login', r'^/heartbeat']
TRACKING_ENABLED = True
+######################## GOOGLE ANALYTICS ###########################
+GOOGLE_ANALYTICS_ACCOUNT = 'GOOGLE_ANALYTICS_ACCOUNT_DUMMY'
+GOOGLE_ANALYTICS_LINKEDIN = 'GOOGLE_ANALYTICS_LINKEDIN_DUMMY'
+
######################## subdomain specific settings ###########################
COURSE_LISTINGS = {}
SUBDOMAIN_BRANDING = {}
diff --git a/lms/templates/google_analytics.html b/lms/templates/google_analytics.html
index 273fbac970b..a19cfcdffb6 100644
--- a/lms/templates/google_analytics.html
+++ b/lms/templates/google_analytics.html
@@ -1,6 +1,6 @@
<script type="text/javascript">
var _gaq = _gaq || [];
-_gaq.push(['_setAccount', 'UA-35248639-1']);
+_gaq.push(['_setAccount', ${settings.GOOGLE_ANALYTICS_ACCOUNT}]);
_gaq.push(['_trackPageview']);
(function() {
diff --git a/lms/templates/linkedin/linkedin_email.html b/lms/templates/linkedin/linkedin_email.html
index 7b2427e5f55..bffbad7c4c9 100644
--- a/lms/templates/linkedin/linkedin_email.html
+++ b/lms/templates/linkedin/linkedin_email.html
@@ -393,7 +393,7 @@
<script type="text/javascript">
try {
var _gaq = _gaq || [];
- _gaq.push(["_setAccount", "UA-329148-88"]);
+ _gaq.push(["_setAccount", ${google_analytics}]);
_gaq.push(["_setDomainName", ".campaign-archive.com"]);
_gaq.push(["_trackPageview"]);
_gaq.push(["_setAllowLinker", true]);
--
GitLab