From bfee237a0d96e1771851eb7a1e8bd6a61979a794 Mon Sep 17 00:00:00 2001 From: Renzo Lucioni <renzolucioni@gmail.com> Date: Mon, 5 May 2014 17:18:22 -0400 Subject: [PATCH] Add ability to deactivate GA snippet --- lms/envs/common.py | 2 +- lms/templates/google_analytics.html | 22 ++++++++++++---------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/lms/envs/common.py b/lms/envs/common.py index 6287bfb5aa7..1dc963fd9b1 100644 --- a/lms/envs/common.py +++ b/lms/envs/common.py @@ -445,7 +445,7 @@ if FEATURES.get('ENABLE_SQL_TRACKING_LOGS'): }) ######################## GOOGLE ANALYTICS ########################### -GOOGLE_ANALYTICS_ACCOUNT = 'GOOGLE_ANALYTICS_ACCOUNT_DUMMY' +GOOGLE_ANALYTICS_ACCOUNT = None GOOGLE_ANALYTICS_LINKEDIN = 'GOOGLE_ANALYTICS_LINKEDIN_DUMMY' ######################## subdomain specific settings ########################### diff --git a/lms/templates/google_analytics.html b/lms/templates/google_analytics.html index 966cc934d82..44ef9e76d63 100644 --- a/lms/templates/google_analytics.html +++ b/lms/templates/google_analytics.html @@ -1,11 +1,13 @@ -<script type="text/javascript"> -var _gaq = _gaq || []; -_gaq.push(['_setAccount', '${settings.GOOGLE_ANALYTICS_ACCOUNT}']); -_gaq.push(['_trackPageview']); +% if settings.GOOGLE_ANALYTICS_ACCOUNT: + <script type="text/javascript"> + var _gaq = _gaq || []; + _gaq.push(['_setAccount', '${settings.GOOGLE_ANALYTICS_ACCOUNT}']); + _gaq.push(['_trackPageview']); -(function() { - var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true; - ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js'; - var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s); -})(); -</script> + (function() { + var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true; + ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js'; + var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s); + })(); + </script> +% endif -- GitLab