diff --git a/lms/static/js/dashboard/legacy.js b/lms/static/js/dashboard/legacy.js index 0b48918d23c4506e8dcce5ef9b14cf3c8120cd31..be8df1fc5463b41416a1a210569a92e1732e1017 100644 --- a/lms/static/js/dashboard/legacy.js +++ b/lms/static/js/dashboard/legacy.js @@ -188,7 +188,6 @@ $('#unenroll_form input[type="submit"]').prop('disabled', true); }); - edx.dashboard.dropdown.toggleCourseActionsDropdownMenu(event); $('#unenroll-modal').css('position', 'fixed'); }); diff --git a/lms/static/js/learner_dashboard/views/entitlement_unenrollment_view.js b/lms/static/js/learner_dashboard/views/entitlement_unenrollment_view.js index 00387be2049780e582050122b11b5d27ecbc3ba7..840dc09f1c345c3a3c5697ff6860919f0017bbfa 100644 --- a/lms/static/js/learner_dashboard/views/entitlement_unenrollment_view.js +++ b/lms/static/js/learner_dashboard/views/entitlement_unenrollment_view.js @@ -52,11 +52,7 @@ this.resetModal(); this.setHeaderText(courseName, courseNumber); this.setSubmitData(apiEndpoint); - - if (window.edx && window.edx.dashboard && window.edx.dashboard.dropdown) { - window.edx.dashboard.dropdown.toggleCourseActionsDropdownMenu(event); - this.$el.css('position', 'fixed'); - } + this.$el.css('position', 'fixed'); }, handleSubmit: function() { diff --git a/lms/static/js/toggle_login_modal.js b/lms/static/js/toggle_login_modal.js index bb38c526399316c8c86f7a685638aba5a1990350..4c2f9a424e45e300f58012c2274f751d3ed145f9 100644 --- a/lms/static/js/toggle_login_modal.js +++ b/lms/static/js/toggle_login_modal.js @@ -86,14 +86,6 @@ $(modal_id).show().fadeTo(200, 1); $(modal_id).find('.notice').hide().html(''); - var notice = $(this).data('notice'); - if (notice !== undefined) { - $notice = $(modal_id).find('.notice'); - $notice.show().html(notice); - // This is for activating leanModal links that were in the notice. We should have a cleaner way of - // allowing all dynamically added leanmodal links to work. - $notice.find('a[rel*=leanModal]').leanModal({top: 120, overlay: 1, closeButton: '.close-modal', position: 'absolute'}); - } window.scrollTo(0, 0); e.preventDefault(); }); diff --git a/lms/templates/dashboard.html b/lms/templates/dashboard.html index a9d179f5e825cddaf00f9e14799785a967a8bfac..8278b67b23ac6833dea664d700000c3fd9f3acf6 100644 --- a/lms/templates/dashboard.html +++ b/lms/templates/dashboard.html @@ -61,9 +61,13 @@ from student.models import CourseEnrollment }); </%static:require_module> <%static:require_module module_name="js/learner_dashboard/entitlement_unenrollment_factory" class_name="EntitlementUnenrollmentFactory"> - EntitlementUnenrollmentFactory({ - dashboardPath: "${reverse('dashboard') | n, js_escaped_string}", - signInPath: "${reverse('signin_user') | n, js_escaped_string}" + ## Wait until the document is fully loaded before initializing the EntitlementUnenrollmentView + ## to ensure events are setup correctly. + $(document).ready(function() { + EntitlementUnenrollmentFactory({ + dashboardPath: "${reverse('dashboard') | n, js_escaped_string}", + signInPath: "${reverse('signin_user') | n, js_escaped_string}" + }); }); </%static:require_module> % if settings.FEATURES.get('ENABLE_DASHBOARD_SEARCH'): diff --git a/themes/edx.org/lms/templates/dashboard.html b/themes/edx.org/lms/templates/dashboard.html index b93f1d0b3f8fd0edac0257844155a1ecab0b1bcc..9be741c45ea68a1027492b67f833b1c12ceab6b9 100644 --- a/themes/edx.org/lms/templates/dashboard.html +++ b/themes/edx.org/lms/templates/dashboard.html @@ -63,9 +63,13 @@ from student.models import CourseEnrollment }); </%static:require_module> <%static:require_module module_name="js/learner_dashboard/entitlement_unenrollment_factory" class_name="EntitlementUnenrollmentFactory"> - EntitlementUnenrollmentFactory({ - dashboardPath: "${reverse('dashboard') | n, js_escaped_string}", - signInPath: "${reverse('signin_user') | n, js_escaped_string}" + ## Wait until the document is fully loaded before initializing the EntitlementUnenrollmentView + ## to ensure events are setup correctly. + $(document).ready(function() { + EntitlementUnenrollmentFactory({ + dashboardPath: "${reverse('dashboard') | n, js_escaped_string}", + signInPath: "${reverse('signin_user') | n, js_escaped_string}" + }); }); </%static:require_module> % if settings.FEATURES.get('ENABLE_DASHBOARD_SEARCH'):