-
We decided (after lively discussion--haha) in our meeting on 7/10/18 that we would only manipulate
aria-hidden
onnav[aria-label="Page Context"]
,main
, andfooter
. Everything else is going to be in the accessibility tree (and thus accessible to the screen reader virtual cursor/buffer) all the time. However, when a drawer is open, focus will be trapped and cycled in the container for the drawer and its triggering button (in the case of the menu,nav[aria-label=”Site”]
or, in the case of the search,div[role=”search”]
. Although we discussed the possibility of additionally watching for focus events outside of these containers that would trigger the closing of any open drawers, we decided it wasn't worth the added complexity at this time. This is because it is probably only relevant in an edge case involving screen reader users who have navigated outside of the drawer container with the virtual cursor or using other browse mode commands. This doesn't mean that we will not revisit if future testing or user complaints reveal this to be an problem. In this instance, any changes that may need to take place after rollout should not be disruptive to those who have already adopted the theme. -
Changed the
type
of the<input>
field fromsearch
totext
, after reading of how difficult it is to control the style of fields whose type is set to search in webkit browsers. Until I've had more time to suss out the implications, better to play it safe. -
Changed reference to "menu" to "drawers" in comment.
-
Fixed the submit button in the search form.
-
Change
role="none"
torole="presentation"
, since they are, essentially, the same, and the presentation role is better supported. -
Changed
aria-labelledby="Current section of site"
toaria-label="Current section of site"
.aria-labelledby
should point to an IDREF, so I'm not sure how that even got in there. -
Removed the second Actions and Audiences groups so it is clearer that they should be moved rather than duplicated.
-
Updated recommendations regarding use of
aria-current
. -
Forgot to close an
<li>
tag on the "Explore this section" widget. -
Made
<header role="banner">
the parent of the logo link, the menu<nav>
and the search region. -
Changed from
<input type="submit" value="Submit">
to<button type="submit">Submit</button>
to better match what is currently on site.
Please register or sign in to comment