From 9454b9393b4335c3a569c939598dd6cb50f18ad2 Mon Sep 17 00:00:00 2001
From: Kristof De Langhe <kristof.delanghe@atmire.com>
Date: Tue, 20 Mar 2018 15:54:11 +0100
Subject: [PATCH] 50479: angularticsMock + tslint fixes
---
src/app/app.component.spec.ts | 3 +++
src/app/shared/mocks/mock-angulartics.service.ts | 4 ++++
src/main.browser.ts | 2 +-
src/modules/app/server-app.module.ts | 4 ----
4 files changed, 8 insertions(+), 5 deletions(-)
create mode 100644 src/app/shared/mocks/mock-angulartics.service.ts
diff --git a/src/app/app.component.spec.ts b/src/app/app.component.spec.ts
index 5c77b34549..ba434279dc 100644
--- a/src/app/app.component.spec.ts
+++ b/src/app/app.component.spec.ts
@@ -30,6 +30,8 @@ import { NativeWindowRef, NativeWindowService } from './shared/window.service';
import { MockTranslateLoader } from './shared/mocks/mock-translate-loader';
import { MockMetadataService } from './shared/mocks/mock-metadata-service';
+import { Angulartics2GoogleAnalytics } from 'angulartics2/ga';
+import { AngularticsMock } from './shared/mocks/mock-angulartics.service';
let comp: AppComponent;
let fixture: ComponentFixture<AppComponent>;
@@ -56,6 +58,7 @@ describe('App component', () => {
{ provide: GLOBAL_CONFIG, useValue: ENV_CONFIG },
{ provide: NativeWindowService, useValue: new NativeWindowRef() },
{ provide: MetadataService, useValue: new MockMetadataService() },
+ { provide: Angulartics2GoogleAnalytics, useValue: new AngularticsMock() }
AppComponent
],
schemas: [CUSTOM_ELEMENTS_SCHEMA]
diff --git a/src/app/shared/mocks/mock-angulartics.service.ts b/src/app/shared/mocks/mock-angulartics.service.ts
new file mode 100644
index 0000000000..99a8b96b22
--- /dev/null
+++ b/src/app/shared/mocks/mock-angulartics.service.ts
@@ -0,0 +1,4 @@
+/* tslint:disable:no-empty */
+export class AngularticsMock {
+ public eventTrack(action, properties) { }
+}
diff --git a/src/main.browser.ts b/src/main.browser.ts
index 388693ca06..174c35f02f 100644
--- a/src/main.browser.ts
+++ b/src/main.browser.ts
@@ -26,7 +26,7 @@ export function main() {
});
// Add google analytics key
- var script = document.createElement('script');
+ const script = document.createElement('script');
script.innerHTML = 'ga(\'create\', \'' + ENV_CONFIG.gaTrackingId + '\', \'auto\');';
document.body.appendChild(script);
diff --git a/src/modules/app/server-app.module.ts b/src/modules/app/server-app.module.ts
index 0e307667c8..3e37ded77e 100644
--- a/src/modules/app/server-app.module.ts
+++ b/src/modules/app/server-app.module.ts
@@ -22,10 +22,6 @@ export function createTranslateLoader() {
return new TranslateUniversalLoader('dist/assets/i18n/', '.json');
}
-class AngularticsMock {
- public eventTrack(action, properties) { }
-}
-
@NgModule({
bootstrap: [AppComponent],
imports: [
--
GitLab