Skip to content
Snippets Groups Projects
Commit d83dd120 authored by Keith Garner's avatar Keith Garner Committed by Cody Cutrer
Browse files

ignore null students when updating speedgrader select menu

For group assignments we might get back more submissions than we have
students loaded as only representative students are loaded for the
group. This resulted in a null student being passed to
updateSelectMenuStatus which errored out when asking the student for
its index. This patchset adds an early exit to updateSelectMenuStatus
in the case of a null student.

fixes GRADE-351

test plan:
 - Have a course with a teacher and some students
 - Create a group or two with multiple students in the groups
 - Create a group assignment
 - Go into speedgrader as a teacher
 - Grade the group assignment
 - Note that the status icon in the student menu reflects the graded
   status

Change-Id: Id1334311073633e8546a7de93feb5f55970ead63
Reviewed-on: https://gerrit.instructure.com/129442


Reviewed-by: default avatarDerek Bender <djbender@instructure.com>
Reviewed-by: default avatarSpencer Olson <solson@instructure.com>
Reviewed-by: default avatarJeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
parent 36b0a106
Branches
Tags release/2018-07-14.04
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment