Skip to content
Snippets Groups Projects
Select Git revision
  • stable default
  • master
  • beta
  • releases/2016-04
  • private
  • release/2018-10-27.03
  • release/2018-10-27.02
  • release/2018-10-06.18
  • release/2018-10-27.01
  • release/2018-10-06.17
  • release/2018-10-06.16
  • release/2018-10-06.15
  • release/2018-10-06.14
  • release/2018-10-06.13
  • release/2018-10-06.12
  • release/2018-10-06.11
  • release/2018-10-06.10
  • release/2018-10-06.09
  • release/2018-10-06.08
  • release/2018-09-15.37
  • release/2018-10-06.07
  • release/2018-09-15.36
  • release/2018-09-15.35
  • release/2018-10-06.06
  • release/2018-10-06.05
25 results
Search by author
  • Any Author
  • Ben Austin Ben Austin bennoxys
  • Bob Edmison Bob Edmison kedmison
  • David Van Scoik David Van Scoik davidv14
  • Ehsan Sami Ismaiel Ali Elgendi Ehsan Sami Ismaiel Ali Elgendi ehsan83
  • Griffin College Griffin College griffc1
  • Mohammad Shabbir Hasan Mohammad Shabbir Hasan shabbir5
  • Raghu Srinivasan Raghu Srinivasan raghu
  • Richard B Patten Richard B Patten richp
  • Vamsi Manne Vamsi Manne vmanne20
9 authors
  1. Oct 30, 2015
  3. Oct 27, 2015
    • Jeremy Stanley's avatar
      fix publishing newly created module items · 823b9f8c
      Jeremy Stanley authored 
      test plan:
 - create an item such as a wiki page via add-module-item
 - without reloading the modules page, click the publish cloud
   for the item
 - reload the page and confirm that the item is *really*
   published

fixes CNVS-24578

Change-Id: Iec359cf7654b9477377b4617fbfa763db8df3f29
Reviewed-on: https://gerrit.instructure.com/65891


Tested-by: Jenkins
Reviewed-by: default avatarJames Williams <jamesw@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
      2 tags
      823b9f8c
    • Ryan Shaw's avatar
      fix brand config previewing and skipping · 95375c30
      Ryan Shaw authored 
      the actual changes are in:
https://github.com/ryankshaw/brandable_css/compare/8cff7...master
make sure to review that too

first thing it fixes: 
better logic for knowing what to skip in brandable_css
closes: CNVS-24039

* gets rid of any manifest files on s3.
  The only manifest file that is used is the one
  on the local disk which only includes metadata
  about the "stock" (unbranded) css files which
  are generated as part of the tarball on the
  deployer's vm.
* which means we no longer use the env var:
  UNIQUE_KEY_FOR_BRANDABLE_CSS_MANIFEST

* because the filenames on s3 include:
  <css bundle name>
  <combined checksum of stock version of this file>,
  <md5 of this brand config>
  if that css file exists, we know we don't need
  to generate or upload that file again. and we
  don't need a shared manifest on s3 to figure that
  all out.

test plan:
* with a canvas_cdn.yml file configured
* run brandable_css
* run it again, it should be fast
* rm -rf public/d...
      95375c30
  5. Oct 23, 2015
    • Ryan Taylor's avatar
      Prevents in-request updating of all in progress QSes on Quiz#update · d0ce1a8b
      Ryan Taylor authored 
      Previously, when changing the quiz time limit, all in progress quiz
submission attempts were updated synchronously or the request would
fail.  In July, a class with ~5k students was updated repeatedly causing
6 minute transactions.  This sacrifices synchronous QS updates to make
sure our request completes.

Closes CNVS-22115

Test Plan:
  - Create quiz with time limit set to 10 minutes
  - Start quiz with student
  - Edit the quiz as the teacher and set time limit to 12 minutes
  - Make sure the student time adjusts
  - Edit the time limit to 4 minutes
  - Make sure the student time is changed (soonish, not immediately)

Change-Id: I931f3beb5bee3bb39c39a0f0353a4c0a9c678ed3
Reviewed-on: https://gerrit.instructure.com/64548


Tested-by: Jenkins
Reviewed-by: default avatarJohn Corrigan <jcorrigan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>
      3 tags
      d0ce1a8b
    • Nathan Mills's avatar
      handle missing assignment date values for variable subs · 67c66421
      Nathan Mills authored 
      fixes PLAT-1272

test plan:

use the $Canvas.assignment.(dueAt|lockAt|unlockAt).iso8601
varaible expansions

set up an assignment with blank values for all the dates

you should not get a 500 on an lti launch for the assignment

Change-Id: I7e4ffab74ea8b2aef6ba921c372ada9260805da0
Reviewed-on: https://gerrit.instructure.com/65354


Tested-by: Jenkins
Reviewed-by: default avatarBrad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
      67c66421
  7. Oct 22, 2015
  9. Oct 21, 2015
  11. Oct 20, 2015
  13. Oct 16, 2015
    • John Corrigan's avatar
      exportable considers sort setting; EpubExport hooked up to Exportable · 26b29a60
      John Corrigan authored 
      refs CNVS-21794
closes CNVS-21802

- Adds CC::Exporter::Epub::Exportable#sort_by_content_type?, which can
  be overridden by classes that `include` the module to point to where
  the setting can be found.
- Update CC::Exporter::Epub::Exportable#convert_to_epub to pass
  `sort_by_content_type?` to CC::Exporter::Epub::Exporter.new.
- Update EpubExport to include CC::Exporter::Epub::Exportable, and
  override / add to instance methods.

test plan:
- Navigate to `/epub_exports`.
- Observe a list of courses that are active & user is enrolled in.
- Click on the Generate button.
- Observe that info about the state of the export and the timestamp are
  added to the middle of the row.
- Observe that a progress bar is displayed while the export is in
  progress.
- Observe that upon completion, the progress bar is replaced by two
  button / links: Download & Regenerate.
- Click on the download link.
- Observe that an epub file is downloaded and can be opened in an
  eReader.
- Observe that the Regenerate button triggers the process all over
  again.

Change-Id: Ib42c2d2623c3ccd394105cdf0e3809b96c8a2e60
Reviewed-on: https://gerrit.instructure.com/63469


Reviewed-by: default avatarMatt Berns <mberns@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
      release/2015-10-31.08
      26b29a60
    • James Williams's avatar
      fix read grades permissions check on submissions show page · c9e984b4
      James Williams authored 
      test plan:
* add a student to peer review another student's submission
* they should not see that submission's grade

closes #CNVS-24078

Change-Id: If02eba2f93ff2e4d49b60180b5e736cb5b0e579a
Reviewed-on: https://gerrit.instructure.com/65267


Reviewed-by: default avatarEric Coan <ecoan@instructure.com>
Reviewed-by: default avatarEthan Vizitei <evizitei@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: default avatarRob Orton <rob@instructure.com>
      release/2015-10-31.07
      c9e984b4
  15. Oct 15, 2015
  17. Oct 14, 2015
  19. Oct 12, 2015
  21. Oct 11, 2015
  23. Oct 10, 2015
  25. Oct 09, 2015
    • Sterling Cobb's avatar
      only show speedgrader link for moderated students · 13c9bcf2
      Sterling Cobb authored 
        fixes CNVS-23900

  As a user moderating grades
  And I'm viewing the moderation page
  When I have not added anyone to the moderation set
  And a user does not have a grade
  Then I should not see the SpeedGrader link
  And I should just see a dash in that column

Change-Id: Ia9499cef3bcd12f3bd97e780dea9cd735078797d
Reviewed-on: https://gerrit.instructure.com/64887


Tested-by: Jenkins
Reviewed-by: default avatarClay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
      13c9bcf2
    • Spencer Olson's avatar
      final scores stay with students switching sections · 01aab7b6
      Spencer Olson authored 
      When a student is moved from one section to another
on the same course, their current score and final score
will follow them and their grades will show up correctly
on the account level Grade Export report.

closes CNVS-19777

test plan:

* Create a course with 2 sections and some published
  assignments.
* Add students to the first section of the course.
* Grade those students on the assignments.
* At the account level, run the Grade Export for the term
* Notice everything looks fine.
* Move a student to the second section in the course.
* Run the grade export again
* Notice the grades look the same on the new report
  (before this bugfix, the grades would be blank on
   this new report)

Change-Id: Ic9135a6bb5bd778221db344f1b36a41b65ff7093
Reviewed-on: https://gerrit.instructure.com/64876


Reviewed-by: default avatarStrand McCutchen <smccutchen@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
      01aab7b6
    • Davis McClellan's avatar
      ensures that no submitted files can be deleted · 55a0e5f9
      Davis McClellan authored 
      fixes CNVS-22117

test plan:
Prerequisites: A course that is not concluded in any way,
with a student enrolled and an online submission assignment
that is available for submission.
- As the student - submit a file for the assignment.
- Go to your personal files page (click on name or settings
  in the global nav - top right, then files)
- Try to delete the file you submitted
- Observe that you receive an "Unauthorized" message.
- As the teacher, view the student's submission in SpeedGrader
  and click on the download icon for the submitted file
- Should be able to download still

Change-Id: I313c5ba5504bc2bff81d42ee1c8593ced206b216
Reviewed-on: https://gerrit.instructure.com/63779


Reviewed-by: default avatarCameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
      55a0e5f9
    • John Corrigan's avatar
      changes based on epubcheck and iTMSTransporter validators · 1bcc7785
      John Corrigan authored 
      refs CNVS-20157

- Explicitly add media type when adding media to the ePub (gepub only
  tries to figure it out itself for images).
- Remove empty <a> ids added by tinymce.
- Add fallback text for <audio> & <video> tags for readers that don’t
  support media playback.
- Be more explicit about escaping / unescaping file paths.
- Use identifiers for url anchors. 

test plan:
- Test that epub generation works, nothing explicit beyond that.

Change-Id: I646866030420f570f7edbe7dd2ea87737e7129f6
Reviewed-on: https://gerrit.instructure.com/64039


Reviewed-by: default avatarMatt Berns <mberns@instructure.com>
Tested-by: Jenkins
Product-Review: John Corrigan <jcorrigan@instructure.com>
QA-Review: John Corrigan <jcorrigan@instructure.com>
      1bcc7785