- Jun 29, 2017
-
-
brian kirkby authored
fixes CNVS-37863 test plan: - edit a course syllabus - make sure the course syllabus is edited - go back in to re-edit the course syllabus - make sure tinymce is available and we can switch to HTML mode - rejoice! Change-Id: Ife3fd72d676f59819c00e24a577f503eea0b339b Reviewed-on: https://gerrit.instructure.com/117247 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Tested-by: Jenkins Product-Review: brian kirkby <bkirkby@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com>
-
Rob Orton authored
fixes CNVS-37866 test plan - specs should pass Change-Id: Id77fdbf89f71706586b786f09b13a16b695cfc07 Reviewed-on: https://gerrit.instructure.com/117306 Tested-by: Jenkins QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Rob Orton <rob@instructure.com> Reviewed-by: Neil Gupta <ngupta@instructure.com>
-
Brent Burgoyne authored
the new version of the rce and skin no longer incorrectly display the font size of text in tables. many of the canvas style overrides have also been moved to the skin and are no longer needed in canvas. the initial push of this fix broke several rcs selenium tests due to a circular destroy chain. https://gerrit.instructure.com/#/c/116660/ fixes that and has been published to npm as v2.2.0-alpha.1. we should test this patchset against that npm version fixes CNVS-37517 test plan: - run yarn install first to get new dependency versions. canvas-lms should be version 2.2.0-alpha.1 - test rcs and legacy editors - insert a table, type in a cell, text should be same size as outside the table (shows as 11pt in toobar) - test the toolbar nav with and without high contrast (alt+f10) - toolbar styles should match colors and have a triangle under for active state, and a border for focus state, and both when focusing on an active button - create a discussion thread - add a reply to the discussion thread - edit the reply to the discussion thread - verify that this works and has no console errors Change-Id: I7e8696cf54afda6de08fa729452f14fc1868510a Reviewed-on: https://gerrit.instructure.com/116036 Tested-by: Jenkins Product-Review: brian kirkby <bkirkby@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Reviewed-by: brian kirkby <bkirkby@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com>
-
Brent Burgoyne authored
the first two rcs flags have been enabled for all hosted accounts for a long time. we are changing the lable of the 3rd flag and removing the first two to provide better clarity as we enable the 3rd flag for accounts. closes CNVS-37261 test plan: - go to the feature flags page for an account - there should only be one rcs flag with an updated message - ensure that flag is disabled - editing wiki pages should still have the new sidebar - high risk area (i.e. quizzes, assignments) should not have the new sidebar - enable the flag - all editors should be using rcs with the new sidebar Change-Id: I689eb9ebaf4d3a5fc111c231d13861cc28ae5d87 Reviewed-on: https://gerrit.instructure.com/116542 Tested-by: Jenkins Reviewed-by: brian kirkby <bkirkby@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
-
brian kirkby authored
fixes CNVS-37274 test plan: - enable rcs for quizzes - create a quiz then create a multiple choice question - on the question, enter an answer into the first answer field - click on the "Toggle editing answer text as HTML" edit icon - verify that the text you entered was carried into the MCE editor - enter some more text and click "Done" - verify your changes carried back to the answer area - click on the "Toggle editing answer text as HTML" edit icon again - verify that the text was carried into the MCE editor - rejoice Change-Id: Id6473e6855b9b1a96dcb4c107868b51e3c9a1555 Reviewed-on: https://gerrit.instructure.com/115407 Product-Review: brian kirkby <bkirkby@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com>
-
brian kirkby authored
fixes CNVS-37279 fixes CNVS-37282 test plan: - with RCS turned on, go to a course - select "Outcomes" - create a new outcome by clicking the "+ Outcome" button - enter a name and text for the outcome - click "Save" - verify that it saves Change-Id: I37edd29bd6e6dd8d97c1f64e84938fa9e8e7e013 Reviewed-on: https://gerrit.instructure.com/115154 Product-Review: brian kirkby <bkirkby@instructure.com> Tested-by: Jenkins Reviewed-by: Tyler Pickett <tpickett@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com>
-
- Jun 28, 2017
-
-
Zach Wily authored
closes CNVS-37886 Because we are hijacking crocodoc sessions for canvadocs now anyway, the only effect "force_crocodoc" has is forcing crocodoc to generate the pdf. The canvadocs viewer is still used. test plan: * In an account with canvadocs and annotations and crocodoc hijacking enabled: * Create a moderated grading assignment * Upload a document as a student as a submission * Verify that the submission attachment gets a Canvadoc associated with it, not a CrocodocDocument. Change-Id: Ifbc89b84bdb26a49d682ddd0570c761d540e1477 Reviewed-on: https://gerrit.instructure.com/116892 QA-Review: Caleb Guanzon <cguanzon@instructure.com> Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Tested-by: Zach Wily <zach@instructure.com> Product-Review: Zach Wily <zach@instructure.com>
-
James Williams authored
was added to individual module cache in 3774e181 test plan: * have a teacher role with "Manage all other course content" disabled * have a course with a module with an unpublished item * view the modules page as a student * view the modules page as the teacher * the teacher shouldn't see a cached student view (they should see the unpublished item) closes #CNVS-37855 Change-Id: I8e72690135e664aefa14c9fd274e45aff05c2860 Reviewed-on: https://gerrit.instructure.com/117082 Tested-by: Jenkins Reviewed-by: Dan Minkevitch <dan@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
-
Zach Wily authored
closes CNVS-37809 The only exception is when o365 is enabled (in which case, it is the preferred plugin). Everybody using Canvadocs now should have pdfjs enabled anyway. Test plan: * Create an attachment that has an assignment as the context. (I don't know how to do this... I just know it can happen within the bowels of Canvas.) * Verify that that attachment is viewed in Canvadocs, not Box. Change-Id: Icc8f1959815f34361db046572dcfb0841eacd5ed Reviewed-on: https://gerrit.instructure.com/116901 Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Tested-by: Jenkins QA-Review: Caleb Guanzon <cguanzon@instructure.com> Product-Review: Caleb Guanzon <cguanzon@instructure.com>
-
- Jun 27, 2017
-
-
Cody Cutrer authored
refs CNVS-37807 it could have internal references to relative images Change-Id: Ia0489ba51cbd91e936fc7ed86467784f0ecb8a1c Reviewed-on: https://gerrit.instructure.com/117084 Reviewed-by: Tyler Pickett <tpickett@instructure.com> Tested-by: Jenkins Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
fixes CNVS-37807 Change-Id: I79b4ccb30cbd302b4579b0745349ad81210ad135 Reviewed-on: https://gerrit.instructure.com/117076 Tested-by: Jenkins Reviewed-by: Tyler Pickett <tpickett@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
- Jun 26, 2017
-
-
Rob Orton authored
fixes CNVS-37803 test plan - call destroy with replace on user attachment - it should work if caller has permission to masquerade as the attachments owner Change-Id: Id74c37bfa5c2d775ba0d4d091b0fced3a05cd062 Reviewed-on: https://gerrit.instructure.com/116904 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com>
-
- Jun 25, 2017
-
-
Cody Cutrer authored
if the slave is behind, it would cause the report to fail immediately Change-Id: I7b92c05d8bafcbd6f554b8095dd70fcbb2911a6e Reviewed-on: https://gerrit.instructure.com/116902 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
- Jun 24, 2017
-
-
Cody Cutrer authored
fixes CNVS-37802 Change-Id: I715f6e6c2a45c505e1f3c9e3757ea5cfce0e632f Reviewed-on: https://gerrit.instructure.com/116890 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Pedro Fajardo <pfajardo@instructure.com> Product-Review: Dan Minkevitch <dan@instructure.com> Reviewed-by: Dan Minkevitch <dan@instructure.com> Tested-by: Jenkins
-
Cody Cutrer authored
fixes CNVS-37804 Change-Id: Iad81cde41f80c32b82b4daea82f1d0c01ecf4784 Reviewed-on: https://gerrit.instructure.com/116891 Tested-by: Jenkins Reviewed-by: Dan Minkevitch <dan@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
Transifreq authored
Change-Id: I80bec64e35dae5a3857d0ebf108110865d49581d
-
- Jun 22, 2017
-
-
James Williams authored
test plan: * have a blueprint course with an assignment with points locked * sync to an associated course * add a rubric to the assignment with a different points possible than the assignment and check to use it for grading * it should not change the assignment points closes #MC-263 Change-Id: If403205efdddb0489e9590ac4e0770afb926d025 Reviewed-on: https://gerrit.instructure.com/116375 Tested-by: Jenkins Reviewed-by: Mysti Sadler <mysti@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
-
James Williams authored
test plan: * have a graded quiz in a blueprint course * use granular locking with different settings for quizzes and assignments * lock the quiz on the assignments page * it should use the quiz locking scheme closes #MC-278 Change-Id: I2b2cb78fc701878c5fb8028fdf56cc07e32b6e90 Reviewed-on: https://gerrit.instructure.com/116560 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: David Mirabile <dmirabile-c@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
-
James Williams authored
test plan: * have a blueprint course * create a module * add a new assignment/page/etc as a module item * the blueprint lock icon should be shown right away closes #MC-275 Change-Id: Ia6e968f814dd496ea62b3a9518f657260baf606d Reviewed-on: https://gerrit.instructure.com/116386 Reviewed-by: Dan Minkevitch <dan@instructure.com> Tested-by: Jenkins QA-Review: Heath Hales <hhales@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
-
- Jun 21, 2017
-
-
Cody Cutrer authored
fixes CNVS-37656 test plan: * uplaod an image to a course files * create an HTML file that displays that image, referencing it solely by name, no absolute URL or antyhing * upload the HTML file * preview/show that html file in the browser (both by clicking preview from the files page, or going directly to it like http://canvas.dev/courses/2/files/6) * the image should display, and not be a broken link Change-Id: I004200785211edfd1cb2ba773aba0be09eea823f Reviewed-on: https://gerrit.instructure.com/116228 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
Jeremy Stanley authored
the trip through the handlebars convertApiUserContent helper makes superficial changes to things like entity escaping, which runs afoul of the content locks. avoid this by not sending such content to the backend at all (loosening form validation where required) test plan: - have a blueprint course configured to lock content - for each type of learning object that includes rich text and is lockable (announcement, assignment, discussion, quiz, wiki page), in a blueprint course, 1. create the object and put a trailing space at the end of the rich text content 2. lock the object - perform a sync - in a minion course, 1. edit the object and change something that isn't content 2. ensure the item can save without error fixes MC-261 Change-Id: I0a63351dc2e75a3c711e04d37bb15289bd767fd1 Reviewed-on: https://gerrit.instructure.com/115773 Tested-by: Jenkins Reviewed-by: James Williams <jamesw@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
-
Cody Cutrer authored
fixes CNVS-37619 test plan: * log in as a non site admin user * go to /login?force_login=1 * you should not get an error Change-Id: I768295b641742e5b561000609a11543d44350488 Reviewed-on: https://gerrit.instructure.com/116001 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Jenkins QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
Transifreq authored
Change-Id: I9ee0240ccf03c1857b8a33f7f17151bcd028bed7
-
Transifreq authored
Change-Id: Ib454b6dbce2d82576c7c5de0bf59031b6ecad70f
-
Transifreq authored
Change-Id: Ie6740fbaf460961c2530b2045fea8fd545e374cf
-
Transifreq authored
Change-Id: I3eba3eb1cea56033d817ae4d7c0780c29d88b3eb
-
Transifreq authored
Change-Id: Ia945575195a5962ddcc5973857e4e09844b7e74e
-
Transifreq authored
Change-Id: Iebe33642467204a8920bc3c164220a664af1be40
-
Transifreq authored
Change-Id: Ib14e7bc15bfaa9794b8730826c1a048979c54d9e
-
Transifreq authored
Change-Id: If4e8c3e4329054aa4690ca0f4f30694dc6d6e4db
-
Transifreq authored
Change-Id: I94cf47473b164a964e0962472393ef5cddad7e7a
-
Transifreq authored
Change-Id: I6ecd2c657ca2d53aa75d3d9673f53adcf032bd0b
-
Transifreq authored
Change-Id: I4070a91ad5ec142bb1fa134f7c129e7735dc564f
-
Transifreq authored
Change-Id: Ibcab7af92c989f84633f45b1f441edd784c5b40b
-
Transifreq authored
Change-Id: Ibcf5f40a3e51d1849fd2ef87c8dad73e725de51e
-
Transifreq authored
Change-Id: I30562ce4a72d52c91acc7db9dcac16b221876e90
-
Transifreq authored
Change-Id: Ia8f812a1579dc2e22e4cb1eae2071132989566e4
-
Transifreq authored
Change-Id: Ia1ebf45717874e52e078386a0d01177b7f2b1c74
-
Transifreq authored
Change-Id: Iff28e58495920f572b5a6ffe8083b899b3d3335f
-
Transifreq authored
Change-Id: I43c794305d3b3f05bd98753e9261b856bf7a48e7
-