Skip to content
Snippets Groups Projects
  1. Jun 29, 2017
    • brian kirkby's avatar
      when RCS detroys <textarea/> make sure it gets re-added · 1026fedf
      brian kirkby authored
      fixes CNVS-37863
      
      test plan:
      - edit a course syllabus
      - make sure the course syllabus is edited
      - go back in to re-edit the course syllabus
      - make sure tinymce is available and we can switch to HTML mode
      - rejoice!
      
      Change-Id: Ife3fd72d676f59819c00e24a577f503eea0b339b
      Reviewed-on: https://gerrit.instructure.com/117247
      
      
      Reviewed-by: default avatarBrent Burgoyne <bburgoyne@instructure.com>
      Tested-by: Jenkins
      Product-Review: brian kirkby <bkirkby@instructure.com>
      QA-Review: Tucker McKnight <tmcknight@instructure.com>
    • Rob Orton's avatar
      use touch_all to prevent deadlock · 23efd7fc
      Rob Orton authored
      fixes CNVS-37866
      
      test plan
       - specs should pass
      
      Change-Id: Id77fdbf89f71706586b786f09b13a16b695cfc07
      Reviewed-on: https://gerrit.instructure.com/117306
      
      
      Tested-by: Jenkins
      QA-Review: Tucker McKnight <tmcknight@instructure.com>
      Product-Review: Rob Orton <rob@instructure.com>
      Reviewed-by: default avatarNeil Gupta <ngupta@instructure.com>
      23efd7fc
    • Brent Burgoyne's avatar
      upgrade canvas-rce and tinymce-light-skin · cfc36b29
      Brent Burgoyne authored
      the new version of the rce and skin no longer incorrectly display the
      font size of text in tables. many of the canvas style overrides have
      also been moved to the skin and are no longer needed in canvas.
      
      the initial push of this fix broke several rcs selenium tests due to a
      circular destroy chain. https://gerrit.instructure.com/#/c/116660/ fixes
      that and has been published to npm as v2.2.0-alpha.1. we should test this
      patchset against that npm version
      
      fixes CNVS-37517
      
      test plan:
      - run yarn install first to get new dependency versions. canvas-lms should
        be version 2.2.0-alpha.1
      - test rcs and legacy editors
      - insert a table, type in a cell, text should be same size as outside
        the table (shows as 11pt in toobar)
      - test the toolbar nav with and without high contrast (alt+f10)
      - toolbar styles should match colors and have a triangle under for
        active state, and a border for focus state, and both when focusing
        on an active button
      - create a discussion thread
      - add a reply to the discussion thread
      - edit the reply to the discussion thread
      - verify that this works and has no console errors
      
      Change-Id: I7e8696cf54afda6de08fa729452f14fc1868510a
      Reviewed-on: https://gerrit.instructure.com/116036
      
      
      Tested-by: Jenkins
      Product-Review: brian kirkby <bkirkby@instructure.com>
      Reviewed-by: default avatarBrent Burgoyne <bburgoyne@instructure.com>
      Reviewed-by: default avatarbrian kirkby <bkirkby@instructure.com>
      QA-Review: Tucker McKnight <tmcknight@instructure.com>
      cfc36b29
    • Brent Burgoyne's avatar
      change rcs feature flag text, remove first 2 flags · 9c2cc330
      Brent Burgoyne authored
      the first two rcs flags have been enabled for all hosted accounts
      for a long time. we are changing the lable of the 3rd flag and removing the
      first two to provide better clarity as we enable the 3rd flag for
      accounts.
      
      closes CNVS-37261
      
      test plan:
      - go to the feature flags page for an account
        - there should only be one rcs flag with an updated message
      - ensure that flag is disabled
      - editing wiki pages should still have the new sidebar
      - high risk area (i.e. quizzes, assignments) should not have the new
        sidebar
      - enable the flag
      - all editors should be using rcs with the new sidebar
      
      Change-Id: I689eb9ebaf4d3a5fc111c231d13861cc28ae5d87
      Reviewed-on: https://gerrit.instructure.com/116542
      
      
      Tested-by: Jenkins
      Reviewed-by: default avatarbrian kirkby <bkirkby@instructure.com>
      QA-Review: Jeremy Putnam <jeremyp@instructure.com>
      Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
      9c2cc330
    • brian kirkby's avatar
      mechanic for sending delay commands to rce when not loaded yet · ee59949f
      brian kirkby authored
      fixes CNVS-37274
      
      test plan:
      - enable rcs for quizzes
      - create a quiz then create a multiple choice question
      - on the question, enter an answer into the first answer field
      - click on the "Toggle editing answer text as HTML" edit icon
      - verify that the text you entered was carried into the MCE editor
      - enter some more text and click "Done"
      - verify your changes carried back to the answer area
      - click on the "Toggle editing answer text as HTML" edit icon again
      - verify that the text was carried into the MCE editor
      - rejoice
      
      Change-Id: Id6473e6855b9b1a96dcb4c107868b51e3c9a1555
      Reviewed-on: https://gerrit.instructure.com/115407
      
      
      Product-Review: brian kirkby <bkirkby@instructure.com>
      Reviewed-by: default avatarBrent Burgoyne <bburgoyne@instructure.com>
      Tested-by: Jenkins
      QA-Review: Jeremy Putnam <jeremyp@instructure.com>
      ee59949f
    • brian kirkby's avatar
      check for nil on RceCommandShim in case of double delete. don't except · b5d4ce3e
      brian kirkby authored
      fixes CNVS-37279
      fixes CNVS-37282
      
      test plan:
      - with RCS turned on, go to a course
      - select "Outcomes"
      - create a new outcome by clicking the "+ Outcome" button
      - enter a name and text for the outcome
      - click "Save"
      - verify that it saves
      
      Change-Id: I37edd29bd6e6dd8d97c1f64e84938fa9e8e7e013
      Reviewed-on: https://gerrit.instructure.com/115154
      
      
      Product-Review: brian kirkby <bkirkby@instructure.com>
      Tested-by: Jenkins
      Reviewed-by: default avatarTyler Pickett <tpickett@instructure.com>
      QA-Review: Jeremy Putnam <jeremyp@instructure.com>
      b5d4ce3e
  2. Jun 28, 2017
    • Zach Wily's avatar
      stop sending moderated grading assignments to crocodoc · 54853501
      Zach Wily authored
      closes CNVS-37886
      
      Because we are hijacking crocodoc sessions for canvadocs now anyway,
      the only effect "force_crocodoc" has is forcing crocodoc to generate
      the pdf. The canvadocs viewer is still used.
      
      test plan:
       * In an account with canvadocs and annotations and crocodoc hijacking
         enabled:
       * Create a moderated grading assignment
       * Upload a document as a student as a submission
       * Verify that the submission attachment gets a Canvadoc associated with it,
         not a CrocodocDocument.
      
      Change-Id: Ifbc89b84bdb26a49d682ddd0570c761d540e1477
      Reviewed-on: https://gerrit.instructure.com/116892
      
      
      QA-Review: Caleb Guanzon <cguanzon@instructure.com>
      Reviewed-by: default avatarMatthew Wheeler <mwheeler@instructure.com>
      Tested-by: default avatarZach Wily <zach@instructure.com>
      Product-Review: Zach Wily <zach@instructure.com>
    • James Williams's avatar
      add is_student and can_view_unpublished to modules cache keys · 90268fcf
      James Williams authored
      was added to individual module cache in
      3774e181
      
      test plan:
      * have a teacher role with "Manage all other
       course content" disabled
      * have a course with a module with an unpublished
       item
      * view the modules page as a student
      * view the modules page as the teacher
      * the teacher shouldn't see a cached student view
       (they should see the unpublished item)
      
      closes #CNVS-37855
      
      Change-Id: I8e72690135e664aefa14c9fd274e45aff05c2860
      Reviewed-on: https://gerrit.instructure.com/117082
      
      
      Tested-by: Jenkins
      Reviewed-by: default avatarDan Minkevitch <dan@instructure.com>
      QA-Review: Heath Hales <hhales@instructure.com>
      Product-Review: James Williams  <jamesw@instructure.com>
      90268fcf
    • Zach Wily's avatar
      always send pdfjs as the preferred canvadocs renderer now · 212a0bef
      Zach Wily authored
      closes CNVS-37809
      
      The only exception is when o365 is enabled (in which case, it is the
      preferred plugin).
      
      Everybody using Canvadocs now should have pdfjs enabled anyway.
      
      Test plan:
       * Create an attachment that has an assignment as the context.
         (I don't know how to do this... I just know it can happen within
         the bowels of Canvas.)
       * Verify that that attachment is viewed in Canvadocs, not Box.
      
      Change-Id: Icc8f1959815f34361db046572dcfb0841eacd5ed
      Reviewed-on: https://gerrit.instructure.com/116901
      
      
      Reviewed-by: default avatarMatthew Wheeler <mwheeler@instructure.com>
      Tested-by: Jenkins
      QA-Review: Caleb Guanzon <cguanzon@instructure.com>
      Product-Review: Caleb Guanzon <cguanzon@instructure.com>
      212a0bef
  3. Jun 27, 2017
  4. Jun 26, 2017
  5. Jun 25, 2017
  6. Jun 24, 2017
  7. Jun 22, 2017
  8. Jun 21, 2017