Change-Id: I58586b83bcfefd2340d13aa7cd791aaab1a7b72a

Change-Id: Iaa683d3576ddf007a691152fd9b3156d20495f84

Change-Id: I02f95ded1b957b5530ac560e1faf90d8719df9c7

Change-Id: I8ea3d964bdca34e9d671d0dbad430a94415a3aa9

Change-Id: I8c81083ce114920fb728f9db9d8741fc7245f021

Change-Id: I37c6e9a4ac995ef5443d984f337e5d7d25ff2765

Change-Id: I7f149713897c6ecf85ca480fcb004ec114f2e824

Change-Id: Iba212c844866e8b402e5e186b466f34223d1d259

Change-Id: I10284676bec8f690dde7d7804f44f9286bc305d2

Change-Id: Ided7413144e102ddbf2d81aba0ef9a92c23775bd

Change-Id: I921d49d7c58e01d720a1cc79a80a5bea044282b6

Change-Id: I554708a0263eee1a47bae163a6b8a80517524496

Change-Id: I0471bd3e29ec2811b08f4e413abb631b90260dd7

Change-Id: Ie03e24278e15740b1c81580c6daa0ffbc4a74dc4

Change-Id: I0a3b9a2f2bcc6cf1921d53f2f63ca35ab4c4967c

Change-Id: Ifcc4b68a621a4a86f1c5ee75398996a7b4982be0

Change-Id: I487089931cde07a2571ecec31004cfe76383aa86

Change-Id: I5b2f3b931d43e35a5200c82b94b69ac7ed477faf

Change-Id: Ie83de3d2c8c594f8df7e5c058386f1517956913f

Change-Id: I23d1f20e3cc31cdd5dbb8606bf68e379def414d6

fixes CNVS-38431

test plan
 - specs should pass

Change-Id: Id1bb379a0b7c7c11a78d33a9df1859529d05f25a
Reviewed-on: https://gerrit.instructure.com/123217


Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

Fixes: SIS-2914

Test plan:
- Enable all post to sis feature options
- Enable the max name length setting
- Do not set a value
- Update the account settings
- Navigate to a course
- Create an assignment with post to sis checked
- Confirm that you can save an assignment with a name up to 255
  characters

Change-Id: I4d4abcf93adaa97a636cef837c1fdc7f55f7600c
Reviewed-on: https://gerrit.instructure.com/122629


Reviewed-by: Brad Humphrey <brad@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
QA-Review: Mark McDermott <mmcdermott@instructure.com>

test plan:
* in a blueprint course create an assignment, discussion and
a quiz all with a link to a file in their description
* lock content for all of them
* sync to a child course
* in the child course, should be able to edit dates without
getting an error

close #CNVS-38520

Change-Id: I0eb7331094871d8e2698ee1357fa2c0c16f3bd46
Reviewed-on: https://gerrit.instructure.com/122384


Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

fixes CNVS-38622

Change-Id: Ic024761a34dea2b1e3eeaea9cb03eaeffa127bb4
Reviewed-on: https://gerrit.instructure.com/122372


Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>

refs CNVS-38593

Change-Id: I4fafddabb19be4026d73442b9c83ec3e81a920c5
Reviewed-on: https://gerrit.instructure.com/123130


Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>

fixes CNVS-38695

test plan
 - provisioning report should run

Change-Id: Ibb2e3b82aaa4b9da922eb850d4001a65cb42f232
Reviewed-on: https://gerrit.instructure.com/122953


Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>

so we can configure per-account.  still get the url from dynamic
settings.

refs CNVS-35833
refs CNVS-37254

test plan:
- configure the url part of mathman with a dynamic setting and the
use_for svg/mml part with a plugin setting
- it should all work

Change-Id: I4a0963a566cea69fe63cfe2d77278562968d3b97
Reviewed-on: https://gerrit.instructure.com/123048


Tested-by: Jenkins
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>

fixes CNVS-38593

an updated net-ldap gem changed these defaults

test plan:
 * do an LDAP test against an LDAP server that uses SSL
 * it should work

Change-Id: I9519033ee45cdceb7dda356a18c497c1615a091b
Reviewed-on: https://gerrit.instructure.com/122785


Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

Change-Id: I99f4a24b745a99a28ebf0ccf0314217f9aeec247
Fixes: CNVS-38691
Reviewed-on: https://gerrit.instructure.com/122797


Tested-by: Jenkins
Reviewed-by: Hannah Bottalla <hannah@instructure.com>
Product-Review: Hannah Bottalla <hannah@instructure.com>
QA-Review: Hannah Bottalla <hannah@instructure.com>

fixes CNVS-38494

Change-Id: I929a87349374be4f2d66dd05d6f18736b470d40c
Reviewed-on: https://gerrit.instructure.com/122617


Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

fixes PLAT-2770

test plan:
• Go to any account/course settings page
• Click on the Apps tab
• Click on any LTI that populates within the App Center (I use 3DGameLab)
• Click '+ Add App'
• Click the 'Add App' button in the window that appears
• Verify app is added successfully

Change-Id: I060ed314423c841ff5d8ef12c46f2377f31b58b1
Reviewed-on: https://gerrit.instructure.com/122918


Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: August Thornton <august@instructure.com>

Fixes: CNVS-38676

This was causing a storm of jobs and tons of duplicate advisory locks
during the import process, both of these things are unnecessary since
we're already in a background job.

Test Plan:
- Course Content Migrations still work
- There should be fewer jobs spawned during content migrations/imports

Change-Id: Ia29e2d4ba00a3f982404b834061822cae32e5364
Reviewed-on: https://gerrit.instructure.com/122763


Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Tyler Pickett <tpickett@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

Change-Id: I2c462127007155b9fb0c75e3e1361274e2ed02b1
Reviewed-on: https://gerrit.instructure.com/122911


Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

there is a measurable cost associated to this step of api content
transformation, so only run it on types of url attributes that might
actually need to be rewritten (ignore mathml href's)

fixes CNVS-38442

test plan:
- create a submission with a lot of <p> tags
- request it from the API
- performance should be better
- now create a link/image to something root-relative in canvas
- request it from the api
- it should come back as absolute

Change-Id: I21fc42db25e84e70a0d19db7dc271cfd46801ecb
Reviewed-on: https://gerrit.instructure.com/122400


Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>

Fixes: CNVS-38667

When Assignment#update_submissions is being called it's triggering
Submission#update_assignment to be called without indicating that we
don't need to update the assignment again, this patch fixes that so the
assignment update won't be circular.

Test Plan:
- Stuff still works

Change-Id: I7deb87081725396fa3cfebda25605238b9614a57
Reviewed-on: https://gerrit.instructure.com/122624


Reviewed-by: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Tyler Pickett <tpickett@instructure.com>

closes CNVS-38670

test plan:
- perform a search with the recipient search api
  (/api/v1/search/recipients)
- result should include full_name for users

Change-Id: I1ac89ac35448bf3ca68b754ca5fefb794e97d4e3
Reviewed-on: https://gerrit.instructure.com/122709


Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>

Change-Id: I4dcda998690b0dbafc397bd12b27ffbb1efca6f2

Change-Id: Ib2589ffa3977adaadf3a3f32315f0eb13014d815

Change-Id: I495d02544e43ac721346e4556140874f600d06c3
Reviewed-on: https://gerrit.instructure.com/122662


Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>

Change-Id: I2dbb037d4cbb0de7952dde19196c6937d18924e9
Reviewed-on: https://gerrit.instructure.com/122554


Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>