Change-Id: If08466ee32d5cc848ccefca776c8104b3a80d73f
Reviewed-on: https://gerrit.instructure.com/129044


Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
Tested-by: James Williams <jamesw@instructure.com>

Change-Id: I7e52ee10ae3e6d4e666452a7a53e5459dfad43f4
Reviewed-on: https://gerrit.instructure.com/129032


Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
Tested-by: James Williams <jamesw@instructure.com>

Fixes: CNVS-39854

Test plan:
* mv config/database.yml config/database.yml.backup
* bundle exec rake canvas:compile_assets
* it should work
* Docker build should pass

Change-Id: I0786d1de1d6f6f69d665e10b0428571e77d7f859
Reviewed-on: https://gerrit.instructure.com/128974


Reviewed-by: James Williams <jamesw@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>

closes CNVS-39091

test plan:
- a Check Accessibility button should show on the right side of all
  editors
- try adding a empty table
- click the check a11y button
- should have two errors
  - missing caption
  - missing headers
- correct both errors
- should show no errors detected and close

Change-Id: I4028d98d082bdbdebc034facc529cccb67fc4dcf
Reviewed-on: https://gerrit.instructure.com/128951


Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>

Closes: CNVS-39755 CNVS-39647

Test plan:
* enable user/course search feature flag
* go to /accounts/x
* on the “Courses” tab, there should be a “Term”
  Column on the results table
* clicking it should sort the results by term
  name properly

Change-Id: Idb27356f6eeb66380f739b8d4550cf2fdd908dc2
Reviewed-on: https://gerrit.instructure.com/128347


Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>

Change-Id: I17be1caf629c6e766ed3d5581bb63d0cc0e97302
Reviewed-on: https://gerrit.instructure.com/128933


Reviewed-by: Matt Berns <mberns@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

fixes CNVS-39751

test plan
 - run rake doc:api
 - it should generate
 - this sis integrations api should be documented

Change-Id: I5e1b8ab1e58df472fe34b393afceb198a69db9dd
Reviewed-on: https://gerrit.instructure.com/128444


Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

Fixes: CNVS-39790

Test plan:
Go to account settings in RAILS_ENV=production
You should see the account/user search feature flag
There should not be a “development” label next to it

Change-Id: I07db49846df08b7fada2575338df89ca762a8700
Reviewed-on: https://gerrit.instructure.com/128819


Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>

Change-Id: Iaf0de2d0487b79a32c7ee13977818dbb25d5dea3
Reviewed-on: https://gerrit.instructure.com/128932


Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>

Change-Id: Icd6707a5d7f103d231a6391874cb0dfc10dc5ad1

Fixes: CNVS-39559

I had previously already fixed the styling of
the courses tab, this also fixes it for the
“People” tab

Test plan:
* Turn on “course/user search” feature flag
* go to “courses & people” in an account
* click the “people” tab
* the headers should be styled correctly
* click them to make sure that the arrows show up and sort correctly

Change-Id: I84374d3c7354e5d51c80afb76e4eeecdb4f556c7
Reviewed-on: https://gerrit.instructure.com/128818


Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

we already show all groups in the menu, just not
the menu

fixes CNVS-39650

test plan
 - have a cross shard group
 - you should be able to get to it from global nav

Change-Id: I2806cd78ec7079abb8967c09fe33a2eb82efd5df
Reviewed-on: https://gerrit.instructure.com/128467


Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

closes GRADE-336

test plan:
* Create a course with at least two student and one assignment
* Verify the students don't have avatars
* Go to Gradebook and open up the Submission Tray for the last student
  in the grid
* Verify there is a gap between the Tray's close button and the left
  arrow shown next to the Student's name

Change-Id: I791b62700eb9b1798cbad7a37ce3b714cd69d33b
Reviewed-on: https://gerrit.instructure.com/128545


Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>

It was getting the raw cached string from Redis instead of
requesting a deserialized object.

test plan:
* none, developer tested

Change-Id: I8815439b47a95493ab380e56563f74250f8fd279
Reviewed-on: https://gerrit.instructure.com/128884


Reviewed-by: Mysti Sadler <mysti@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>

When I was playing around locally, I got a:
“Cannot read property ‘privacy_policy_url’ of undefined” Error

Test plan:
You shouldn’t get a js error when you open this dialog

Change-Id: Iac83e426970e1de82ae99932798b212f164d6bea
Reviewed-on: https://gerrit.instructure.com/128820


Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>

fixes CNVS-39635

test plan
 - sis import api should return user

Change-Id: If54a50a646c8b73ebf122885d53717572930dda7
Reviewed-on: https://gerrit.instructure.com/128018


Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>

Closes PLAT-2843

Test Plan:
- Create an assignment associated with a plagiarism
  detection tool.
- Export the assignment and verify the assignment
  resource xml contains the product code, vendor
  code, and resource type code of the associated
  assignment.
- Verify exporting assignments with no plagiarism tools
  continues to function as before.

Change-Id: Idc6e9e2863baa083ec6d7c4c058719cf632ecc22
Reviewed-on: https://gerrit.instructure.com/128742


Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>

fixes: GRADE-339

test plan:
  - with new annotations disabled
  - have a course with an assignment that requires a file upload
  - have a student submit the assignment with a doc pdf or docx file
    type
  - as the student or teacher go to the assignment submissions page
  - as a student click 'Grades'
  - click the assignment that was previously submitted
  - ensure that the document preview loads without errors
  - as a teacher click 'Grades'
  - click the students name
  - click the assignment that was previously submitted
  - ensure that the document preview loads without errors

Change-Id: Idd6984aae779205b247927843da8c8acfb5a33d6
Reviewed-on: https://gerrit.instructure.com/128803


Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>

closes CNVS-39437

Change-Id: I9848d7577792939a65dabfc458a490a42f01d3d3
Reviewed-on: https://gerrit.instructure.com/127490


Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Collin Parrish <cparrish@instructure.com>
Tested-by: Jenkins
Product-Review: Cameron Matheson <cameron@instructure.com>

Change-Id: I9b6eeaea60229ec349cbb1ea1c4d268e58fc5520
Reviewed-on: https://gerrit.instructure.com/128738


Tested-by: Jenkins
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Collin Parrish <cparrish@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>

closes CNVS-38624

Test Plan:
  - Add a page to a course
  - Use the HTML editor to put in an iframe specifying width
    and height in a style tag. Something like:
        <iframe style="width: 800px; height: 600px;" src="https://google.com">
        </iframe>
  - Save the page
  - Edit the page, notice that the placeholder for the iframe has the same
    dimensions you specified previously.

Change-Id: I0ba0f7fb4fcf49a9ca8bd66e77148c94fce2baa4
Reviewed-on: https://gerrit.instructure.com/128233


Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>

ref PLAT-2844

test plan:
create a originality report placement
do a launch
it should use the lti_assignment_id as the resource_link_id

Change-Id: I6409677a14c259c8f71582deff52698554078d48
Reviewed-on: https://gerrit.instructure.com/128635


Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>

handlebars_helpers.coffee includes calls to I18n.t, but was explicitely
excluded from the i18n export. This changes that.

fixes CNVS-308106

test plan:
  wait for translations to go out and come back
  - go to /accounts/1/admin_tools
  - click on View Notifications tab
  - click on a user (you may have to search if no users actually have
    notifications)
  - in the devtools console run
    document.getElementById('search_start_date_label').textContent
  > expect the result to be translated. in particular "Format Like"

Change-Id: I69e4abb8cc9fc80b59990887d8825ec912db323e
Reviewed-on: https://gerrit.instructure.com/126897


Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>

Fixes: CNVS-39607

test plan:
- ticket set-up... ensure you have a course with multiple
  assignments, quizzes, discussions + users enrolled
- ensure you have "new gradebook" turned on at the account
  level under course section so it can be used on the
  course settings
- ensure some of the above have been graded
- as a student - navigate to course select "grades" from the
  left-hand sub-nav | the table has been updated
  similar to: https://screencast.com/t/bNCVC5zHc
- as a student with high-contrast turned on navigate to
  course select "grades" from the left-hand sub-nav | the
  table has been updated similar to:
  https://screencast.com/t/ff1HTunJqF9M
- as an admin/teacher navigate to course select "grades"
  from the left-hand sub-nav... choose one of the above
  students to view their table... similar to:
  https://screencast.com/t/YFT9rSpUKN
- in order to see some of the icons within the last
  column - ensure at least one of the assignments has
  comments, a rubric attached, or an assignment that
  has been "excused" for a user

Change-Id: I9ea40408d859cdfcc4f23c94a55c357d67cf188d
Reviewed-on: https://gerrit.instructure.com/127972


Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Mary Jane Anderson <manderson@instructure.com>

Fixes: CNVS-39313

test plan:
- sis agent needs to be set-up for this (** however i could not
  get this working locally **)
- under account settings "apps" the above sis agent needs to be
  added (_gradebook qa has steps for this_)
- one the app is set-up on the "features" tab... "enable new sis
  integration settings" needs to be turned on
- once the above is complete... create a course with a sis id
- navigate to the gradebook > click the "export" dropdown and the
  sis agent should be listed with the ability to "sync"
  (** on my local the modal shows but does not have a table of
  data inside it.. but rather an error message **)

Change-Id: Ibb762c8a7062943dcad342ab84495d5765432c93
Reviewed-on: https://gerrit.instructure.com/126508


Reviewed-by: Nick Houle <nhoule@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins

Change-Id: I13eddbe900070b8f50ff5c8f6f016daa27ec87d1
Reviewed-on: https://gerrit.instructure.com/128447


Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>

fixes CNVS-39550

test plan:
- Navigate to the Login page (/login/canvas)
- Inspect the element of the Canvas logo at the top of the page
- Note that the class "ic-Login-header" is an h1
- Test with a screen reader to ensure it is announced properly

Change-Id: I077648361da679b0db5d40255f3db993032a0108
Reviewed-on: https://gerrit.instructure.com/127980


Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>

Change-Id: Iec0010904a62bde85bf8bd5494775fd02e0e5585
Reviewed-on: https://gerrit.instructure.com/128246


Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>

Fixes: CNVS-39534

test plan:
- fire up local canvas as a user that has at least one unread
  message in inbox (so the badge notification shows in the main
  nav)
- there should no longer be a box-shadow being applied to the badge
  itself (this brings it inline with what is in instui)

  example: https://screencast.com/t/9QLu1R2wJ

Change-Id: I13f0e46c4b28a9d057ea2fb37e9855f82cd0e1ef
Reviewed-on: https://gerrit.instructure.com/128511


Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>

Fixes PFS-8549

Test Plan:
Verify that a description is now able to be added for
rubric ratings.  Description should adhere to requirements
outlined in JIRA.

Specifically:
1.  Add a rating description, and save the rubric.  Verify
    that description is still present after saving.  Reload
    page.  Verify description is still present.
2.  Verify rating description is displayed on the following
    pages:
    a) Assignment submission view.
    b) SpeedGrader / PeerReview view.
    c) Student Grades view.
    d) Account/Course rubric view.
    e) Assignment rubric view.
3.  Verify that course copy will also copy rating descriptions
    from rubrics.

Change-Id: I544a0564fd3df6b8928a44d13464693621f96533
Reviewed-on: https://gerrit.instructure.com/126139


QA-Review: Aiona Hernandez <ahernandez@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>

Closes CNVS-39302

Test Plan:
* As an admin
* With avatars enabled
* Visit a user's profile
* Inspect their avatar image
* The alt text should read "Click to change profile
  picture for USER", where USER is the profile user's
  short name/display name

Change-Id: I51fd7cf1e5ab05046808e97b01ec404993aed64d
Reviewed-on: https://gerrit.instructure.com/126040


Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>

closes GRADE-330

test plan:
* Create a course with at least one assignment and one student; call
  the student "J'onn J'onzz"
* Go to Gradebook and open the submission tray on a cell on J'onn's row
* Verify his name appears as J'onn J'onzz and not J'onn J'onzz

Change-Id: I6e907dad7ae25d1d48620bdc1412de96e279d878
Reviewed-on: https://gerrit.instructure.com/128505


Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>

fixes CNVS-39725

test plan
 - rake doc:api
 - should have graded_at on submission object

Change-Id: I0e929382805f2a2bc5359b2b48a1f89a27173f35
Reviewed-on: https://gerrit.instructure.com/128239


Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

fixes CNVS-39788

test plan
 - should have multi_term_batch_mode in response

Change-Id: Idb0ada9eff15c62848d7b616e95a8b01d4870cca
Reviewed-on: https://gerrit.instructure.com/128521


Tested-by: Jenkins
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

Change-Id: I89b1a4070275a1ed84c0cbb649b74657c8af62fb

Change-Id: Ib64a139e3828043fa805b9340fe20b1530371c8d

Change-Id: I34d1ebdd0bb5ffd13faedfbf9cc113b681831359

fixes CNVS-39100

test plan:
- hit 'reply' to a discussion
- verify it puts the focus on the tinymce edit area
- verify that switching between RCE and HTML editors will put focus to the
  editor
  - announcements, assignments, discussions, discussions-reply, wiki-pages
    syllabus, outcomes, quizzes-detail, quizzes-questions
- verify that edit and new in the following areas will put the focus on
  the proper field
  - assignments, discussions-reply, quizzes-detail

Change-Id: I02c7fde039d913c349b62091d2be3b35317200e6
Reviewed-on: https://gerrit.instructure.com/126089


Product-Review: brian kirkby <bkirkby@instructure.com>
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>

Closes QA-393,
Addreses CR from https://gerrit.instructure.com/#/c/122260/10

Change-Id: I1f56b9268c95f1b76ed9b5d4021b9287fb06afdd
Reviewed-on: https://gerrit.instructure.com/128152


Tested-by: Jenkins
Reviewed-by: KC Naegle <knaegle@instructure.com>
Product-Review: Indira Pai <ipai@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>