- Dec 01, 2017
-
-
James Williams authored
test plan: * use `Setting.set("max_group_conversation_size", "2")` in the rails console to lower the number of people a conversation can include * try to forward a message so it will be sent to more than 2 people * it should return an error closes #COMMS-564 Change-Id: I2b65df9d07b8f7a052d1b572222915c1175eee8c Reviewed-on: https://gerrit.instructure.com/134376 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com> QA-Review: Venk Natarajan <vnatarajan@instructure.com>
-
- Nov 30, 2017
-
-
Cameron Matheson authored
fixes RECNVS-93 Test plan: * enable graphql * have a class with fewer than 10 graded submissions for a student * delete the grade on some of the student's submissions (and/or submit assignments that are not graded) * the context cards should work * repeat the above steps with graphql disabled Change-Id: I292b4d476774d8223316e35440362ecd1df79a86 Reviewed-on: https://gerrit.instructure.com/134197 Tested-by: Jenkins QA-Review: Collin Parrish <cparrish@instructure.com> Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
-
- Nov 28, 2017
-
-
Cody Cutrer authored
Keep the api change though, to return asset strings relative to the current shard. And the course enrollments forcing the query to be relative to the correct shard. Also add a migration to drop the table that may or may not exist. This reverts commit fdd2eaf8. Change-Id: I5f6d9d6499fe507f98198fe546e31d8059933b76 Reviewed-on: https://gerrit.instructure.com/133960 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Reviewed-by: Tyler Pickett <tpickett@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
fixes CORE-665 test plan: * enable qualified names on two database servers * enroll a user from shard A on db A into a course in shard B * create a calendar event and an assignment in the course * view the calendar as the user, from both shard A and shard B * both the assignment and the event should show up * ensure downloading the calendar feed works too Change-Id: I8e614721d6c4be1a284e384e5587a8629eff5558 Reviewed-on: https://gerrit.instructure.com/133923 Reviewed-by: Tyler Pickett <tpickett@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
Rails 4+ returns timestamps as actual values, not just strings. They end up serializing to json as strings, so we need to support both strings and objects Change-Id: I131c780b8efe18db5bae3c1d7902c1f1f58c2655 Reviewed-on: https://gerrit.instructure.com/133922 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
some of the specificity was due to Rails 2 style sharding Change-Id: Ia6f3af886e6b9051a06b5eaaa52cdd14ca93ac42 Reviewed-on: https://gerrit.instructure.com/133884 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
This reverts commit 30ab5143. Change-Id: I5cab9a7edf9c0b0c0ba79e72d3fa239d9fb61204 Reviewed-on: https://gerrit.instructure.com/133875 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
- Nov 24, 2017
-
-
Jeremy Neander authored
fixes GRADE-650 test plan: A. Setup 1. Select or create a Course 2. Ensure the Course has a Student 3. Create an Assignment worth 10 points 4. Create a graded Quiz worth 5 points * of type "Assignment" 5. Grade the Student on the Assignment * a score of 9 / 10 6. Act as the Student 7. Complete the Quiz B. Verification 1. Log in as the Admin 2. Visit the enrollments API for the Course * /api/v1/courses/<course id>/enrollments/ 3. Verify the course score includes * the Assignment grade * the Quiz grade 4. Change the Quiz type to "Practice Quiz" 5. Visit the enrollments API for the Course * /api/v1/courses/<course id>/enrollments/ 6. Verify the course score does not include the Quiz Change-Id: Ib6890dec082fa418660e061ef39b6c151870024e Reviewed-on: https://gerrit.instructure.com/132272 Tested-by: Jenkins Reviewed-by: Keith T. Garner <kgarner@instructure.com> Reviewed-by: Spencer Olson <solson@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
-
Nathan Mills authored
fixes PLAT-2929 test plan: try and do a launch from a group rce it should work Change-Id: Ie0143becf6e5b7744978d8599baa1027d1e52aa4 Reviewed-on: https://gerrit.instructure.com/133782 QA-Review: Jeremy Putnam <jeremyp@instructure.com> Reviewed-by: Weston Dransfield <wdransfield@instructure.com> Tested-by: Jenkins Product-Review: Nathan Mills <nathanm@instructure.com>
-
- Nov 21, 2017
-
-
Cody Cutrer authored
fixes CORE-665 This reverts commit a17e7be8. Change-Id: I407bced8dc408331098d9e5eb35d978955eb3f06 Reviewed-on: https://gerrit.instructure.com/133454 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
Steven Burnett authored
fixes COMMS-521 Test Plan: - have a conversation with someone - find an unread message - notice the blue dot icon is always showing - read the conversation - notice the blue dot is no longer filled Change-Id: I550fd1134c7593bc1ad194fbd544e317c21df219 Reviewed-on: https://gerrit.instructure.com/133378 Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Tested-by: Jenkins Product-Review: Steven Burnett <sburnett@instructure.com>
-
- Nov 20, 2017
-
-
Cody Cutrer authored
fixes CORE-665 test plan: * access the calendar from a different database server * it should not error Change-Id: I76d920c354a9ca0d2eb811da02fe1872efd2a38f Reviewed-on: https://gerrit.instructure.com/133342 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
Transifreq authored
Change-Id: I08f51a2ed7b734dfbb9ab4b769043690691c327d
-
Transifreq authored
Change-Id: Id6991a632f5ce43fe699c6006b6bbbfb0ba6770e
-
Transifreq authored
Change-Id: I9e4caf1d0f94a4916b720b30e334a808ab860acc
-
Transifreq authored
Change-Id: I17bfcd7682d5b47d7632a69a2b38e233ed4ae740
-
- Nov 18, 2017
-
-
Cody Cutrer authored
fixes CNVS-40404 Change-Id: Ied1542143b45d31e6ef167c13507322ffa72def3 Reviewed-on: https://gerrit.instructure.com/133295 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Tested-by: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
Change-Id: I01fddaeb4b80e75e3a74b172a6452eaace415960 Reviewed-on: https://gerrit.instructure.com/133294 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Tested-by: Cody Cutrer <cody@instructure.com>
-
Transifreq authored
Change-Id: Ib68da51add15e612ede79e05afb6752c83fb0960
-
- Nov 16, 2017
-
-
Brent Burgoyne authored
closes CORE-645 test plan: - begin creating a multiple choice quiz question - in the correct answer's content editor click "html editor" - enter some content into the text field - click "done" - click the pencil edit icon for the answer again - there should not be an extra textarea Change-Id: Ia711fcb335d71b1f1028f3b59dbafc83c9e9188c Reviewed-on: https://gerrit.instructure.com/133090 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com>
-
Cody Cutrer authored
fixes CORE-650 Change-Id: I0e67855a08c976cb1fc2811a472ac46af6d8307b Reviewed-on: https://gerrit.instructure.com/133050 Tested-by: Jenkins Reviewed-by: Keith T. Garner <kgarner@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
Keith Garner authored
fixes GRADE-670 test plan: - Run migration - Confirm index was created on submissions table Change-Id: I36627b5a84493cf66175988f47e70c71ac71a19d Reviewed-on: https://gerrit.instructure.com/133053 Reviewed-by: Cody Cutrer <cody@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> Tested-by: Jenkins QA-Review: Shahbaz Javeed <sjaveed@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
-
Keith Garner authored
There is concern that using change_column to add a NOT NULL constraint on a large table will lock the table for too long. This uses a procedure that locks the table for a short period of time to add the constraint, and then kicks off a validation that will run outside of the lock. closes GRADE-668 test plan: - The migration runs - Check that the NOT NULL constraint is on the table. Change-Id: Idc11f170768cd4af9820e73950c5cfcc6a3354de Reviewed-on: https://gerrit.instructure.com/133002 Reviewed-by: Rob Orton <rob@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Neander <jneander@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
-
Transifreq authored
Change-Id: I3a62c25e68bf7b6b2f428830f297407e1449b301
-
Transifreq authored
Change-Id: I8f9856a15f35ce9a6793301e90e6cc9d1fcdedab
-
- Nov 14, 2017
-
-
Neil Gupta authored
By removing the unnecessary order clause, we can avoid creating an entire temp table for this batch find fixes OUT-1630 test plan: specs pass Change-Id: I5bae258f0987b187c405ea7a00a113aae036e673 Reviewed-on: https://gerrit.instructure.com/132002 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> Product-Review: Neil Gupta <ngupta@instructure.com> QA-Review: Neil Gupta <ngupta@instructure.com>
-
Steven Burnett authored
fixes COMMS-509 Test Plan: - have a user who created_at date is before 2015 and has accepted the terms once before. (you will probably have to do this through console) - login - notice you don't have to accept terms - update terms again - relogin again - notice still doesn't have to accept terms Change-Id: I0180034357e0c25c2444103dad4211c7554769bd Reviewed-on: https://gerrit.instructure.com/132592 Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: James Williams <jamesw@instructure.com> Tested-by: Jenkins QA-Review: Heath Hales <hhales@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com>
-
James Williams authored
test plan: * create a course with a group * create a course-level discussion topic assigned to the group set * visit the group's discussions page * should be able to pin/unpin the group-level generated discussion topic closes #COMMS-226 Change-Id: I8780fb720f9c133755550ab3cf5e98ee95f9b70b Reviewed-on: https://gerrit.instructure.com/130647 Reviewed-by: Jeremy Stanley <jeremy@instructure.com> Tested-by: Jenkins QA-Review: Heath Hales <hhales@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
-
- Nov 13, 2017
-
-
Rob Orton authored
we plan to change how this done later and will update the documentation at that time fixes CORE-635 test plan - rake doc:api should work Change-Id: I51562e580cfdd1296b312cba531ea65d623a8fe5 Reviewed-on: https://gerrit.instructure.com/132632 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> Product-Review: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com>
-
Transifreq authored
Change-Id: I5c8d3608a8d1320f0aea01c6dcb0a2886088928b
-
Transifreq authored
Change-Id: I9b13360e373bee21925da1d092ea0f02f3fb1817
-
Transifreq authored
Change-Id: Ia5e3487b6bc3d2e744976dd4873c5594a44a5573
-
Transifreq authored
Change-Id: Ia25382936af105077d5ccbbc3ecc364d4ec269e4
-
Transifreq authored
Change-Id: I571d5175ca8127f176caaced937c28ad9526f1a9
-
Transifreq authored
Change-Id: I51b0c12de7e45db4677a645cae095680bb3636aa
-
Transifreq authored
Change-Id: I4f60a3ca7543ad799c9aa3d03692bb73aa091532
-
Transifreq authored
Change-Id: I2d15babbca5e079baca2fb1d92ef9da6866860f3
-
Transifreq authored
Change-Id: Ib69ae065133f292a7ad3e7f40540cc4c3b37c444
-
Transifreq authored
Change-Id: I966b609addb76cddf56c3b77662389734f582b03
-
Transifreq authored
Change-Id: I34290e2d57420d7d8a8e18784889a4af57dc3937
-