- Jan 22, 2018
-
-
Clay Diffrient authored
In some situtations the sidebar would be hidden and never reappear for a given RCE. This makes it so that the sidebar reappears whenever focus goes to the RCE. closes CORE-700 Test Plan: - Go to [classic] Quizzes - Create a quiz with a mulitple choice question - In one of the answers below use the pencil icon to edit the question in an RCE - Enter some text and click the Done button - Notice the Sidebar disappears - Click into the question text area - The sidebar should reappear Change-Id: I368bb5f88961d66a05c7d7e767cb884b65ccc58b Reviewed-on: https://gerrit.instructure.com/137926 QA-Review: Tucker McKnight <tmcknight@instructure.com> Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
-
Clay Diffrient authored
refs CORE-23 Test Plan: - Make a GET request to /api/v1/folders/XX/files?use_verifiers=0 using a valid JWT - Verifiers should not be present in the URLs returned Change-Id: I7111098fe1f1fd4f8d83d06bc19f0c819fb18a85 Reviewed-on: https://gerrit.instructure.com/136683 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
-
Cody Cutrer authored
refs CORE-786 Change-Id: Ic4a0d3b1479168f0d777ac35f0c83fc57c687945 Reviewed-on: https://gerrit.instructure.com/136094 Reviewed-by: James Williams <jamesw@instructure.com> Tested-by: Jenkins Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
- Jan 19, 2018
-
-
James Williams authored
try to prevent deadlocks from happening closes #CORE-831 Change-Id: If14a516f1a5ff486b34a94cd75d5fa72d909031f Reviewed-on: https://gerrit.instructure.com/138102 Reviewed-by: Rob Orton <rob@instructure.com> Tested-by: Jenkins Product-Review: James Williams <jamesw@instructure.com> QA-Review: James Williams <jamesw@instructure.com>
-
- Jan 18, 2018
-
-
Jonathan Featherstone authored
`sis_batch_id` is updated even when no other field is changed on a sis batch import. Add `sis_batch_id` to the list of fields that will not trigger a live-events stream update. Test Plan: * Specs closes RECNVS-239 Change-Id: I15f0b82dbbe1dc47885d3f2ce05932ba66f96c97 Reviewed-on: https://gerrit.instructure.com/137963 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com> QA-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
-
Shahbaz Javeed authored
closes GRADE-756 closes GRADE-759 test plan: * Create a course with at least one assignment * Enroll two teachers (T1, T2) and two students in this course * Grade them using SpeedGrader and verify that works *** GRADE-756 * As Teacher T1, open up SpeedGrader * In a separate tab or window, conclude the enrollment of teacher T1 * Reload SpeedGrader as Teacher T1 * Verify you do not see the comment textarea * Verify you do not see the students' grades or submission details * Verify SpeedGrader is functional even though you cannot grade anyone any more nor comment on their submission *** GRADE-759 * As Teacher T2, open up SpeedGrader * Conclude the course in a separate window * Reload SpeedGrader * Verify you do not see the comment textarea * Verify you can see their grade but cannot edit it * Verify SpeedGrader is functional even though you cannot grade anyone any more nor comment on their submission (cherry picked from commit 556e698a) Change-Id: I08c330265120122ae2b151ad061c75739865ce9f Reviewed-on: https://gerrit.instructure.com/138101 Reviewed-by: Spencer Olson <solson@instructure.com> Reviewed-by: Derek Bender <djbender@instructure.com> QA-Review: Indira Pai <ipai@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com> Tested-by: Keith T. Garner <kgarner@instructure.com>
-
- Jan 16, 2018
-
-
Keith Garner authored
This adds four additional fields (unposted_current_score, unposted_final_score, unposted_current_grade, unposted_final_grade) to the enrollment and users endpoints if the requesting user has either manage_grades or view_all_grades permissions. fixes GRADE-119 test plan: - Have a course with a teacher and a student. - Have three assignments each worth 10 points, one muted (Assignment 1) and two not muted (Assignment 2 and Assignment 3). - As the teacher, grade the student 6/10 for Assignment 1 and 10/10 for Assignment 2. Do not grade the student for Assignment 3. - As the teacher, make an API call to get the grades for the student: GET /api/v1/courses/:course_id/users/:student_id?include[]=enrollments Authorization: Bearer the-teacher-api-token Verify the grades on the enrollments in the response include the unposted_current_score, unposted_final_score, unposted_current_grade, and unposted_final_grade keys. Verify the unposted_current_score is 80.00, the unposted_final_score is 53.33, the unposted_current_grade is null, and the unposted_final_grade is null. - As the student, make an API call to get the grades for yourself: GET /api/v1/courses/:course_id/users/:student_id?include[]=enrollments Authorization: Bearer the-student-api-token Verify the grades on the enrollment in the response do not include the unposted_current_score, unposted_final_score, unposted_current_grade, or unposted_final_grade keys. Change-Id: Ibd14d0ed0a246f1cb8d16d7bc9ba0beb2680cba9 Reviewed-on: https://gerrit.instructure.com/137213 Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> Tested-by: Jenkins QA-Review: Indira Pai <ipai@instructure.com> Reviewed-by: Jeremy Neander <jneander@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com>
-
- Jan 11, 2018
-
-
Spencer Olson authored
Fixes calculation of dropped assignments so that muted assignments are never considered for dropping when computing posted score. In addition, prevents score metadata for unposted grades from overwriting score metadata for posted grades. closes GRADE-763 Test Plan: * Prerequisites: Have a course with at least one student and one teacher. 1. Create two assignments in a course with the same point value and place them in the same assignment group. 2. Set up a grading rule to drop the lowest 1 score. 3. Mute one of the assignments. 4. Have the teacher enter a score of zero for the muted assignment. 5. Have the teacher enter a positive score for the second assignment. 6. Check the teacher interaction report and verify there is no page error. Change-Id: I5015ef73bb40bb0a45a21f166fa6b9ff146002da Reviewed-on: https://gerrit.instructure.com/137538 Reviewed-by: Keith T. Garner <kgarner@instructure.com> Tested-by: Jenkins QA-Review: Indira Pai <ipai@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
-
- Jan 10, 2018
-
-
Keith Garner authored
This updates the grade calculator with a new switch: only_update_course_gp_metadata. When set to true will only update ScoreMetadata data for the current score calculations for course and grading period scores closes GRADE-711 test plan: - Have a course with a student, two assignment groups, and an assignment in each group - In the rails console: - examine the scores for the student for that course and note the updated_at for the course score and the assignment group scores. - execute: GradeCalculator.new(@student.id, @course, only_update_course_gp_metadata: true).compute_and_save_scores - examine the scores for the student for that course and note that the updated_at for the course score is unchanged and the assignment group scores have been updated - examine the course score's associated ScoreMetadata, note that updated_at for ScoreMetadata has changed Change-Id: I81c9302f3dfe50b87c3a87ccef8ec98b677ff6e1 Reviewed-on: https://gerrit.instructure.com/135291 Reviewed-by: Jeremy Neander <jneander@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> QA-Review: Shahbaz Javeed <sjaveed@instructure.com> Tested-by: Jenkins Product-Review: Keith T. Garner <kgarner@instructure.com>
-
James Williams authored
Change-Id: I8fc31d843d77c79c3d2dde60ee8885af3531e9b7 Reviewed-on: https://gerrit.instructure.com/137354 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Jenkins Product-Review: James Williams <jamesw@instructure.com> QA-Review: James Williams <jamesw@instructure.com>
-
Rob Orton authored
fixes CORE-827 test plan - have an active enrollment in a course that has past the end_date - use active enrollment_state filter for submissions API with state_based_on_date=false - it should include results from the enrollment Change-Id: Ia28ee94b1f809277204c3f926a0b51d1dbc40941 Reviewed-on: https://gerrit.instructure.com/137007 Tested-by: Jenkins Reviewed-by: Keith T. Garner <kgarner@instructure.com> Reviewed-by: Derek Bender <djbender@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
-
Keith Garner authored
fixes GRADE-758 test plan: - Migration runs in a production-like environment (like beta) Change-Id: I41d9d0f42c554d8d0aedccbf928116aca5071695 Reviewed-on: https://gerrit.instructure.com/137290 Reviewed-by: James Williams <jamesw@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> Tested-by: Jenkins Product-Review: Keith T. Garner <kgarner@instructure.com> QA-Review: Keith T. Garner <kgarner@instructure.com>
-
Keith Garner authored
This datafix fills in new types of cached score data for all courses over time. This includes backfilling unposted_current_score and unposted_final_score, creating Scores for assignment_groups, and creating ScoreMetadata for all scores. closes GRADE-21 test plan: Pass one: - Ensure unit tests pass - Ensure db:migrate completes Pass two: - Have a course in a term with grading periods, 1 assignment, and 2 students, and an assignment group - Grade the students for that assignment - Conclude one of the students - In the rails console: - delete the ScoreMetadata for the concluded student - delete the assignment group Scores for the concluded student - update the remaining scores for the concluded student to have nil values for unposted_current_score and unposted_final_score - Create a second assignment - Grade the active student - Run the datafix/migration - Ensure that all Scores for all students have filled in unposted_* scores - Ensure that all students have assignment group Scores - Ensure that all Scores have associated ScoreMetadata - Repeat this procedure, but conclude the course before running the datafix Change-Id: I62dbf83637e40297e36c188024be5db6a7b8f182 Reviewed-on: https://gerrit.instructure.com/135783 Reviewed-by: Spencer Olson <solson@instructure.com> Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
-
- Jan 09, 2018
-
-
Rob Orton authored
Change-Id: Ie3ed8644f44a5c0aa2f161738f41f4462dbba04f Reviewed-on: https://gerrit.instructure.com/137236 Tested-by: Jenkins Reviewed-by: Robert Lamb <rlamb@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com>
-
- Jan 08, 2018
-
-
James Williams authored
Change-Id: I0091e66fce502ded0a73d3136f31d032077423a5 Reviewed-on: https://gerrit.instructure.com/137151 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: James Williams <jamesw@instructure.com> QA-Review: James Williams <jamesw@instructure.com>
-
Transifreq authored
Change-Id: I17375dbecd7187ae14c82c0502d228d78f381cb0
-
- Jan 06, 2018
-
-
Dan Minkevitch authored
This reverts commit 2446326f. Change-Id: Ia8eeef32328a0abbcf890e0058c1a77d8563d247 Reviewed-on: https://gerrit.instructure.com/137136 Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Tyler Pickett <tpickett@instructure.com> Product-Review: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com> Tested-by: Rob Orton <rob@instructure.com>
-
Rob Orton authored
This reverts commit d64f44fe. Change-Id: Ibfd2d633f03fc04e9091f2241c12247fa4624b27 Reviewed-on: https://gerrit.instructure.com/137135 Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Tyler Pickett <tpickett@instructure.com> Reviewed-by: Venk Natarajan <vnatarajan@instructure.com> Product-Review: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com> Tested-by: Rob Orton <rob@instructure.com>
-
Transifreq authored
Change-Id: Iace1de24bb9861f9e06840fff23af283170a7f6b
-
Transifreq authored
Change-Id: I863dfae1de0e032ab26e5c3b9d9e965dc18744cc
-
Transifreq authored
Change-Id: Ib45d399c3996a6f6421cf7b3b447b9bae775961f
-
- Jan 03, 2018
-
-
Transifreq authored
Change-Id: I5fb6b4116cb7f7eefdeb4bd07599f0b54952693f
-
Transifreq authored
Change-Id: I31269b06b46d5c0821664dda7f292270b49bc0a4
-
Transifreq authored
Change-Id: I7bf5dbef5d5e2dd18417346cca19d9a65c8570fd
-
Transifreq authored
Change-Id: Ib958ab29fe7246517c52cac26d6bff812428fd07
-
- Dec 29, 2017
-
-
Clay Diffrient authored
closes CORE-809 Test Plan: - Add an equation to an RCE instance - There should not be a border around it Change-Id: I9ee6ba8937035c925857825b9afe94e37c8e0f52 Reviewed-on: https://gerrit.instructure.com/136637 Reviewed-by: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
-
Transifreq authored
Change-Id: I1c7cc3747ca22ab48c1a65d61eafa1884c78367a
-
Transifreq authored
Change-Id: I86b9c23366b91c18f3209c7d5dbc29eee3d99b70
-
Transifreq authored
Change-Id: Id2108d938bdd434878ab3720a0a76e060e8d692b
-
Transifreq authored
Change-Id: Ief2572a893f2f3385e90bcd5f7ceaec6deb07081
-
Transifreq authored
Change-Id: I48faef5005b99b4d40c3ddaa7151c541865f7451
-
Transifreq authored
Change-Id: I1598c782d4ccfdc53b96d5318cadaed32b55465a
-
Transifreq authored
Change-Id: I84566f1001b63e3e6928d003dbdde566f7e8e3ce
-
Transifreq authored
Change-Id: If48b61bc1a62d36cafa9683b2977012bba9a275e
-
Transifreq authored
Change-Id: I82fdfc5990cf6a831585c117a43a0e501056f315
-
Transifreq authored
Change-Id: I062efd043bfb34b5ea50ebdd980c194e450a65f5
-
Transifreq authored
Change-Id: Id401d5524d8dbd253384b048217844547baaf646
-
Transifreq authored
Change-Id: I7c9d1c1babd6f543b0210901ab63c05e0cdf4b3f
-
Transifreq authored
Change-Id: Id9600091fc0e56bc5c9abc6eee1ea556f791106b
-
Transifreq authored
Change-Id: Id9dce462ecb88aabcaca803b5fe984b5dbc52330
-