Skip to content
Snippets Groups Projects
  1. Jan 22, 2018
  2. Jan 19, 2018
  3. Jan 18, 2018
    • Jonathan Featherstone's avatar
      Add `sis_batch_id` to NOP fields for update · 4675be84
      Jonathan Featherstone authored
      `sis_batch_id` is updated even when no other field is changed on a sis
      batch import. Add `sis_batch_id` to the list of fields that will not
      trigger a live-events stream update.
      
      Test Plan:
        * Specs
      
      closes RECNVS-239
      
      Change-Id: I15f0b82dbbe1dc47885d3f2ce05932ba66f96c97
      Reviewed-on: https://gerrit.instructure.com/137963
      
      
      Tested-by: Jenkins
      Reviewed-by: default avatarRob Orton <rob@instructure.com>
      Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
      QA-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
    • Shahbaz Javeed's avatar
      fix SpeedGrader error in comments for concluded courses · 1e0edac4
      Shahbaz Javeed authored
      closes GRADE-756
      closes GRADE-759
      
      test plan:
      * Create a course with at least one assignment
      * Enroll two teachers (T1, T2) and two students in this course
      * Grade them using SpeedGrader and verify that works
      
      *** GRADE-756
      * As Teacher T1, open up SpeedGrader
      * In a separate tab or window, conclude the enrollment of teacher T1
      * Reload SpeedGrader as Teacher T1
      * Verify you do not see the comment textarea
      * Verify you do not see the students' grades or submission details
      * Verify SpeedGrader is functional even though you cannot grade anyone
        any more nor comment on their submission
      
      *** GRADE-759
      * As Teacher T2, open up SpeedGrader
      * Conclude the course in a separate window
      * Reload SpeedGrader
      * Verify you do not see the comment textarea
      * Verify you can see their grade but cannot edit it
      * Verify SpeedGrader is functional even though you cannot grade anyone
        any more nor comment on their submission
      
      (cherry picked from commit 556e698a)
      
      Change-Id: I08c330265120122ae2b151ad061c75739865ce9f
      Reviewed-on: https://gerrit.instructure.com/138101
      
      
      Reviewed-by: default avatarSpencer Olson <solson@instructure.com>
      Reviewed-by: default avatarDerek Bender <djbender@instructure.com>
      QA-Review: Indira Pai <ipai@instructure.com>
      Product-Review: Keith T. Garner <kgarner@instructure.com>
      Tested-by: default avatarKeith T. Garner <kgarner@instructure.com>
      1e0edac4
  4. Jan 16, 2018
    • Keith Garner's avatar
      add unposted scores to enrollment api for teachers/admins · c7c91f31
      Keith Garner authored
      This adds four additional fields (unposted_current_score,
      unposted_final_score, unposted_current_grade, unposted_final_grade) to
      the enrollment and users endpoints if the requesting user has either
      manage_grades or view_all_grades permissions.
      
      fixes GRADE-119
      
      test plan:
       - Have a course with a teacher and a student.
       - Have three assignments each worth 10 points, one muted (Assignment 1)
         and two not muted (Assignment 2 and Assignment 3).
       - As the teacher, grade the student 6/10 for Assignment 1 and 10/10
         for Assignment 2. Do not grade the student for Assignment 3.
       - As the teacher, make an API call to get the grades for the student:
      
         GET /api/v1/courses/:course_id/users/:student_id?include[]=enrollments
         Authorization: Bearer the-teacher-api-token
      
         Verify the grades on the enrollments in the response include the
         unposted_current_score, unposted_final_score,
         unposted_current_grade, and unposted_final_grade keys. Verify the
         unposted_current_score is 80.00, the unposted_final_score is 53.33,
         the unposted_current_grade is null, and the unposted_final_grade is
         null.
      
       - As the student, make an API call to get the grades for yourself:
      
         GET /api/v1/courses/:course_id/users/:student_id?include[]=enrollments
         Authorization: Bearer the-student-api-token
      
         Verify the grades on the enrollment in the response do not include
         the unposted_current_score, unposted_final_score,
         unposted_current_grade, or unposted_final_grade keys.
      
      Change-Id: Ibd14d0ed0a246f1cb8d16d7bc9ba0beb2680cba9
      Reviewed-on: https://gerrit.instructure.com/137213
      
      
      Reviewed-by: default avatarShahbaz Javeed <sjaveed@instructure.com>
      Tested-by: Jenkins
      QA-Review: Indira Pai <ipai@instructure.com>
      Reviewed-by: default avatarJeremy Neander <jneander@instructure.com>
      Product-Review: Matt Goodwin <mattg@instructure.com>
  5. Jan 11, 2018
    • Spencer Olson's avatar
      dropped assignments calculation respects ignore_muted · 4a9247a2
      Spencer Olson authored
      Fixes calculation of dropped assignments so that muted assignments are
      never considered for dropping when computing posted score. In addition,
      prevents score metadata for unposted grades from overwriting score
      metadata for posted grades.
      
      closes GRADE-763
      
      Test Plan:
      * Prerequisites: Have a course with at least one student and one
        teacher.
      
      1. Create two assignments in a course with the same point value and
         place them in the same assignment group.
      2. Set up a grading rule to drop the lowest 1 score.
      3. Mute one of the assignments.
      4. Have the teacher enter a score of zero for the muted assignment.
      5. Have the teacher enter a positive score for the second assignment.
      6. Check the teacher interaction report and verify there is
         no page error.
      
      Change-Id: I5015ef73bb40bb0a45a21f166fa6b9ff146002da
      Reviewed-on: https://gerrit.instructure.com/137538
      
      
      Reviewed-by: default avatarKeith T. Garner <kgarner@instructure.com>
      Tested-by: Jenkins
      QA-Review: Indira Pai <ipai@instructure.com>
      Product-Review: Keith T. Garner <kgarner@instructure.com>
  6. Jan 10, 2018
  7. Jan 09, 2018
  8. Jan 08, 2018
  9. Jan 06, 2018
  10. Jan 03, 2018
  11. Dec 29, 2017