Skip to content
Snippets Groups Projects
  1. Feb 17, 2018
  2. Feb 16, 2018
    • Jacob Fugal's avatar
      fix upload initiator that didn't have no_redirect · b31bd88a
      Jacob Fugal authored
      fixes RECNVS-318
      
      this upload location doesn't go through uploadFile so didn't get caught
      by the previous fix.
      
      (not sure how this slipped through the test plan on the previous fix;
      it's test plan included this one's, and I ran it personally then as did
      QA. yet this test plan fails for me now on master and passes with this
      commit.)
      
      test-plan:
      - be configured to use S3 for file uploads
      - go to a course's settings and export a zip file
      - go to the course's settings and attempt to import the same zip file;
        upload should not fail
      
      Change-Id: I04386937c23795a86771fbc459ed638c80801cd5
      Reviewed-on: https://gerrit.instructure.com/141209
      
      
      Reviewed-by: default avatarJonathan Featherstone <jfeatherstone@instructure.com>
      Tested-by: Jenkins
      QA-Review: Collin Parrish <cparrish@instructure.com>
      Product-Review: Jacob Fugal <jacob@instructure.com>
    • Transifreq's avatar
      update nn translation · 140f34d3
      Transifreq authored
      Change-Id: Ib9e6c333b8ad7f706e7b9bbe3b04f5e96194036f
      140f34d3
    • Transifreq's avatar
      update en-GB translation · 18b20394
      Transifreq authored
      Change-Id: I26b4f16318cebe875504638aaf94dc526998bb10
      18b20394
  3. Feb 15, 2018
    • Steven Burnett's avatar
      allow focusing on course autcomplete feature · 3c0b3b4e
      Steven Burnett authored
      fixes COMMS-860
      
      Test Plan:
      - click the inbox tab on the left (or go to the conversations page)
      - navigate to the compose message icon with only your keyboard
      - click said icon
      - navigate to the first element in the modal (course group filter)
      - notice that you get focus
      - notice you can type a message
      - navigate to the rest of the elements on the modal
      - notice you can type stuff in them
      - notice focus is still trapped in modal
      - test with screenreader to make sure things are read correctly
      
      Change-Id: Ie01c496deae0e88d2b71fac81d991e7c45203a3f
      Reviewed-on: https://gerrit.instructure.com/141084
      
      
      Reviewed-by: default avatarLandon Gilbert-Bland <lbland@instructure.com>
      Reviewed-by: default avatarAaron Kc Hsu <ahsu@instructure.com>
      QA-Review: Venk Natarajan <vnatarajan@instructure.com>
      Tested-by: Jenkins
      Product-Review: Steven Burnett <sburnett@instructure.com>
    • Jacob Fugal's avatar
      force no_redirect on file uploads · d8b66da3
      Jacob Fugal authored
      fixes RECNVS-318
      
      with the new shape of file uploads javascript, we need that to always be
      true. the only two places it wasn't already being passed as true were
      file upload questions and content migrations. both of these fail with
      the same symptoms before this commit and work after this commit.
      
      test-plan:
      - be configured to use S3 for file uploads
      - content migrations:
        - go to a course's settings and export a zip file
        - go to the course's settings and attempt to import the same zip file;
          upload should not fail
      - file upload questions:
        - have a quiz with a file upload type question
        - as a student, take the quiz and attempt to upload a file; upload
          should not fail
      
      Change-Id: Ibc01eb9b25f6d74221f26b2d80baf3f770111685
      Reviewed-on: https://gerrit.instructure.com/140929
      
      
      Tested-by: Jenkins
      Reviewed-by: default avatarJonathan Featherstone <jfeatherstone@instructure.com>
      QA-Review: Collin Parrish <cparrish@instructure.com>
      Product-Review: Jacob Fugal <jacob@instructure.com>
      d8b66da3
    • Venk Natarajan's avatar
      Don't show courses that aren't ready yet. · 9d09e731
      Venk Natarajan authored
      Make sure we filter out not-started courses if needed.
      
      Fixes COMMS-861
      
      Test Plan:
      * Have a fully enrolled student and teacher.
      * Make a course start in the future, check *all three*
        settings restricting participation and viewabiltiy to
        course dates in the course settings page.
      * As the teacher, publish the course, and add a student
        to it.
      * As the student go to inbox, and you should no longer
        see a funny blank spot in the autocompletes in the
        conversations index or the message compose.
      
      Change-Id: I0fe24e260349aa26821861c33a610f39b7e4e80f
      Reviewed-on: https://gerrit.instructure.com/141037
      
      
      Tested-by: Jenkins
      Reviewed-by: default avatarLandon Gilbert-Bland <lbland@instructure.com>
      Reviewed-by: default avatarSteven Burnett <sburnett@instructure.com>
      QA-Review: KC Naegle <knaegle@instructure.com>
      Product-Review: Venk Natarajan <vnatarajan@instructure.com>
      9d09e731
    • Jacob Fugal's avatar
      only display instfs pixel on enabled accounts · 2211aaba
      Jacob Fugal authored
      fixes RECNVS-319
      
      test-plan:
      - have inst-fs configured with REQUIRE_AUTH=true
      - have canvas _configured_ for inst-fs, but inst-fs not enabled
      - in safari:
        - delete any inst-fs cookies and log out of canvas
        - log in
          - inst-fs login pixel should not be displayed (verify with network
            request log in browser)
          - no inst-fs cookie should have been created
        - enable inst-fs
        - refresh the page
          - inst-fs login pixel should be displayed
          - inst-fs cookie should have been created
      
      Change-Id: Idecb926e8f17b5c29948b38fd8b5afc6c298d78a
      Reviewed-on: https://gerrit.instructure.com/140938
      
      
      Reviewed-by: default avatarAndrew Huff <ahuff@instructure.com>
      Tested-by: Jenkins
      QA-Review: Collin Parrish <cparrish@instructure.com>
      Product-Review: Cody Cutrer <cody@instructure.com>
      2211aaba
  4. Feb 14, 2018