- Feb 17, 2018
-
-
Cody Cutrer authored
Change-Id: Ie7128468011f62effd5d90dcb6be0ca30003890d
-
Cody Cutrer authored
Change-Id: I4fcd717c791594ff4a3167ee2d17a307b2fbc980
-
Rob Orton authored
-
Transifreq authored
Change-Id: I7718bc8acd34f53877d109b7fbfab89be572ac88
-
Transifreq authored
Change-Id: I7a8d092ef5b6a7eaf65306febe75b8df24303e3c
-
Transifreq authored
Change-Id: Ice858516c89b1ac596a620bd01cc34e1cc1cd890
-
Transifreq authored
Change-Id: I722c1804c0546b3d46b5c637b3e5bee6784fc590
-
Transifreq authored
Change-Id: Iabf4ebd609f24d1c411fc2198cc8a642c47cf3dd
-
Transifreq authored
Change-Id: I3a47c1c18d7af046e9ff90ea9ee13fdfe550f4b9
-
Transifreq authored
Change-Id: I00bf8337b4758afc627e51749ec33e3a7de978e7
-
Transifreq authored
Change-Id: I8b8f50506af235812846fe0c82f0fe500662cb9e
-
Transifreq authored
Change-Id: I520f98a2f4e568d2be2854be7d0f7b704a3793fa
-
Transifreq authored
Change-Id: I9a4e523b9756afa43837bc0d2512f642a0303957
-
Transifreq authored
Change-Id: Idebdf6dd0662a3ccb729c42b3b28fc64c4bb301a
-
Transifreq authored
Change-Id: I3762c5d5b7b051f393410739ff0c284ab8014a58
-
Transifreq authored
Change-Id: I4779334eb708620983d6a3bd0bb3838452e23e4a
-
Transifreq authored
Change-Id: I9a5d5638ffff6922b25930e2baa666fe7b5ff5a2
-
Transifreq authored
Change-Id: I716c6947f2be6fc6a5fe5e87e0ff6a25776eddc2
-
Transifreq authored
Change-Id: Ia13941a2e934c5c5a3696b98db5f2bcf58a11de6
-
Transifreq authored
Change-Id: Ic74970fc442bebc9f00b6cd662a3549b21e0a8b8
-
Transifreq authored
Change-Id: I7b4361483e716e52ec4aa13b7b18e4999858132e
-
Transifreq authored
Change-Id: I1f6c1ab0bec5dafeea5ed834c7f65b4f690f6589
-
Transifreq authored
Change-Id: I8abdae7c3b849c3fb59f838c8a560337ff2f7cf1
-
Transifreq authored
Change-Id: Ic7a5e1160666815ce3aea86932a0514365cd16c9
-
Transifreq authored
Change-Id: If0867318b09f8e8c7c2bb8fde853728d8555915d
-
Transifreq authored
Change-Id: I306174c72f94e8d3d94fa46817a2805bd56c4277
-
Keith Garner authored
This reverts commit d7643ad2. Change-Id: I8692c0674422c5061988212467672788555a9030 Reviewed-on: https://gerrit.instructure.com/141318 Reviewed-by: Nathan Mills <nathanm@instructure.com> Tested-by: Keith T. Garner <kgarner@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com> QA-Review: Keith T. Garner <kgarner@instructure.com>
-
- Feb 16, 2018
-
-
Jacob Fugal authored
fixes RECNVS-318 this upload location doesn't go through uploadFile so didn't get caught by the previous fix. (not sure how this slipped through the test plan on the previous fix; it's test plan included this one's, and I ran it personally then as did QA. yet this test plan fails for me now on master and passes with this commit.) test-plan: - be configured to use S3 for file uploads - go to a course's settings and export a zip file - go to the course's settings and attempt to import the same zip file; upload should not fail Change-Id: I04386937c23795a86771fbc459ed638c80801cd5 Reviewed-on: https://gerrit.instructure.com/141209 Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> Tested-by: Jenkins QA-Review: Collin Parrish <cparrish@instructure.com> Product-Review: Jacob Fugal <jacob@instructure.com>
-
Transifreq authored
Change-Id: Ib9e6c333b8ad7f706e7b9bbe3b04f5e96194036f
-
Transifreq authored
Change-Id: I26b4f16318cebe875504638aaf94dc526998bb10
-
- Feb 15, 2018
-
-
Steven Burnett authored
fixes COMMS-860 Test Plan: - click the inbox tab on the left (or go to the conversations page) - navigate to the compose message icon with only your keyboard - click said icon - navigate to the first element in the modal (course group filter) - notice that you get focus - notice you can type a message - navigate to the rest of the elements on the modal - notice you can type stuff in them - notice focus is still trapped in modal - test with screenreader to make sure things are read correctly Change-Id: Ie01c496deae0e88d2b71fac81d991e7c45203a3f Reviewed-on: https://gerrit.instructure.com/141084 Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com> Reviewed-by: Aaron Kc Hsu <ahsu@instructure.com> QA-Review: Venk Natarajan <vnatarajan@instructure.com> Tested-by: Jenkins Product-Review: Steven Burnett <sburnett@instructure.com>
-
Jacob Fugal authored
fixes RECNVS-318 with the new shape of file uploads javascript, we need that to always be true. the only two places it wasn't already being passed as true were file upload questions and content migrations. both of these fail with the same symptoms before this commit and work after this commit. test-plan: - be configured to use S3 for file uploads - content migrations: - go to a course's settings and export a zip file - go to the course's settings and attempt to import the same zip file; upload should not fail - file upload questions: - have a quiz with a file upload type question - as a student, take the quiz and attempt to upload a file; upload should not fail Change-Id: Ibc01eb9b25f6d74221f26b2d80baf3f770111685 Reviewed-on: https://gerrit.instructure.com/140929 Tested-by: Jenkins Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> QA-Review: Collin Parrish <cparrish@instructure.com> Product-Review: Jacob Fugal <jacob@instructure.com>
-
Venk Natarajan authored
Make sure we filter out not-started courses if needed. Fixes COMMS-861 Test Plan: * Have a fully enrolled student and teacher. * Make a course start in the future, check *all three* settings restricting participation and viewabiltiy to course dates in the course settings page. * As the teacher, publish the course, and add a student to it. * As the student go to inbox, and you should no longer see a funny blank spot in the autocompletes in the conversations index or the message compose. Change-Id: I0fe24e260349aa26821861c33a610f39b7e4e80f Reviewed-on: https://gerrit.instructure.com/141037 Tested-by: Jenkins Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: KC Naegle <knaegle@instructure.com> Product-Review: Venk Natarajan <vnatarajan@instructure.com>
-
Jacob Fugal authored
fixes RECNVS-319 test-plan: - have inst-fs configured with REQUIRE_AUTH=true - have canvas _configured_ for inst-fs, but inst-fs not enabled - in safari: - delete any inst-fs cookies and log out of canvas - log in - inst-fs login pixel should not be displayed (verify with network request log in browser) - no inst-fs cookie should have been created - enable inst-fs - refresh the page - inst-fs login pixel should be displayed - inst-fs cookie should have been created Change-Id: Idecb926e8f17b5c29948b38fd8b5afc6c298d78a Reviewed-on: https://gerrit.instructure.com/140938 Reviewed-by: Andrew Huff <ahuff@instructure.com> Tested-by: Jenkins QA-Review: Collin Parrish <cparrish@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
-
- Feb 14, 2018
-
-
Rob Orton authored
fixes CORE-1009 test plan - run a sis import - it should show change_sis_ids count Change-Id: I4d7e897e528df22991cca57bb6fcdd21c4d54663 Reviewed-on: https://gerrit.instructure.com/140959 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
-
wdransfield authored
Closes PLAT-3130 Test Plan: - Verify all LTI launch iframes now have the following value for the allow attribute: 'geolocation *; microphone *; camera *; midi *; encrypted-media *' Change-Id: I4d05d59a6ad9686ba8750b7b181bafb2b1bd3f5d Reviewed-on: https://gerrit.instructure.com/140910 Tested-by: Jenkins Reviewed-by: Stewie aka Nicholas Stewart <nstewart@instructure.com> QA-Review: August Thornton <august@instructure.com> Product-Review: Weston Dransfield <wdransfield@instructure.com>
-
Anju Reddy authored
This reverts commit 09a6cd78. closes GRADE-851 refs GRADE-32 test plan: - Ensure that assignments can again be created with GPA type or can switch to it. Change-Id: I1f56c99f11bd8643d3d73352c15523152a4341e3 Reviewed-on: https://gerrit.instructure.com/140842 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> QA-Review: Derek Bender <djbender@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
-
Brent Burgoyne authored
fixes CORE-869 test plan: - test with production webpack build for js translations - change language to french - go to an rce - open the equation editor - all tabs should work - spot test in other languages mentioned in the ticket Change-Id: Ie9955e88f2411958649a06c93682c3c67a64ddc6 Reviewed-on: https://gerrit.instructure.com/140652 Reviewed-by: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
-
Cody Cutrer authored
also, allow explain to take a block, so you can run it for any query (i.e. User.explain { something_complicated.count }) Change-Id: Ie724215ed1f1a45e7bec49a6deb960d09876bf03 Reviewed-on: https://gerrit.instructure.com/140615 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-
Cody Cutrer authored
fixes CORE-1008 test plan: * configure redis.yml to point to cache_store * log in via CAS * it shouldn't go into a redirect loop Change-Id: I8dd278d3d1ba75f0a4c9336bc5b9603f09f4ca53 Reviewed-on: https://gerrit.instructure.com/140913 Reviewed-by: Rob Orton <rob@instructure.com> Tested-by: Jenkins Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
-