Skip to content
Snippets Groups Projects
Unverified Commit 05dbd832 authored by Kyle McCormick's avatar Kyle McCormick Committed by GitHub
Browse files

fix: streak celebration feature should require progress milestones (#26922)

In commit 9b37e7d0, the logic of
`streak_celebration_is_active` was accidentally
changed such that it no longer checks the
Progress Milestones waffle flag.
This commit fixes that.

Note: This also adds in a transitive check to
`courseware_mfe_is_active`,
which makes sense for Streak Celebration
and should not have any functional impact.
parent e624a8f4
No related branches found
Tags release-2021-03-09-11.59
No related merge requests found
......@@ -205,6 +205,6 @@ def courseware_mfe_progress_milestones_are_active(course_key):
def streak_celebration_is_active(course_key):
return (
courseware_mfe_is_active(course_key) and
courseware_mfe_progress_milestones_are_active(course_key) and
COURSEWARE_MICROFRONTEND_PROGRESS_MILESTONES_STREAK_CELEBRATION.is_enabled(course_key)
)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment