Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
edx-platform-release
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hsin-Yu Chien
edx-platform-release
Commits
06e04eff
Commit
06e04eff
authored
4 years ago
by
stvn
Browse files
Options
Downloads
Patches
Plain Diff
Bucket users regardless of enrollment in courseware MFE experiment
parent
e1bd970b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
common/djangoapps/student/signals/receivers.py
+1
-1
1 addition, 1 deletion
common/djangoapps/student/signals/receivers.py
lms/djangoapps/courseware/views/index.py
+2
-2
2 additions, 2 deletions
lms/djangoapps/courseware/views/index.py
with
3 additions
and
3 deletions
common/djangoapps/student/signals/receivers.py
+
1
−
1
View file @
06e04eff
...
...
@@ -59,7 +59,7 @@ def create_course_enrollment_celebration(sender, instance, created, **kwargs):
# The UI for celebrations is only supported on the MFE right now, so don't turn on
# celebrations unless this enrollment's course is MFE-enabled.
if
not
REDIRECT_TO_COURSEWARE_MICROFRONTEND
.
is_enabled
(
instance
.
course_id
):
if
not
REDIRECT_TO_COURSEWARE_MICROFRONTEND
.
is_enabled
():
return
try
:
...
...
This diff is collapsed.
Click to expand it.
lms/djangoapps/courseware/views/index.py
+
2
−
2
View file @
06e04eff
...
...
@@ -198,7 +198,7 @@ class CoursewareIndex(View):
if
getattr
(
self
.
section
,
'
is_time_limited
'
,
False
):
return
# ALLOW: when flag set for course
if
REDIRECT_TO_COURSEWARE_MICROFRONTEND
.
is_enabled
(
self
.
course_key
):
if
REDIRECT_TO_COURSEWARE_MICROFRONTEND
.
is_enabled
():
raise
Redirect
(
self
.
microfrontend_url
)
@property
...
...
@@ -654,7 +654,7 @@ def show_courseware_mfe_link(user, staff_access, course_key):
# course team preview CourseWaffleFlag for this course *or* if we've turned
# on the redirect for your students.
mfe_enabled_for_course_team
=
COURSEWARE_MICROFRONTEND_COURSE_TEAM_PREVIEW
.
is_enabled
(
course_key
)
mfe_experiment_enabled_for_course
=
REDIRECT_TO_COURSEWARE_MICROFRONTEND
.
is_experiment_on
(
course_key
)
mfe_experiment_enabled_for_course
=
REDIRECT_TO_COURSEWARE_MICROFRONTEND
.
is_experiment_on
()
if
staff_access
and
(
mfe_enabled_for_course_team
or
mfe_experiment_enabled_for_course
):
return
True
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment