Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
edx-platform-release
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hsin-Yu Chien
edx-platform-release
Commits
2935578b
Unverified
Commit
2935578b
authored
7 years ago
by
Harry Rein
Committed by
GitHub
7 years ago
Browse files
Options
Downloads
Plain Diff
Merge pull request #17294 from edx/HarryRein/a11y-footer-upgrade-div
Ensuring div and not button inside link tag for a11y.
parents
d716d740
98b8eaf2
Loading
Loading
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
lms/static/sass/features/_course-sock.scss
+6
-0
6 additions, 0 deletions
lms/static/sass/features/_course-sock.scss
openedx/features/course_experience/templates/course_experience/course-sock-fragment.html
+2
-2
2 additions, 2 deletions
...nce/templates/course_experience/course-sock-fragment.html
with
8 additions
and
2 deletions
lms/static/sass/features/_course-sock.scss
+
6
−
0
View file @
2935578b
...
...
@@ -101,6 +101,12 @@
color
:
theme-color
(
"inverse"
);
background-image
:
none
;
box-shadow
:
none
;
cursor
:
pointer
;
&
:hover
{
background-color
:
theme-color
(
"inverse"
);
color
:
theme-color
(
"success"
);
}
@media
(
max-width
:
960px
)
{
&
{
...
...
This diff is collapsed.
Click to expand it.
openedx/features/course_experience/templates/course_experience/course-sock-fragment.html
+
2
−
2
View file @
2935578b
...
...
@@ -59,9 +59,9 @@ from openedx.features.course_experience import DISPLAY_COURSE_SOCK_FLAG
% endif
<img
class=
"mini-cert"
alt=
"Example Certificate Image"
src=
"${static.url('course_experience/images/verified-cert.png')}"
/>
<a
href=
"${upgrade_url}"
>
<
button
type=
"button"
class=
"btn btn-upgrade stuck-top focusable action-upgrade-certificate"
data-creative=
"original_sock"
data-position=
"sock"
>
<
div
class=
"btn btn-upgrade stuck-top focusable action-upgrade-certificate"
data-creative=
"original_sock"
data-position=
"sock"
>
${Text(_('Upgrade ({course_price})')).format(course_price=HTML(course_price))}
</
button
>
</
div
>
</a>
</div>
</div>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment