fix: update shift dates logic to ignore missed_deadlines

We ignore the missed_deadlines because this endpoint is used in the Learning MFE for
learners who have remaining attempts on a problem and reset their due dates in order to
submit additional attempts. This can apply for 'completed' (submitted) content that would
not be marked as past_due

common/djangoapps/util/views.py

@@ -207,8 +207,12 @@ def reset_course_deadlines(request):
         has_access(request.user, 'staff', course_key)
     )
 
-    missed_deadlines, missed_gated_content = dates_banner_should_display(course_key, user)
-    if missed_deadlines and not missed_gated_content:
+    # We ignore the missed_deadlines because this endpoint could be used for
+    # learners who have remaining attempts on a problem and reset their due dates in order to
+    # submit additional attempts. This can apply for 'completed' (submitted) content that would
+    # not be marked as past_due
+    _missed_deadlines, missed_gated_content = dates_banner_should_display(course_key, user)
+    if not missed_gated_content:
         reset_self_paced_schedule(user, course_key)
 
     referrer = request.META.get('HTTP_REFERER')

openedx/features/course_experience/api/v1/tests/test_views.py

@@ -30,14 +30,23 @@ class ResetCourseDeadlinesViewTests(EventTestMixin, BaseCourseHomeTests, Masquer
 
     def test_reset_deadlines(self):
         CourseEnrollment.enroll(self.user, self.course.id, CourseMode.VERIFIED)
-        # Test correct post body
-        response = self.client.post(reverse('course-experience-reset-course-deadlines'), {'course_key': self.course.id})
-        assert response.status_code == 200
         # Test body with incorrect body param (course_key is required)
         response = self.client.post(reverse('course-experience-reset-course-deadlines'), {'course': self.course.id})
         assert response.status_code == 400
         self.assert_no_events_were_emitted()
 
+        # Test correct post body
+        response = self.client.post(reverse('course-experience-reset-course-deadlines'), {'course_key': self.course.id})
+        assert response.status_code == 200
+        self.assert_event_emitted(
+            'edx.ui.lms.reset_deadlines.clicked',
+            courserun_key=str(self.course.id),
+            is_masquerading=False,
+            is_staff=False,
+            org_key=self.course.org,
+            user_id=self.user.id,
+        )
+
     def test_reset_deadlines_with_masquerade(self):
         """ Staff users should be able to masquerade as a learner and reset the learner's schedule """
         course = CourseFactory.create(self_paced=True)
@@ -54,9 +63,7 @@ class ResetCourseDeadlinesViewTests(EventTestMixin, BaseCourseHomeTests, Masquer
         self.switch_to_staff()
         self.update_masquerade(course=course, username=student_username)
 
-        with patch('openedx.features.course_experience.api.v1.views.dates_banner_should_display',
-                   return_value=(True, False)):
-            self.client.post(reverse('course-experience-reset-course-deadlines'), {'course_key': course.id})
+        self.client.post(reverse('course-experience-reset-course-deadlines'), {'course_key': course.id})
         updated_schedule = Schedule.objects.get(id=student_enrollment.schedule.id)
         assert updated_schedule.start_date.date() == datetime.datetime.today().date()
         updated_staff_schedule = Schedule.objects.get(id=staff_enrollment.schedule.id)

openedx/features/course_experience/api/v1/views.py

@@ -73,8 +73,12 @@ def reset_course_deadlines(request):
             has_access(request.user, 'staff', course_key)
         )
 
-        missed_deadlines, missed_gated_content = dates_banner_should_display(course_key, user)
-        if missed_deadlines and not missed_gated_content:
+        # We ignore the missed_deadlines because this endpoint is used in the Learning MFE for
+        # learners who have remaining attempts on a problem and reset their due dates in order to
+        # submit additional attempts. This can apply for 'completed' (submitted) content that would
+        # not be marked as past_due
+        _missed_deadlines, missed_gated_content = dates_banner_should_display(course_key, user)
+        if not missed_gated_content:
             reset_self_paced_schedule(user, course_key)
 
             course_overview = course_detail(request, user.username, course_key)
@@ -102,9 +106,9 @@ def reset_course_deadlines(request):
             'link_text': _('View all dates'),
             'message': _('Deadlines successfully reset.'),
         })
-    except Exception as e:
-        log.exception(e)
-        raise UnableToResetDeadlines  # lint-amnesty, pylint: disable=raise-missing-from
+    except Exception as reset_deadlines_exception:
+        log.exception('Error occurred while trying to reset deadlines!')
+        raise UnableToResetDeadlines from reset_deadlines_exception
 
 
 class CourseDeadlinesMobileView(RetrieveAPIView):