Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
edx-platform-release
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hsin-Yu Chien
edx-platform-release
Commits
3bbdd2f4
Commit
3bbdd2f4
authored
11 years ago
by
Ned Batchelder
Browse files
Options
Downloads
Patches
Plain Diff
No need to invoke classmethods through self.__class__
parent
a3525875
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
common/lib/xmodule/xmodule/xml_module.py
+2
-2
2 additions, 2 deletions
common/lib/xmodule/xmodule/xml_module.py
lms/lib/comment_client/models.py
+2
-2
2 additions, 2 deletions
lms/lib/comment_client/models.py
with
4 additions
and
4 deletions
common/lib/xmodule/xmodule/xml_module.py
+
2
−
2
View file @
3bbdd2f4
...
...
@@ -378,7 +378,7 @@ class XmlDescriptor(XModuleDescriptor):
# Get the definition
xml_object
=
self
.
definition_to_xml
(
resource_fs
)
self
.
__class__
.
clean_metadata_from_xml
(
xml_object
)
self
.
clean_metadata_from_xml
(
xml_object
)
# Set the tag so we get the file path right
xml_object
.
tag
=
self
.
category
...
...
@@ -401,7 +401,7 @@ class XmlDescriptor(XModuleDescriptor):
if
self
.
export_to_file
():
# Write the definition to a file
url_path
=
name_to_pathname
(
self
.
url_name
)
filepath
=
self
.
_
_class__
.
_
format_filepath
(
self
.
category
,
url_path
)
filepath
=
self
.
_format_filepath
(
self
.
category
,
url_path
)
resource_fs
.
makedir
(
os
.
path
.
dirname
(
filepath
),
recursive
=
True
,
allow_recreate
=
True
)
with
resource_fs
.
open
(
filepath
,
'
w
'
)
as
file
:
file
.
write
(
etree
.
tostring
(
xml_object
,
pretty_print
=
True
,
encoding
=
'
utf-8
'
))
...
...
This diff is collapsed.
Click to expand it.
lms/lib/comment_client/models.py
+
2
−
2
View file @
3bbdd2f4
...
...
@@ -91,7 +91,7 @@ class Model(object):
pass
def
save
(
self
):
self
.
__class__
.
before_save
(
self
)
self
.
before_save
(
self
)
if
self
.
id
:
# if we have id already, treat this as an update
url
=
self
.
url
(
action
=
'
put
'
,
params
=
self
.
attributes
)
response
=
perform_request
(
'
put
'
,
url
,
self
.
updatable_attributes
())
...
...
@@ -100,7 +100,7 @@ class Model(object):
response
=
perform_request
(
'
post
'
,
url
,
self
.
initializable_attributes
())
self
.
retrieved
=
True
self
.
update_attributes
(
**
response
)
self
.
__class__
.
after_save
(
self
)
self
.
after_save
(
self
)
def
delete
(
self
):
url
=
self
.
url
(
action
=
'
delete
'
,
params
=
self
.
attributes
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment