Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
edx-platform-release
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hsin-Yu Chien
edx-platform-release
Commits
3db3403f
Unverified
Commit
3db3403f
authored
5 years ago
by
Jeremy Bowman
Committed by
GitHub
5 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix mock transcript responses BOM-918 (#22020)
parent
b4d36383
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
cms/djangoapps/contentstore/tests/test_transcripts_utils.py
+5
-5
5 additions, 5 deletions
cms/djangoapps/contentstore/tests/test_transcripts_utils.py
with
5 additions
and
5 deletions
cms/djangoapps/contentstore/tests/test_transcripts_utils.py
+
5
−
5
View file @
3db3403f
...
...
@@ -236,7 +236,7 @@ class TestDownloadYoutubeSubs(TestYoutubeSubsBase):
self
.
clear_sub_content
(
good_youtube_sub
)
with
patch
(
'
xmodule.video_module.transcripts_utils.requests.get
'
)
as
mock_get
:
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response
,
content
=
response
)
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response
,
content
=
response
.
encode
(
'
utf-8
'
)
)
# Check transcripts_utils.GetTranscriptsFromYouTubeException not thrown
transcripts_utils
.
download_youtube_subs
(
good_youtube_sub
,
self
.
course
,
settings
)
...
...
@@ -303,7 +303,7 @@ class TestDownloadYoutubeSubs(TestYoutubeSubsBase):
<track id=
"
0
"
name=
"
Custom1
"
lang_code=
"
en-GB
"
/>
</transcript_list>
"""
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response_success
,
content
=
response_success
)
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response_success
,
content
=
response_success
.
encode
(
'
utf-8
'
)
)
transcript_name
=
transcripts_utils
.
youtube_video_transcript_name
(
youtube_text_api
)
self
.
assertEqual
(
transcript_name
,
'
Custom
'
)
...
...
@@ -316,7 +316,7 @@ class TestDownloadYoutubeSubs(TestYoutubeSubsBase):
youtube_text_api
=
copy
.
deepcopy
(
settings
.
YOUTUBE
[
'
TEXT_API
'
])
youtube_text_api
[
'
params
'
][
'
v
'
]
=
'
dummy_video_id
'
response_success
=
"
<transcript_list></transcript_list>
"
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response_success
,
content
=
response_success
)
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response_success
,
content
=
response_success
.
encode
(
'
utf-8
'
)
)
transcript_name
=
transcripts_utils
.
youtube_video_transcript_name
(
youtube_text_api
)
self
.
assertIsNone
(
transcript_name
)
...
...
@@ -335,7 +335,7 @@ class TestDownloadYoutubeSubs(TestYoutubeSubsBase):
<track id=
"
0
"
name=
"
Custom1
"
lang_code=
"
en-GB
"
/>
</transcript_list>
"""
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response_success
,
content
=
response_success
)
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response_success
,
content
=
response_success
.
encode
(
'
utf-8
'
)
)
transcript_name
=
transcripts_utils
.
youtube_video_transcript_name
(
youtube_text_api
)
self
.
assertIsNone
(
transcript_name
)
...
...
@@ -550,7 +550,7 @@ class TestYoutubeTranscripts(unittest.TestCase):
}
youtube_id
=
'
good_youtube_id
'
with
patch
(
'
xmodule.video_module.transcripts_utils.requests.get
'
)
as
mock_get
:
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response
,
content
=
response
)
mock_get
.
return_value
=
Mock
(
status_code
=
200
,
text
=
response
,
content
=
response
.
encode
(
'
utf-8
'
)
)
transcripts
=
transcripts_utils
.
get_transcripts_from_youtube
(
youtube_id
,
settings
,
translation
)
self
.
assertEqual
(
transcripts
,
expected_transcripts
)
mock_get
.
assert_called_with
(
'
http://video.google.com/timedtext
'
,
params
=
{
'
lang
'
:
'
en
'
,
'
v
'
:
'
good_youtube_id
'
})
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment