Skip to content
Snippets Groups Projects
Unverified Commit 58971614 authored by Awais Jibran's avatar Awais Jibran Committed by GitHub
Browse files

refactor: use q objects when fetching user using an identifier (#26726)

* refactor: use q objects when fetching user using an identifier #26683

* Nit
parent eb98d7fa
No related branches found
No related tags found
No related merge requests found
...@@ -5,7 +5,8 @@ import copy ...@@ -5,7 +5,8 @@ import copy
import logging import logging
from django.contrib.auth import get_user_model from django.contrib.auth import get_user_model
from django.core.management.base import BaseCommand from django.core.management.base import BaseCommand, CommandError
from django.db.models import Q
from opaque_keys.edx.keys import CourseKey from opaque_keys.edx.keys import CourseKey
from lms.djangoapps.badges.events.course_complete import get_completion_badge from lms.djangoapps.badges.events.course_complete import get_completion_badge
...@@ -75,10 +76,10 @@ class Command(BaseCommand): ...@@ -75,10 +76,10 @@ class Command(BaseCommand):
course_id = CourseKey.from_string(options['course']) course_id = CourseKey.from_string(options['course'])
user = options['username'] user = options['username']
if '@' in user: kwargs = (Q(username=user) | Q(email=user)) & Q(courseenrollment__course_id=course_id)
student = User.objects.get(email=user, courseenrollment__course_id=course_id) student = User.objects.filter(kwargs).first()
else: if not student:
student = User.objects.get(username=user, courseenrollment__course_id=course_id) raise CommandError(f"User {user} does not exist.")
course = modulestore().get_course(course_id, depth=2) course = modulestore().get_course(course_id, depth=2)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment