Merge pull request #20056 from cpennington/fbe/access-expiry-no-binning

Don't use multiple bins per course when sending Access Expiry Emails

openedx/features/course_duration_limits/resolvers.py

@@ -27,7 +27,7 @@ from .models import CourseDurationLimitConfig
 LOG = logging.getLogger(__name__)
 
 DEFAULT_NUM_BINS = 24
-EXPIRY_REMINDER_NUM_BINS = 24
+EXPIRY_REMINDER_NUM_BINS = 1
 EXPIRY_REMINDER_LOG_PREFIX = 'FBE Expiry Reminder'
 
 

openedx/features/course_duration_limits/tasks.py

@@ -75,22 +75,20 @@ class CourseDurationLimitMessageBaseTask(LoggedTask):
                 continue
 
             target_date = current_date + datetime.timedelta(days=day_offset)
-            for bin_num in range(cls.num_bins):
-                task_args = (
-                    site.id,
-                    unicode(course_key),
-                    serialize(target_date),
-                    day_offset,
-                    bin_num,
-                    override_recipient_email,
-                )
-                cls().apply_async(
-                    task_args,
-                    retry=False,
-                )
+            task_args = (
+                site.id,
+                unicode(course_key),
+                serialize(target_date),
+                day_offset,
+                override_recipient_email,
+            )
+            cls().apply_async(
+                task_args,
+                retry=False,
+            )
 
     def run(  # pylint: disable=arguments-differ
-        self, site_id, course_key_str, target_day_str, day_offset, bin_num, override_recipient_email=None,
+        self, site_id, course_key_str, target_day_str, day_offset, override_recipient_email=None,
     ):
         try:
             site = Site.objects.select_related('configuration').get(id=site_id)