Address @brianhw review comments
* Fix open redirect vulnerability * Add Logging To AUDIT_LOG : Note I had to change existing tests that mocked AUDIT_LOG with this * Use external_auth.views.SHIBBOLETH_DOMAIN_PREFIX in student.views * Add a bunch of documentation * PEP8 / Pylint
Showing
- common/djangoapps/external_auth/tests/test_helper.py 29 additions, 0 deletionscommon/djangoapps/external_auth/tests/test_helper.py
- common/djangoapps/external_auth/tests/test_shib.py 5 additions, 6 deletionscommon/djangoapps/external_auth/tests/test_shib.py
- common/djangoapps/external_auth/views.py 32 additions, 14 deletionscommon/djangoapps/external_auth/views.py
- common/djangoapps/student/tests/test_login.py 29 additions, 22 deletionscommon/djangoapps/student/tests/test_login.py
- common/djangoapps/student/views.py 22 additions, 13 deletionscommon/djangoapps/student/views.py
- lms/envs/common.py 2 additions, 0 deletionslms/envs/common.py
- lms/templates/login.html 6 additions, 3 deletionslms/templates/login.html
Please register or sign in to comment