Merge pull request #18659 from edx/ai/EDUCATOR-2588-moderator

Fix forums threads load issue in the user view.

lms/djangoapps/discussion/static/discussion/js/discussion_board_factory.js

@@ -32,6 +32,9 @@
                     routerEvents;
 
                 // TODO: eliminate usage of global variables when possible
+                if (options.roles === undefined) {
+                    options.roles = {};
+                }
                 DiscussionUtil.loadRoles(options.roles);
                 window.$$course_id = options.courseId;
                 window.courseName = options.courseName;

lms/djangoapps/discussion/static/discussion/js/discussion_profile_page_factory.js

@@ -33,6 +33,9 @@
                     'Community TA': []
                 });
 
+                if (options.roles === undefined) {
+                    options.roles = {};
+                }
                 DiscussionUtil.loadRoles(options.roles);
                 window.$$course_id = options.courseId;
                 window.courseName = options.courseName;

lms/djangoapps/discussion/static/discussion/js/spec/discussion_profile_page_factory_spec.js

@@ -17,7 +17,7 @@ define(
                     DiscussionProfilePageFactory(_.extend(
                         {
                             courseId: testCourseId,
-                            roles: DiscussionSpecHelper.getTestRoleInfo(),
+                            roles: (options) ? options.roles : DiscussionSpecHelper.getTestRoleInfo(),
                             courseSettings: DiscussionSpecHelper.createTestCourseSettings().attributes,
                             el: $('.discussion-user-threads'),
                             discussion: new Discussion(),
@@ -40,6 +40,11 @@ define(
                 initializeDiscussionProfilePageFactory();
                 expect($('.discussion-user-threads').text()).toContain('Show');
             });
+            it('can render itself when roles are undefined', function() {
+                var options = {roles: undefined};
+                initializeDiscussionProfilePageFactory(options);
+                expect($('.discussion-user-threads').text()).toContain('Show');
+            });
         });
     }
 );