Skip to content
Snippets Groups Projects
Unverified Commit 7791f155 authored by Dillon Dumesnil's avatar Dillon Dumesnil
Browse files

refactor: AA-692: Update location of is-hidden class when fa icon is used

We ran into a bug where the is-hidden class was being overridden by the
font awesome styling due to a late load of font awesome (causing the
fa class to take precedence). This changes to instead wrap the icon in
the span so there is no competing between the two classes on the same
element
parent 9aefd6f9
No related branches found
No related tags found
No related merge requests found
......@@ -62,16 +62,20 @@
id="tab_${idx}">
<span class="icon fa seq_${item['type']}" aria-hidden="true"></span>
% if 'complete' in item:
<span
class="fa fa-check-circle check-circle ${"is-hidden" if not item['complete'] else ""}"
style="color:green"
aria-hidden="true"
></span>
<span class="check-circle ${"is-hidden" if not item['complete'] else ""}">
<span
class="fa fa-check-circle"
style="color:green"
aria-hidden="true"
></span>
</span>
% if item['complete']:
<span class="sr">${_("Completed")}</span>
%endif
% endif
<span class="fa fa-fw fa-bookmark bookmark-icon ${"is-hidden" if not item['bookmarked'] else "bookmarked"}" aria-hidden="true"></span>
<span class="bookmark-icon ${"is-hidden" if not item['bookmarked'] else "bookmarked"}">
<span class="fa fa-fw fa-bookmark" aria-hidden="true"></span>
</span>
<div class="sequence-tooltip sr"><span class="sr">${item['type']}&nbsp;</span>${item['page_title']}<span class="sr bookmark-icon-sr">&nbsp;${_("Bookmarked") if item['bookmarked'] else ""}</span></div>
</button>
</li>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment