Merge pull request #18757 from edx/ddumesnil/LEARNER-5098

Removing student records waffle flag from LMS

lms/djangoapps/learner_dashboard/tests/test_programs.py

@@ -21,7 +21,6 @@ from openedx.core.djangoapps.catalog.tests.factories import (
     ProgramFactory
 )
 from openedx.core.djangoapps.catalog.tests.mixins import CatalogIntegrationMixin
-from openedx.core.djangoapps.credentials import STUDENT_RECORDS_FLAG
 from openedx.core.djangoapps.programs.tests.mixins import ProgramsApiConfigMixin
 from openedx.core.djangoapps.waffle_utils.testutils import override_waffle_flag
 from openedx.core.djangolib.testing.utils import skip_unless_lms
@@ -183,7 +182,6 @@ class TestProgramListing(ProgramsApiConfigMixin, SharedModuleStoreTestCase):
 @skip_unless_lms
 @mock.patch(PROGRAMS_MODULE + '.get_credit_pathways')
 @mock.patch(PROGRAMS_UTILS_MODULE + '.get_programs')
-@override_waffle_flag(STUDENT_RECORDS_FLAG, active=True)
 class TestProgramDetails(ProgramsApiConfigMixin, CatalogIntegrationMixin, SharedModuleStoreTestCase):
     """Unit tests for the program details page."""
     shard = 4

openedx/core/djangoapps/credentials/__init__.py

@@ -4,10 +4,3 @@ edX Platform support for credentials.
 This package will be used as a wrapper for interacting with the credentials
 service.
 """
-
-from openedx.core.djangoapps.waffle_utils import WaffleFlag, WaffleFlagNamespace
-
-WAFFLE_FLAG_NAMESPACE = WaffleFlagNamespace(name='credentials')
-
-# Waffle flag to enable the experimental Student Records feature
-STUDENT_RECORDS_FLAG = WaffleFlag(WAFFLE_FLAG_NAMESPACE, 'student_records')

openedx/core/djangoapps/credentials/models.py

@@ -11,8 +11,6 @@ from django.utils.translation import ugettext_lazy as _
 
 from openedx.core.djangoapps.site_configuration import helpers
 
-from . import STUDENT_RECORDS_FLAG
-
 API_VERSION = 'v2'
 
 
@@ -93,9 +91,6 @@ class CredentialsApiConfig(ConfigurationModel):
         """
         Publicly-accessible Records URL root.
         """
-        # Temporarily disable this feature while we work on it
-        if not STUDENT_RECORDS_FLAG.is_enabled():
-            return None
         # Not every site wants the Learner Records feature, so we allow opting out.
         if not helpers.get_value('ENABLE_LEARNER_RECORDS', True):
             return None

openedx/features/learner_profile/tests/views/test_learner_profile.py

@@ -13,7 +13,6 @@ from django.urls import reverse
 from django.test.client import RequestFactory
 from lms.djangoapps.certificates.api import is_passing_status
 from opaque_keys.edx.locator import CourseLocator
-from openedx.core.djangoapps.credentials import STUDENT_RECORDS_FLAG
 from openedx.core.djangoapps.waffle_utils.testutils import override_waffle_flag
 from openedx.features.learner_profile.views.learner_profile import learner_profile_context
 from student.tests.factories import CourseEnrollmentFactory, UserFactory
@@ -23,7 +22,6 @@ from xmodule.modulestore.tests.factories import CourseFactory
 
 
 @ddt.ddt
-@override_waffle_flag(STUDENT_RECORDS_FLAG, active=True)
 class LearnerProfileViewTest(UrlResetMixin, ModuleStoreTestCase):
     """ Tests for the student profile view. """