Skip to content
Snippets Groups Projects
Commit 889f7d49 authored by usama sadiq's avatar usama sadiq Committed by usamasadiq
Browse files

Updated LtiBackend.authenticate() method

Added a positional `request` arugment in the function header.
parent e7f112c6
No related branches found
No related tags found
No related merge requests found
......@@ -199,9 +199,13 @@ class LtiBackendTest(TestCase):
lti_user_id=self.lti_user_id,
edx_user=self.edx_user
).save()
self.old_user = UserFactory.create()
self.request = RequestFactory().post('/')
self.request.user = self.old_user
def test_valid_user_authenticates(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_user_id=self.lti_user_id,
lti_consumer=self.lti_consumer
......@@ -210,6 +214,7 @@ class LtiBackendTest(TestCase):
def test_missing_user_returns_none(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_user_id='Invalid Username',
lti_consumer=self.lti_consumer
......@@ -220,12 +225,14 @@ class LtiBackendTest(TestCase):
non_edx_user = UserFactory.create()
non_edx_user.save()
user = users.LtiBackend().authenticate(
self.request,
username=non_edx_user.username,
)
self.assertIsNone(user)
def test_missing_lti_id_returns_null(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_consumer=self.lti_consumer
)
......@@ -233,6 +240,7 @@ class LtiBackendTest(TestCase):
def test_missing_lti_consumer_returns_null(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_user_id=self.lti_user_id,
)
......
......@@ -119,7 +119,7 @@ class LtiBackend(object):
identity (i.e. the user was created by the create_lti_user method above).
"""
def authenticate(self, username=None, lti_user_id=None, lti_consumer=None):
def authenticate(self, _request, username=None, lti_user_id=None, lti_consumer=None):
"""
Try to authenticate a user. This method will return a Django user object
if a user with the corresponding username exists in the database, and
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment