Skip to content
Snippets Groups Projects
Unverified Commit 9535c37c authored by Nathan Sprenkle's avatar Nathan Sprenkle Committed by GitHub
Browse files

Fix UX issues on Team Management tab (#23417)

* Don't disable download button after click

* Allow reuploading for team membership CSV
parent 6f7585c6
No related branches found
No related tags found
No related merge requests found
...@@ -43,5 +43,10 @@ define([ ...@@ -43,5 +43,10 @@ define([
AjaxHelpers.respondWithError(requests); AjaxHelpers.respondWithError(requests);
expect(view.handleCsvUploadFailure).toHaveBeenCalled(); expect(view.handleCsvUploadFailure).toHaveBeenCalled();
}); });
it('should clear input file after upload to allow reuploading', function() {
view.uploadCsv(mockUploadClickEvent);
expect(view.$('#upload-team-csv-input').prop('value')).toEqual('');
});
}); });
}); });
...@@ -17,7 +17,7 @@ ...@@ -17,7 +17,7 @@
}, },
events: { events: {
'click #download-team-csv-input': ViewUtils.withDisabledElement('downloadCsv'), 'click #download-team-csv-input': 'downloadCsv',
'change #upload-team-csv-input': ViewUtils.withDisabledElement('uploadCsv') 'change #upload-team-csv-input': ViewUtils.withDisabledElement('uploadCsv')
}, },
...@@ -44,6 +44,9 @@ ...@@ -44,6 +44,9 @@
var self = this; var self = this;
var formData = new FormData(); var formData = new FormData();
// clear selected file to allow re-uploading
$(event.target).prop('value', '');
formData.append('csv', file); // xss-lint: disable=javascript-jquery-append formData.append('csv', file); // xss-lint: disable=javascript-jquery-append
return $.ajax({ return $.ajax({
type: 'POST', type: 'POST',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment