Shib PR responses to @cpennington and @ormsbee comments
* Changed unicode test cases to ascii encoding * Removed 'stanford' hardcoding in TOS logic in lieu of 'SHIB_DISABLE_TOS' MIT_FEATURES flag * made 'external_auth' always an installed_app in lms * log.exception changd to log.error where appropriate But: did not change skipping tests to changing settings, for reasons stated here: https://github.com/edx/edx-platform/pull/67#issuecomment-19790330
Showing
- common/djangoapps/external_auth/tests/test_shib.py 2 additions, 3 deletionscommon/djangoapps/external_auth/tests/test_shib.py
- common/djangoapps/external_auth/views.py 6 additions, 4 deletionscommon/djangoapps/external_auth/views.py
- common/djangoapps/student/views.py 13 additions, 12 deletionscommon/djangoapps/student/views.py
- lms/envs/common.py 8 additions, 0 deletionslms/envs/common.py
- lms/envs/test.py 1 addition, 3 deletionslms/envs/test.py
Please register or sign in to comment