Skip to content
Snippets Groups Projects
Commit b8a38bd8 authored by Kyle McCormick's avatar Kyle McCormick Committed by Kyle McCormick
Browse files

Improve logging for CourseOverview creation

parent 28c04333
No related branches found
Tags release-2020-01-24-15.46
No related merge requests found
...@@ -232,6 +232,10 @@ class CourseOverview(TimeStampedModel): ...@@ -232,6 +232,10 @@ class CourseOverview(TimeStampedModel):
- IOError if some other error occurs while trying to load the - IOError if some other error occurs while trying to load the
course from the module store. course from the module store.
""" """
log.info(
"Attempting to load CourseOverview for course %s from modulestore.",
course_id,
)
store = modulestore() store = modulestore()
with store.bulk_operations(course_id): with store.bulk_operations(course_id):
course = store.get_course(course_id) course = store.get_course(course_id)
...@@ -259,10 +263,15 @@ class CourseOverview(TimeStampedModel): ...@@ -259,10 +263,15 @@ class CourseOverview(TimeStampedModel):
# other one will cause an IntegrityError because it tries # other one will cause an IntegrityError because it tries
# to save a duplicate. # to save a duplicate.
# (see: https://openedx.atlassian.net/browse/TNL-2854). # (see: https://openedx.atlassian.net/browse/TNL-2854).
pass log.info(
"Multiple CourseOverviews for course %s requested "
"simultaneously; will only save one.",
course_id,
)
except Exception: except Exception:
log.exception( log.exception(
u"CourseOverview for course %s failed!", "Saving CourseOverview for course %s failed with "
"unexpected exception!",
course_id, course_id,
) )
raise raise
...@@ -270,11 +279,16 @@ class CourseOverview(TimeStampedModel): ...@@ -270,11 +279,16 @@ class CourseOverview(TimeStampedModel):
return course_overview return course_overview
elif course is not None: elif course is not None:
raise IOError( raise IOError(
u"Error while loading course {} from the module store: {}", "Error while loading CourseOverview for course {} "
"from the module store: {}",
six.text_type(course_id), six.text_type(course_id),
course.error_msg if isinstance(course, ErrorDescriptor) else six.text_type(course) course.error_msg if isinstance(course, ErrorDescriptor) else six.text_type(course)
) )
else: else:
log.info(
"Could not create CourseOverview for non-existent course: %s",
course_id,
)
raise cls.DoesNotExist() raise cls.DoesNotExist()
@classmethod @classmethod
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment