fix: the get_completion JS handler should not ignore FBE blocks
Because xblock handlers normally get a block tree that already has inaccessible blocks stripped, they don't see FBE gated blocks at all. So the get_completion handler would return True for FBE units incorrectly. Leading to a visual bug as an audit user went through their units in the courseware. In order to let the handler know about the full tree, I've added a new attribute you can set on your xblock handlers: my_handler.will_recheck_access = True This will tell the top-level handler code get the full tree for you. As part of this, I've also changed the sequence xblock handler's into proper xblock handlers (not old-style xmodule handlers). This changes their URLs slightly. I've kept the old URLs for now as well, but they'll be removed after Maple. AA-409
Showing
- common/lib/xmodule/xmodule/js/spec/sequence/display_spec.js 2 additions, 1 deletioncommon/lib/xmodule/xmodule/js/spec/sequence/display_spec.js
- common/lib/xmodule/xmodule/js/src/sequence/display.js 8 additions, 9 deletionscommon/lib/xmodule/xmodule/js/src/sequence/display.js
- common/lib/xmodule/xmodule/js/src/xmodule.js 1 addition, 1 deletioncommon/lib/xmodule/xmodule/js/src/xmodule.js
- common/lib/xmodule/xmodule/seq_module.py 66 additions, 42 deletionscommon/lib/xmodule/xmodule/seq_module.py
- common/lib/xmodule/xmodule/tests/test_sequence.py 63 additions, 36 deletionscommon/lib/xmodule/xmodule/tests/test_sequence.py
- lms/djangoapps/courseware/module_render.py 46 additions, 23 deletionslms/djangoapps/courseware/module_render.py
- lms/djangoapps/courseware/tests/test_module_render.py 25 additions, 0 deletionslms/djangoapps/courseware/tests/test_module_render.py
- lms/templates/seq_module.html 1 addition, 1 deletionlms/templates/seq_module.html
- openedx/core/djangoapps/courseware_api/views.py 1 addition, 1 deletionopenedx/core/djangoapps/courseware_api/views.py
Loading
Please register or sign in to comment