Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
edx-platform-release
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hsin-Yu Chien
edx-platform-release
Commits
f495f219
Commit
f495f219
authored
12 years ago
by
Carlos Andrés Rocha
Browse files
Options
Downloads
Patches
Plain Diff
Update common/djangoapps/external_auth/views.py
Corrected comments on OpenID temporal fix
parent
a88a8577
No related branches found
Branches containing commit
Tags
release-2020-10-30-12.40
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
common/djangoapps/external_auth/views.py
+5
-5
5 additions, 5 deletions
common/djangoapps/external_auth/views.py
with
5 additions
and
5 deletions
common/djangoapps/external_auth/views.py
+
5
−
5
View file @
f495f219
...
...
@@ -488,16 +488,16 @@ def provider_login(request):
url
=
endpoint
+
urlquote
(
user
.
username
)
response
=
openid_request
.
answer
(
True
,
None
,
url
)
# TODO: for CS50 we are forcibly returning
only th
e
#
username. Following
the OpenID simple registration
# TODO: for CS50 we are forcibly returning
the usernam
e
#
instead of fullname. In
the OpenID simple registration
# extension, we don't have to return any fields we don't
# want to, even if they were marked as required by the
# Consumer. The behavior of what to do when there are
# missing fields is up to the Consumer. The proper change
#
will
only return the username, however this will likely
#
should
only return the username, however this will likely
# break the CS50 client. Temporarily we will be returning
# username filling in for
email and
fullname in addition
#
to username
as sreg nickname.
# username filling in for fullname in addition
to username
# as sreg nickname.
results
=
{
'
nickname
'
:
user
.
username
,
'
email
'
:
user
.
email
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment