Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
edx-platform-release
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hsin-Yu Chien
edx-platform-release
Commits
fc4686b8
Commit
fc4686b8
authored
11 years ago
by
Valera Rozuvan
Browse files
Options
Downloads
Patches
Plain Diff
Add a missing comment documenting the changes done in PR 2841.
parent
2a149a8b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
common/lib/xmodule/xmodule/js/src/video/03_video_player.js
+11
-0
11 additions, 0 deletions
common/lib/xmodule/xmodule/js/src/video/03_video_player.js
with
11 additions
and
0 deletions
common/lib/xmodule/xmodule/js/src/video/03_video_player.js
+
11
−
0
View file @
fc4686b8
...
...
@@ -558,6 +558,17 @@ function (HTML5Video, Resizer) {
}
);
// Because of a recent change in the YouTube API (not documented), sometimes
// HTML5 mode loads after Flash mode has been loaded. In this case we have
// multiple speeds available but the variable `this.currentPlayerMode` is
// set to "flash". This is impossible because in Flash mode we can have
// only one speed available. Therefore we must execute the following code
// block if we have multiple speeds or if `this.currentPlayerMode` is set to
// "html5". If any of the two conditions are true, we then set the variable
// `this.currentPlayerMode` to "html5".
//
// For more information, please see the PR that introduced this change:
// https://github.com/edx/edx-platform/pull/2841
if
(
(
this
.
currentPlayerMode
===
'
html5
'
||
availablePlaybackRates
.
length
>
1
)
&&
this
.
videoType
===
'
youtube
'
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment