Skip to content
Snippets Groups Projects
  1. May 01, 2020
  2. Apr 30, 2020
  3. Apr 29, 2020
  4. Apr 28, 2020
    • Robert Raposa's avatar
      Revert "remove tests causing flakiness (#23827)" (#23830) · e63a7a49
      Robert Raposa authored
      This reverts commit be1aaa00.
    • Robert Raposa's avatar
      fix issue with is_in_memory_db · b74acce6
      Robert Raposa authored
      For mysql, it seems `is_in_memory_db` does not even exist. Ensure it
      exists before calling it.
      b74acce6
    • Robert Raposa's avatar
      remove tests causing flakiness (#23827) · be1aaa00
      Robert Raposa authored
      These removed tests can be restored once someone works out why they
      were causing flakiness elsewhere and fix the problem.
      
      Reverts tests added in:
      https://github.com/edx/edx-platform/commit/dca50aacc3093c29c830cccae5746247ecb6f02b
    • David Ormsbee's avatar
      Merge pull request #23246 from open-craft/samuel/lx-744-more-metadata · 617fe431
      David Ormsbee authored
      [SE-2264] [LX-744] Return more metadata in xblock api
    • Braden MacDonald's avatar
      Cache Blockstore XBlock field data per thread, not per-process · cb588738
      Braden MacDonald authored
      The cache in the previous version of this code was unwittingly being
      shared among all threads, and an occasional race condition would result
      in the .children field of some XBlocks containing duplicate entries.
      
      I tried to find other ways to keep the existing cache design and let it
      be shared among all the threads (which would be more efficient), but I
      couldn't find any clean way of doing it (and even then, this code was
      not written with the intention of being used in a multi-threaded way).
      So to keep the fix simple, I made the block data cache thread-local
      instead of process-local. That eliminated the bug.
      
      Technical details:
      
      The big challenge with this code in the first place was due to the
      parse_xml API of XBlocks, which instantiates the XBlock instance and
      _then_ sets field data on it and returns it, as there is no mechanism
      available to distinguish that from the case of instantiating an XBlock
      (using previously loaded/cached field data) and then deliberately
      changing its field values. In particular, parse_xml sets the 'children'
      field just by calling self.children.append(...) but never explicitly
      initializes self.children to [] first, so it's necessary for the field
      data store to have a mechanism for setting self.children = [] when
      parsing begins, but it's hard to know "when parsing begins" in general.
      
      This is made more challenging since the BlockstoreFieldData design ties
      field data changes to the XBlock instance itself (using a weakkey), but
      it's impossible to get a reference to the XBlock instance before calling
      parse_xml, and since the BlockstoreFieldData design uses a pass-through
      approach where fields that aren't being actively changed are read from
      the cache; since it doesn't know when children is being initialized vs.
      being modified, it would sometimes pass-through and start one thread's
      changes with the final result from another thread.
      
      Anyhow, the bottom line is that avoiding unintentional multithreading
      here solves the problem.
      
      If we want the field data cache to be shared among threads, it might as
      well be rewritten to use memcached and shared among all processes too.
      That would be a very good performance boost but would take up a lot more
      memory in memcached. Also the rewrite may be challenging due to the
      aforementioned nuances of the XBlock parse_xml / construct_xblock /
      add_node_as_child APIs. Perhaps modifying the runtime to use a
      completely separate fielddata implementation for parsing vs. loading a
      parsed+cached XBlock would do it.
      cb588738
    • stvn's avatar
      Merge PR #23820 debug/mfe-iframe-resize · 0f5c474f
      stvn authored
      * Commits:
        Add logging to Learning MFE iframe, temporarily
      0f5c474f
    • stvn's avatar
      Add logging to Learning MFE iframe, temporarily · 2ddc35cd
      stvn authored
      to debug Firefox event handling that cannot be reproduced locally.
      
      See TNL-7187 [1] for more details.
      
      - [1] https://openedx.atlassian.net/browse/TNL-7187
      2ddc35cd
    • Tim McCormack's avatar
      Use pip-sync to make sure that dep cache tarball can go safely stale · d435f4cd
      Tim McCormack authored
      This "fixes" egg-links in a really hacky way to compensate for the lack
      of a real relocatable virtualenv.
      d435f4cd
    • Tim McCormack's avatar
      Extract worker setup into own shell script, as much as possible · 0a079e75
      Tim McCormack authored
      This also changes DJANGO_REQUIREMENT to be a single file arg.
      0a079e75
    • edX requirements bot's avatar
    • Ahtisham Shahid's avatar
      Merge pull request #23749 from edx/ahtisham/PROD-1476 · f14946d1
      Ahtisham Shahid authored
      Disabled copy/paste in confirm email
    • Ahtisham Shahid's avatar
      Disabled copy/paste in confirm email · 8af94ec7
      Ahtisham Shahid authored
      Created sorting for email field
      
      updated tests
      
      Fixed sorting issue in registration form
      
      Fixed sorting issue in registration form
      
      Fixed sorting issue in registration form
      
      Added missing items in env and updated order logic
      
      Added missing items in env and updated order logic
      8af94ec7
  5. Apr 27, 2020