Skip to content
Snippets Groups Projects
  1. Nov 17, 2021
  2. Nov 16, 2021
  3. Nov 10, 2021
  4. Nov 09, 2021
  5. Nov 08, 2021
  6. Nov 04, 2021
  7. Nov 03, 2021
  8. Nov 02, 2021
  9. Nov 01, 2021
    • michaelroytman's avatar
      feat: Remove Use of VERIFIED_NAME_FLAG Waffle Flag and is_verified_enabled Utility · bb299c95
      michaelroytman authored
      The VERIFIED_NAME_FLAG, the VerifiedNameEnabledView, and the verified_name_enabled key removed from responses for both VerifiedNameView view and VerifiedNameHistoryView
      were removed as part https://github.com/edx/edx-name-affirmation/pull/12. This was released in version 2.0.0 of the edx-name-affirmation PyPI package. Please see below for additional context for the removal, copied from the name-affirmation commit message.
      
      The VERIFIED_NAME_FLAG was added as part https://github.com/edx/edx-name-affirmation/pull/12, [MST-801](https://openedx.atlassian.net/browse/MST-801) in order to control the release of the Verified Name project. It was used for a phased roll out by percentage of users.
      
      The release reached a percentage of 50% before it was observed that, due to the way percentage roll out works in django-waffle, the code to create or update VerifiedName records was not working properly. The code was written such that any change to a SoftwareSecurePhotoVerification model instance sent a signal, which was received and handled by the Name Affirmation application. If the VERIFIED_NAME_FLAG was on for the requesting user, a Celery task was launched from the Name Affirmation application to perform the creation of or update to the appropriate VerifiedName model instances based on the verify_student application signal. However, we observed that when SoftwareSecurePhotoVerification records were moved into the "created" or "ready" status, a Celery task in Name Affirmation was created, but when SoftwareSecurePhotoVerification records were moved into the "submitted" status, the corresponding Celery task in Name Affirmation was not created. This caused VerifiedName records to stay in the "pending" state.
      
      The django-waffle waffle flag used by the edx-toggle library implements percentage rollout by setting a cookie in a learner's browser session to assign them to the enabled or disabled group.
      It turns out that the code that submits a SoftwareSecurePhotoVerification record, which moves it into the "submitted" state, happens as part of a Celery task in the verify_student application in the edx-platform. Therefore, we believe that because there is no request object in a Celery task, the edx-toggle code is defaulting to the case where there is no request object. In this case, the code checks whether the flag is enabled for everyone when determining whether the flag is enabled. Because of the percentage rollout (i.e. waffle flag not enabled for everyone), the Celery task in Name Affirmation is not created. This behavior was confirmed by logging added as part of https://github.com/edx/edx-name-affirmation/pull/62.
      
      We have determined that we do not need the waffle flag, as we are comfortable that enabling the waffle flag for everyone will fix the issue and are comfortable releasing the feature to all users. For this reason, we are removing references to the flag.
      
      [MST-1130](https://openedx.atlassian.net/browse/MST-1130)
      bb299c95
    • alangsto's avatar
  10. Oct 29, 2021
  11. Oct 28, 2021
  12. Oct 27, 2021
  13. Oct 26, 2021
  14. Oct 22, 2021
  15. Oct 20, 2021
  16. Oct 19, 2021
  17. Oct 18, 2021
  18. Oct 14, 2021
  19. Oct 13, 2021
  20. Oct 11, 2021