Skip to content
Snippets Groups Projects
  1. Jan 14, 2021
  2. Jan 13, 2021
  3. Jan 12, 2021
    • Adam Stankiewicz's avatar
    • Alex Dusenbery's avatar
      Update edx-enterprise to 3.17.4 | Include a docstring indicating a preference... · 7908565d
      Alex Dusenbery authored
      Update edx-enterprise to 3.17.4 | Include a docstring indicating a preference that we don't delete EnterpriseCourseEnrollments.
      7908565d
    • edx-abolger's avatar
      Merge pull request #26044 from edx/edx-abolger/enterprise-3-17-3 · 8e54ef43
      edx-abolger authored
      Version bump edx-enterprise to 3.17.3
    • Bianca Severino's avatar
      Merge pull request #26045 from edx/bseverino/proctoring-2.5.8 · c903f736
      Bianca Severino authored
      Update edx-proctoring to 2.5.8
    • Bianca Severino's avatar
      Update edx-proctoring to 2.5.8 · 78165fd3
      Bianca Severino authored
      78165fd3
    • David Ormsbee's avatar
      Check sequence-level gating in render_xblock (TNL-7636). · 5f94a082
      David Ormsbee authored
      There is certain gating logic around pre-reqs, timed exams, etc.
      that happen at the SequenceModule level, and should be respected
      when rendering descendant XBlocks (like individual problems) that
      are in that Sequence. Rather than do a risky refactoring, I'm
      keeping that logic where it is and having the render_xblock view
      climb up through the ancestor list to call the SequenceModule for
      that gating information.
      
      We do _not_ check all descendants (so cousin leaf nodes in the
      sequence) for cotent-type-based restrictions because sequences can
      become very large (esp. when content libraries are used), and there
      is a performance overhead.
      
      If the enclosing sequence is gated in some way, we redirect to the
      render_xblock view for that sequence, where hopefully some useful
      messaging will be available. This is a stopgap. That redirect
      should never happen because we should never be calling the leaf
      XBlock for a sequence that is restricted in the MFE. But if somehow
      we get there anyway, either by bug or by intrepid user fiddling,
      it's better to redirect somewhere that an error _might_ be surfaced
      rather than just failing.
      
      This will actually be a little overzealous and lock things down
      that should be made visible later. If there's a timed exam and the
      exam is completed, it should be the case that content is visible
      (just read-only). This commit will block the content before the exam
      starts (this is right), open the content while the exam is live
      (this is right), but make the content unavailable after the exam
      period has finished (this is wrong).
      
      But I am going to go forward with this even knowing it's wrong
      because:
      
      1. The render_xblock endpoint should never currently be used in
         timed exams in an intentional way. Neither the mobile experience
         nor the courseware MFE support it.
      2. This fix will address security concerns for creative access
         patterns, even if it goes too far.
      3. We're going to need to do a lot of work to address both pluggable
         access permissions handling and special exams in the courseware
         MFE, and a better implementation can be done then.
      4. I've had multiple failed attempts to get this to work without
         breaking things on and off over the course of weeks, and this
         is a relatively low risk way of doing it that doesn't involve
         a major refactoring (though the bill for that will come due
         when we bring timed exams to the MFE).
      5f94a082
    • Zainab Amir's avatar
      fix login cookie parse issue (#26032) · 2e6e360f
      Zainab Amir authored
    • Adrienne Bolger's avatar
      Version bump edx-enterprise to 3.17.3 · 81b8fada
      Adrienne Bolger authored
      81b8fada
    • David Ormsbee's avatar
      Enable timed/special exams and pre-reqs in devstack. · 5a149f0f
      David Ormsbee authored
      These are common and useful enough features that it makes sense to
      enable it for developers by default.
      5a149f0f
    • Régis Behmo's avatar
      Document non-namespaced waffle classes in ADR · d04d4291
      Régis Behmo authored
      It was finally decided not to use `skip_namespace_assertion` optional
      arguments, but `NonNamespacedWaffle*` classes. We update the ADR to reflect
      this change.
      d04d4291
    • Régis Behmo's avatar
      Get rid of calls to `set_request_cache_with_short_name` · 3a29cff0
      Régis Behmo authored
      This method from the toggle legacy classes should not actually be
      exposed to all. So we get rid of it by manually setting the cached
      value. While we are at it, we convert the STORAGE_BACKING_FOR_CACHE
      legacy waffle switch to its modern version. As the flag is not being
      used elsewhere, this should not break anything.
      
      We take the opportunity to modernize waffle switches from
      block_structure.config: to do so we convert the INVALIDATE_CACHE_ON_PUBLISH and
      RAISE_ERROR_WHEN_NOT_FOUND waffle switches from legacy classes to their modern
      equivalents. These switches are not used outside of edx-platform, so this
      change should not trigger any error.
      3a29cff0
Loading