Skip to content
Snippets Groups Projects
  1. Apr 02, 2021
    • Feanil Patel's avatar
      test: Add a test for setup_masquerade. · 4f725aa1
      Feanil Patel authored
      Test to verify the side-effects of calling this function since we now
      rely on one of them in the SafeSessionMiddleware.
      4f725aa1
    • Feanil Patel's avatar
      test: Test login redirects prefer session cookies. · c45ffd75
      Feanil Patel authored
      Add a test to ensure that the login page redirect as long as we have a
      valid session even if we have expired on non-existent JWT cookies.
      c45ffd75
    • Feanil Patel's avatar
      fix: Assume logged in if user has a valid session. · 118f0951
      Feanil Patel authored
      Previously they also had to have a valid JWT cookie which led to a weird
      corner case where a user was logged in but still showed the login form
      resulting in some confusion and odd behavior.
      
      This change gives precedence to the session token to determine whether
      or not someone is logged into the LMS but ensures that if you go through
      the login flow, you refresh your JWT cookies. This should not cause any
      breakage for MFE flows that might redirect to the LMS login page since
      the JWT would get refreshed if it's out of date but the session is
      valid.
      118f0951
    • Feanil Patel's avatar
      fix: Print more stack frames on requset tracing. · 23f2b758
      Feanil Patel authored
      Six frames was not enough because for DRF views the request gets wrapped
      in a proxy object and so we need more of the stack to see what part of
      the code we're in that actually invokes the use change.
      23f2b758
  2. Apr 01, 2021
    • Feanil Patel's avatar
      fix: Don't log warnings on logout. · 5b7caf45
      Feanil Patel authored
      When a user logs out, there are warnings logged right now because the
      session user_id mismatches(it becomes None on logout).  Previously we
      would log the request mismatch on debug and the session mismatch as
      normal.
      
      This change will result in us logging nothing if the session change is
      not abnormal.
      5b7caf45
  3. Mar 30, 2021
  4. Mar 29, 2021
  5. Mar 26, 2021
  6. Mar 25, 2021