Skip to content
Snippets Groups Projects
  1. Aug 11, 2021
  2. Aug 10, 2021
  3. Aug 09, 2021
  4. Aug 05, 2021
    • Manjinder Singh's avatar
    • Braden MacDonald's avatar
      refactor: run modulestore tests in common/lib/... using Django · da09bcad
      Braden MacDonald authored
      Does 3 things:
      (1) Use django for modulestore tests
      (2) Use normal LMS settings for modulestore tests instead of openedx/tests/settings.py
      (3) Simplify some TestCase subclasses by converting them to use ModuleStoreTestCase
      
      
      Details and rationale:
      
      (1) Currently parts of the modulestore test suite are designed to run "without django", although there is still a lot of django functionality imported at times, and many of the tests do in fact use django. But for the upcoming PR #27565 (moving split's course indexes from MongoDB to MySQL), we will need to always have Django enabled. So this commit paves the way for that change.
      
      (2) The previous tests that did use Django used a special settings file, openedx/tests/settings.py which made some debugging confusing because those tests had quite different django settings than other tests. This change deletes that file and runs the tests using the LMS test settings.
      
      (3) The test suite also contains many different ways of initializing and testing a modulestore, with significant differences in their configuration, and also a lot of repetition. I find this makes understanding, debugging and writing tests more difficult. So this commit also reduces the number of different "test case using modulestore" base classes:
      
      * Simplifies MixedWithOptionsTestCase and MixedSplitTestCase by making them simple subclasses of ModuleStoreTestCase.
      * Removes PureModulestoreTestCase.
      da09bcad
    • Braden MacDonald's avatar
    • Braden MacDonald's avatar
      fix: use integer user IDs consistently for modulestore APIs/tests · 188e9fb1
      Braden MacDonald authored
      Some actions in split modulestore record the user ID who requested the action. Currently, split modulestore doesn't care what data type you use for those user IDs. Most of the codebase uses integers, but some tests used username or email address strings.
      
      My upcoming PR #27565 will move split modulestore's "course index" data from MongoDB into MySQL. In doing so, it requires that user IDs are always numeric. So this PR paves the way for that one by using numeric IDs consistently in all test cases. I believe the actual non-test code was already consistently using integer IDs.
      188e9fb1
    • edX cache uploader bot's avatar
    • Ken Clary's avatar
      feat: add explicit courserun_key parameter to /event endpoint · bbb14a2c
      Ken Clary authored
      We add 'courserun_key' (aka "course_id" though that's technically a
      misnomer) as an optional parameter to the /event endpoint url. If it
      is not present, it will still be parsed out of the url, if the url is
      of the right format.
      
      Additionally, Logger.log() in js adds this parameter to its /event
      call, pulling it from the $$course_id global.
      
      This provides opportunity for MFEs to (separately) provide the key
      without concern about url parsing.
      
      TNL-7752
      bbb14a2c
  5. Aug 04, 2021
  6. Aug 03, 2021
  7. Aug 02, 2021
  8. Jul 30, 2021
    • Ken Clary's avatar
      feat: add explicit courserun_key parameter to /event endpoint · 67a33d47
      Ken Clary authored
      We add 'courserun_key' (aka "course_id" though that's technically a
      misnomer) as an optional parameter to the /event endpoint url. If it
      is not present, it will still be parsed out of the url, if the url is
      of the right format.
      
      Additionally, Logger.log() in js adds this parameter to its /event
      call, pulling it from the $$course_id global.
      
      This provides opportunity for MFEs to (separately) provide the key
      without concern about url parsing.
      
      TNL-7752
      67a33d47
    • Christie Rice's avatar
      feat!: Add migration to drop the CertificateWhitelist table (#28307) · 8971c99d
      Christie Rice authored
      This model has been replaced by the CertificateAllowlist.
      
      MICROBA-1304
    • Ken Clary's avatar
      feat: add explicit courserun_key parameter to /event endpoint · 13b6ed90
      Ken Clary authored
      We add 'courserun_key' (aka "course_id" though that's technically a
      misnomer) as an optional parameter to the /event endpoint url. If it
      is not present, it will still be parsed out of the url, if the url is
      of the right format.
      
      Additionally, Logger.log() in js adds this parameter to its /event
      call, pulling it from the $$course_id global.
      
      This provides opportunity for MFEs to (separately) provide the key
      without concern about url parsing.
      
      TNL-7752
      13b6ed90
  9. Jul 29, 2021
  10. Jul 28, 2021
  11. Jul 27, 2021
  12. Jul 26, 2021
  13. Jul 24, 2021
  14. Jul 23, 2021
  15. Jul 22, 2021
    • connorhaugh's avatar
      fix: oblige non-studio-authoring submit settings (#28253) · 9d25982f
      connorhaugh authored
      Problem blocks offer a setting to make users wait a set time between submissions. If a course is not authored in studio, it might not set a value for this setting. Consequently, the problem block must handle the submission_wait_seconds field to be none, so it doesn't break the submitted responses.
      
      These kinds of errors here will prevent learners from submitting any answer, and has for several learners. Adding in this one-line change will prevent future errors without having to change the authoring practices of those ambitious enough to write their courses with import.
      
      This also catches the case that some internal process other than studio might be creating problems with "none" as the setting.
      
      In response to TNL-8234
      
      Testing: hand-testing by importing the following problem xml file within a course and attempting to answer as learner(answer is 10.4).
    • Piotr Surowiec's avatar
      fix: hide unavailable sequence title in course breadcrumbs (#28028) · a5d9dd4f
      Piotr Surowiec authored
      When a sequence title was unavailable for a user (e.g. before starting a timed
      exam), the `None` value was displayed in course breadcrumbs. This hides it in
      such cases and ensures that a trailing breadcrumb separator is not displayed.
  16. Jul 21, 2021