Skip to content
Snippets Groups Projects
  1. Feb 25, 2019
  2. Feb 24, 2019
    • David Ormsbee's avatar
      Improve SafeCookieData Error Logging · 40e1e1e5
      David Ormsbee authored
      1. Use request.session instead of request.user, since request.user
      won't necessarily be properly set.
      
      2. Be extra paranoid by putting logging after session cookie deletion,
      so that even if there is some error related to logging, the important
      work will complete and the browser won't get left in a broken state.
      
      3. Write out the full contents of the Cookie header (up to 4096 bytes)
      in the log as a base64 encoded string. This way we can look at broken
      cookie states and diagnose what's breaking them (the Python parser will
      just silently skip anything past a corrupted cookie entry). We base64
      encode mostly to prevent people from maliciously injecting garbage into
      our logs.
      40e1e1e5
  3. Feb 23, 2019
  4. Feb 22, 2019
  5. Feb 21, 2019
Loading