Skip to content
Snippets Groups Projects

LIBTD-1335: Migrate Composition+Performance Work creation/update functionality to Hyrax 2.1.0

Merged Janice J Kim requested to merge LIBTD-1335 into LIBTD-1334

This pull requests contains modifications that essentially reimplement the Composition and Performance Work creation/update functionality to Hyrax 2.1.0 from Hyrax 1.0.3.

Code/Functionality is being migrated from: https://github.com/VTUL/binary-arts/tree/5b89406e1aa662c2d5e039b370ea5067dbe26ac5

The bulk of the Composition and Performance functionality is there, but customized stylesheets are still missing and can be added in later with LIBTD-1341. For example, the Composition Composer and Performance Performer are still visible in the forms, but this will change once the stylesheets have been brought over.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Contributor

    In Hyrax 1.0.3, the default based_near field was a plain input field. It was changed to an auto-complete field using geonames sometime after with later versions of Hyrax. It makes sense to change it back to plain input for now. If it's something that's desirable in the future, we can revert this change.

  • Created by: tingtingjh

    Try to use the newly introduced "location" directly in case the based_near being used by Hyrax2 in some specific way? Just need to change some labelings and edit_fields and show pages.

  • Author Contributor

    I migrated over the location property from the Hyrax 1.0.3 version, and it does not appear to be used there either. After discussing more with Tingting, we've decided to just remove the location references for now. They can put back in at a later time. (Also, this may potentially be addressed again in the clean up of the form entries with issues LIBTD-1330 and LIBTD-1331.)

  • Created by: tingtingjh

    Based_near property doesn't seem to populated at the show page.

  • Author Contributor

    It's true that the based_near isn't being displayed. It feels like the binary-arts dev branch that we're migrating code from may be not quite clean. It is a dev branch after all. Going forward, we may change less of these sorts of things in favor of making additional tickets after the migration is completed.

    Edit: The based_near property will remain off the show page for now until we get clear metadata expectations.

  • Author Contributor

    Added one more fix (that could potentially be a Hyrax bug) to get the based_near labels to show correctly in the search results.

Please register or sign in to reply
Loading