LIBTD-1441: Put Composition into "Relationships" section at Performance show page

Created by: tingtingjh

JIRA Ticket: https://webapps.es.vt.edu/jira/browse/LIBTD-1441 ()

What does this Pull Request do? ()

Resolve the problem that "composition" relationship displayed on the performance show page would mislead users as a Composition work.

What's the changes? ()

Move the "composition" relationship to "Relationships" section in the performance show page.

How should this be tested?

A description of what steps someone could take to:

• Use the LIBTD-1441 branch for testing
• Create a composition work first.
• Create a performance work associated with the created composition.
• The composition relationship is displayed in the "Relationships" section.
• Create a collection then add the performance work into the collection. (optional)
• Go to performance show page to see both relationships. (optional)

Additional Notes:

Need to create another ticket to make similar changes for Composition show page.

Interested parties

@shabububu

() Required fields

app/views/hyrax/base/_performance_composition_info.html.erb

-<% if !composition.nil? %>
-  <h2>Composition</h2>
-  <div>
-    <strong>Performance of:</strong> <%= link_to "#{composition.title.first}", "/concern/compositions/#{composition.id}" %>
-  </div>
-  <div>
-    <strong>Composed by:</strong> <span class="composition-composer"><%= link_to composition.creator.first, composer_link %></span>
-  </div>
-  <br />
-<% end %>
-
+<dt>Associated Composition:</dt>
+<dd>
+  <strong>Performance of:</strong> <%= link_to "#{composition.title.first}", "/concern/compositions/#{composition.id}" %>
+</dd>
+<dd>
+  <strong>Composed by:</strong> <span class="composition-composer"><%= link_to composition.creator.first, composer_link %></span>
+</dd>