Skip to content
Snippets Groups Projects

Datepicker js optimization

Closed Datepicker js optimization
datepicker-js-optimization into master
Closed Paul Mather requested to merge datepicker-js-optimization into master

Created by: tonmoy18

The date picker ID prefix and number are in different vars Pro: no need to read, slice and append to ID every time Con: the original ID is changed.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
app/assets/javascripts/datarepo/datepicker.js
25 23 if ($(datepickerClass).length) {
26 24 $.datepicker.setDefaults(datepickerOpts);
27 25 $(datepickerClass).each(function() {
28 $(this).datepicker();
29
26 $(this).datepicker();
  • Paul Mather
    Paul Mather @pmather ·
    Author Owner

    Created by: tonmoy18

    I think I should create a brand new branch, copy all the changes to that branch manually and then delete this branch. Please advise.

  • Paul Mather
    Paul Mather @pmather ·
    Author Owner

    Created by: rotated8

    I think this needs to be rebased against master. If you'd rather recreate the changes, that's fine, too.

  • Paul Mather
    Paul Mather @pmather ·
    Author Owner

    Created by: tonmoy18

    I had problems with this branch from the beginning as I did not recast in the first place, then after resolving merge conflicts I added and commuted again. Created a new branch, it has minimum changes

  • Paul Mather
    Paul Mather @pmather ·
    Author Owner

    Created by: rotated8

    :ok_hand:

    • Please register or sign in to reply